From 7e00288ff09072eda41cc8a7daa53ac8bb94323f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Andr=C3=A9?= Date: Thu, 16 Jun 2016 16:48:39 +0200 Subject: [PATCH] Properly fail precheck for internal VIP's network When kolla_internal_vip_address didn't belong to the same network as network_interface, the prechecks would spit out an ugly error: Unexpected templating type error occurred on [snip]: argument of type 'NoneType' is not iterable" This commit fixes the check to execute properly. Change-Id: I24a066c212c78e105a923525b131724736ac74b6 --- ansible/roles/prechecks/tasks/port_checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ansible/roles/prechecks/tasks/port_checks.yml b/ansible/roles/prechecks/tasks/port_checks.yml index 73489c402f..ef71a6ee45 100644 --- a/ansible/roles/prechecks/tasks/port_checks.yml +++ b/ansible/roles/prechecks/tasks/port_checks.yml @@ -461,4 +461,4 @@ register: ip_addr_output changed_when: false failed_when: "'169.254.' not in kolla_internal_vip_address and \ - 'False' in kolla_internal_vip_address | ipaddr(ip_addr_output.stdout.split()[3])" + kolla_internal_vip_address | ipaddr(ip_addr_output.stdout.split()[3]) is none"