From 83f3422fbd58581f3dea595eb0ac080b86c9fcf9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rados=C5=82aw=20Piliszek?= Date: Tue, 27 Apr 2021 16:03:22 +0000 Subject: [PATCH] Deprecate enable_host_ntp As agreed during IRC meeting. [1] [1] http://eavesdrop.openstack.org/meetings/kolla/2021/kolla.2021-04-07-15.00.html Change-Id: Ibffa019e2106784e97f5c482106bb5082f788752 --- ansible/roles/baremetal/defaults/main.yml | 2 ++ ansible/roles/baremetal/tasks/post-install.yml | 7 +++++++ .../deployment-and-bootstrapping/bootstrap-servers.rst | 5 +++++ .../notes/deprecate-enable-host-ntp-3ad934c097f18b1b.yaml | 7 +++++++ 4 files changed, 21 insertions(+) create mode 100644 releasenotes/notes/deprecate-enable-host-ntp-3ad934c097f18b1b.yaml diff --git a/ansible/roles/baremetal/defaults/main.yml b/ansible/roles/baremetal/defaults/main.yml index 35947469cb..2cd767321e 100644 --- a/ansible/roles/baremetal/defaults/main.yml +++ b/ansible/roles/baremetal/defaults/main.yml @@ -24,6 +24,8 @@ create_kolla_user_sudoers: "{{ create_kolla_user }}" kolla_user: "kolla" kolla_group: "kolla" +# Deprecated since Wallaby. To be dropped in Xena. +# Please use other means of configuring NTP. enable_host_ntp: False change_selinux: True diff --git a/ansible/roles/baremetal/tasks/post-install.yml b/ansible/roles/baremetal/tasks/post-install.yml index d646c0139c..28271b9a63 100644 --- a/ansible/roles/baremetal/tasks/post-install.yml +++ b/ansible/roles/baremetal/tasks/post-install.yml @@ -242,6 +242,13 @@ enabled: yes become: True +- name: Warn about deprecations + debug: + msg: > + enable_host_ntp is deprecated. + Please configure NTP using a different tool. + when: enable_host_ntp | bool + - name: Stop time service service: name: ntp diff --git a/doc/source/reference/deployment-and-bootstrapping/bootstrap-servers.rst b/doc/source/reference/deployment-and-bootstrapping/bootstrap-servers.rst index 147dce9655..cef7e95922 100644 --- a/doc/source/reference/deployment-and-bootstrapping/bootstrap-servers.rst +++ b/doc/source/reference/deployment-and-bootstrapping/bootstrap-servers.rst @@ -229,5 +229,10 @@ then the SELinux state will be set to ``selinux_state`` (default Configuration of NTP daemon ~~~~~~~~~~~~~~~~~~~~~~~~~~~ +.. warning:: + Support for configuration of NTP daemon is deprecated and will be removed in + the next Kolla Ansible release (Xena). + Please use other means of configuring NTP. + This is optional, and enabled by ``enable_host_ntp``, which is ``false`` by default. diff --git a/releasenotes/notes/deprecate-enable-host-ntp-3ad934c097f18b1b.yaml b/releasenotes/notes/deprecate-enable-host-ntp-3ad934c097f18b1b.yaml new file mode 100644 index 0000000000..3fcb862d67 --- /dev/null +++ b/releasenotes/notes/deprecate-enable-host-ntp-3ad934c097f18b1b.yaml @@ -0,0 +1,7 @@ +--- +deprecations: + - | + Support for configuration of NTP daemon (via ``enable_host_ntp``) is + deprecated and will be removed in the next Kolla Ansible release + (Xena). + Please use other means of configuring NTP.