From 8c760d38a0d7708a2b478f79725411b64c4bb73f Mon Sep 17 00:00:00 2001
From: Michal Arbet <michal.arbet@ultimum.io>
Date: Wed, 6 Mar 2024 16:15:42 +0100
Subject: [PATCH] Fix creation of ovs bridges

This patch fixes the creation of the openvswitch
bridge by fixing an ansible task that was rewritten
to use an ansible module, but unfortunately, its loop
was implemented incorrectly.

Closes-Bug: #2056332
Change-Id: Ia55a36c0f9b122b72d757ca973e7d8f76ae84344
---
 ansible/roles/openvswitch/tasks/post-config.yml      | 5 ++---
 releasenotes/notes/bug-2056332-0edb6cfd2efc4c1a.yaml | 6 ++++++
 2 files changed, 8 insertions(+), 3 deletions(-)
 create mode 100644 releasenotes/notes/bug-2056332-0edb6cfd2efc4c1a.yaml

diff --git a/ansible/roles/openvswitch/tasks/post-config.yml b/ansible/roles/openvswitch/tasks/post-config.yml
index 68ad2b1450..1714ad4e77 100644
--- a/ansible/roles/openvswitch/tasks/post-config.yml
+++ b/ansible/roles/openvswitch/tasks/post-config.yml
@@ -25,10 +25,9 @@
     user: root
     module_name: openvswitch_bridge
     module_args:
-      bridge: "{{ item.0 }}"
+      bridge: "{{ item }}"
       fail_mode: standalone
-  loop:
-    - "{{ neutron_bridge_name.split(',') }}"
+  loop: "{{ neutron_bridge_name.split(',') }}"
   when:
     - inventory_hostname in groups["network"]
       or (inventory_hostname in groups["compute"] and computes_need_external_bridge | bool )
diff --git a/releasenotes/notes/bug-2056332-0edb6cfd2efc4c1a.yaml b/releasenotes/notes/bug-2056332-0edb6cfd2efc4c1a.yaml
new file mode 100644
index 0000000000..154a10a517
--- /dev/null
+++ b/releasenotes/notes/bug-2056332-0edb6cfd2efc4c1a.yaml
@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Fixes an issue with ``openvswitch`` bridge creation when
+    ``neutron_bridge_name`` was specified as two bridges.
+    `LP#2056332 <https://bugs.launchpad.net/kolla-ansible/+bug/2056332>`__