From 86ddc94ec2f6ec46d6dfc4feeb58c12aaabcd252 Mon Sep 17 00:00:00 2001
From: Mark Goddard <mark@stackhpc.com>
Date: Mon, 24 May 2021 10:52:43 +0100
Subject: [PATCH] Fix exit code with bogus command name
Running this:
$ kolla-ansible bogus-command
Should show usage & give a non-zero exit code. Previously it gave a zero
exit code. This change fixes the issue.
Closes-Bug: #1929397
Change-Id: I580c208d61d5efe115f936dfb8f3f6508acd91b2
---
releasenotes/notes/cli-exit-code-1e6278f803dbf8e2.yaml | 6 ++++++
tools/kolla-ansible | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
create mode 100644 releasenotes/notes/cli-exit-code-1e6278f803dbf8e2.yaml
diff --git a/releasenotes/notes/cli-exit-code-1e6278f803dbf8e2.yaml b/releasenotes/notes/cli-exit-code-1e6278f803dbf8e2.yaml
new file mode 100644
index 0000000000..86cba91ff3
--- /dev/null
+++ b/releasenotes/notes/cli-exit-code-1e6278f803dbf8e2.yaml
@@ -0,0 +1,6 @@
+---
+fixes:
+ - |
+ Fixes an issue where ``kolla-ansible`` exits with a zero exit code when
+ executed with a bogus command name. `LP#1929397
+ <https://bugs.launchpad.net/kolla-ansible/+bug/1929397>`__
diff --git a/tools/kolla-ansible b/tools/kolla-ansible
index 215bcf0ee4..a91fc23b34 100755
--- a/tools/kolla-ansible
+++ b/tools/kolla-ansible
@@ -471,7 +471,7 @@ EOF
exit 0
;;
(*) usage
- exit 0
+ exit 3
;;
esac