From bb15619e80414a2913792a945fdcd112b5fe1671 Mon Sep 17 00:00:00 2001 From: Matt Anson Date: Mon, 29 Sep 2025 17:21:00 +0100 Subject: [PATCH] Only notify handlers in service-check-containers Notification of handlers on service config change is now mostly delegated to the service-check-containers role, but handlers that restart nova_libvirt and ovn_sb_db_relays still remain. Remove these remaining handlers to ensure that all service containers are restarted by service-check-containers. Partial-Bug: #2123946 Change-Id: I57a51fb46cb7c58074044bac76b1160620086cb8 Signed-off-by: Matt Anson --- ansible/roles/nova-cell/tasks/external_ceph.yml | 6 +++--- ansible/roles/ovn-db/tasks/config-relay.yml | 4 ---- .../bug-2123946-notify-handlers-3d0a6a0788d5dcce.yaml | 7 +++++++ 3 files changed, 10 insertions(+), 7 deletions(-) create mode 100644 releasenotes/notes/bug-2123946-notify-handlers-3d0a6a0788d5dcce.yaml diff --git a/ansible/roles/nova-cell/tasks/external_ceph.yml b/ansible/roles/nova-cell/tasks/external_ceph.yml index de8fc143e6..f2d7ba6967 100644 --- a/ansible/roles/nova-cell/tasks/external_ceph.yml +++ b/ansible/roles/nova-cell/tasks/external_ceph.yml @@ -200,6 +200,6 @@ # reload. This may be due to differences in tested versions of libvirt # (8.0.0 vs 6.0.0). Reload should be low overhead, so do it always. libvirt_restart_handlers: >- - {{ ['Restart nova-libvirt container'] - if enable_nova_libvirt_container | bool else - ['Reload libvirtd'] }} + {{ ['Reload libvirtd'] + if not enable_nova_libvirt_container | bool else + [] }} diff --git a/ansible/roles/ovn-db/tasks/config-relay.yml b/ansible/roles/ovn-db/tasks/config-relay.yml index 71c3828768..f26cd2b48f 100644 --- a/ansible/roles/ovn-db/tasks/config-relay.yml +++ b/ansible/roles/ovn-db/tasks/config-relay.yml @@ -19,8 +19,6 @@ dest: "{{ node_config_directory }}/ovn-sb-db-relay-{{ item }}/config.json" mode: "0660" become: true - notify: - - Restart ovn-sb-db-relay container - name: Generate config files for OVN relay services vars: @@ -31,5 +29,3 @@ dest: "{{ node_config_directory }}/ovn-sb-db-relay-{{ item }}/ovsdb-relay.json" mode: "0660" become: true - notify: - - Restart ovn-sb-db-relay container diff --git a/releasenotes/notes/bug-2123946-notify-handlers-3d0a6a0788d5dcce.yaml b/releasenotes/notes/bug-2123946-notify-handlers-3d0a6a0788d5dcce.yaml new file mode 100644 index 0000000000..060471f697 --- /dev/null +++ b/releasenotes/notes/bug-2123946-notify-handlers-3d0a6a0788d5dcce.yaml @@ -0,0 +1,7 @@ +--- +fixes: + - | + Handlers to trigger a restart nova_libvirt and ovn_sb_db_relay + containers have been removed and restarts of these services + are now under the control of the service-check-containers + role `LP#2123946 `__.