Merge "Use the upgraded image to run Nova upgrade checks"

ansible/roles/nova/tasks/upgrade.yml

@@ -1,9 +1,24 @@
 ---
-- name: Check nova upgrade status
+- name: Run Nova upgrade checks
   become: true
-  command: "{{ kolla_container_engine }} exec -t nova_api nova-status upgrade check"
+  vars:
+    nova_api: "{{ nova_services['nova-api'] }}"
+  kolla_docker:
+    action: "start_container"
+    common_options: "{{ docker_common_options }}"
+    detach: False
+    environment:
+      KOLLA_UPGRADE_CHECK:
+      KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
+    image: "{{ nova_api.image }}"
+    labels:
+      UPGRADE:
+    name: "nova_upgrade_checks"
+    restart_policy: no
+    volumes: "{{ nova_api_default_volumes + nova_api_extra_volumes }}"
+  run_once: True
   register: nova_upgrade_check_stdout
-  when: inventory_hostname == groups['nova-api'][0]
+  delegate_to: "{{ groups['nova-api'][0] }}"
   failed_when: false
 
 - name: Upgrade status check result

releasenotes/notes/perform-nova-upgrade-checks-with-upgraded-image-dca9c515bcd89ec8.yaml

@@ -0,0 +1,10 @@
+---
+fixes:
+  - |
+    When upgrading Nova to a new release, we use the tool ``nova-status upgrade
+    check`` to make sure that there are no ``nova-compute`` that are older than
+    N-1 releases. This was performed using the current ``nova-api`` container,
+    so computes which will be too old after the upgrade were not caught. Now
+    the upgraded ``nova-api`` container image is used, so older computes are
+    identified correctly.
+    `LP#1957080 <https://launchpad.net/bugs/1957080>`__