openstack/kolla-ansible
Code Issues Proposed changes

Use 'image' not 'item'

Browse Source 
The things in self.images are images, not items so
reflect these to use the shared 'image' name vs
having a one-off that uses 'item'.

TrivalFix

Change-Id: I781514d3e116de32b4fe61a7f55455282680fec1
This commit is contained in:
Joshua Harlow 2016-06-08 17:50:39 -07:00
parent 479862932c
commit a45dc94e8c
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
kolla/image/build.py
View File

@ -809,15 +809,15 @@ class KollaWorker(object):
def list_children(images, ancestry):
children = ancestry.values()[0]
for item in images:
if item.status not in [STATUS_MATCHED]:
for image in images:
if image.status not in [STATUS_MATCHED]:
continue
if not item.children:
children.append(item.name)
if not image.children:
children.append(image.name)
else:
newparent = {item.name: []}
newparent = {image.name: []}
children.append(newparent)
list_children(item.children, newparent)
list_children(image.children, newparent)
ancestry = {base.name: []}
list_children(base.children, ancestry)