From abba627c1626284be33107f1d967440d571bbd29 Mon Sep 17 00:00:00 2001
From: Paul Bourke <paul.bourke@oracle.com>
Date: Fri, 24 Feb 2017 15:34:01 +0000
Subject: [PATCH] Update glance sanity check to use built in shade

The current module 'kolla_sanity' was written as a shim before full
shade support was added to Ansible. This should now no longer be needed,
we can implement the checks using Ansible provided modules.

Partially-implements: blueprint sanity-check-container
Depends-On: If6d10f2ce90c7fc72353566554352b0310942f30
Change-Id: Ie08c952178cdbea6e6a6e9e91cb62090ea98c2be
---
 ansible/roles/glance/tasks/check.yml | 35 +++++++++++++++-------------
 1 file changed, 19 insertions(+), 16 deletions(-)

diff --git a/ansible/roles/glance/tasks/check.yml b/ansible/roles/glance/tasks/check.yml
index 6dab34da6a..d6651b2ad5 100644
--- a/ansible/roles/glance/tasks/check.yml
+++ b/ansible/roles/glance/tasks/check.yml
@@ -1,19 +1,22 @@
 ---
-- name: Glance sanity checks
-  command: docker exec -t kolla_toolbox /usr/bin/ansible localhost
-    -m kolla_sanity
-    -a "service=glance
-        project=service
-        user=admin
-        password={{ glance_keystone_password }}
-        role=admin
-        region_name={{ openstack_region_name }}
-        auth={{ '{{ openstack_glance_auth }}' }}"
-    -e "{'openstack_glance_auth':{{ openstack_glance_auth }}}"
-  register: glance_sanity
-  changed_when: "{{ glance_sanity.stdout.find('localhost | SUCCESS => ') != -1 and (glance_sanity.stdout.split('localhost | SUCCESS => ')[1]|from_json).changed }}"
-  until: glance_sanity.stdout.split()[2] == 'SUCCESS'
-  retries: 10
-  delay: 5
+- name: Glance sanity check - create image
+  kolla_toolbox:
+    module_name: os_image
+    module_args:
+      auth: "{{ openstack_glance_auth }}"
+      name: "glance_sanity_check"
+      filename: "/etc/hostname"
+  delegate_to: "{{ groups['glance-api'][0] }}"
+  run_once: True
+  when: kolla_enable_sanity_glance | bool
+
+- name: Glance sanity check - cleanup
+  kolla_toolbox:
+    module_name: os_image
+    module_args:
+      auth: "{{ openstack_glance_auth }}"
+      name: "glance_sanity_check"
+      state: absent
+  delegate_to: "{{ groups['glance-api'][0] }}"
   run_once: True
   when: kolla_enable_sanity_glance | bool