From 463f10014eafc9151aabd4b63fac23c1b96b240b Mon Sep 17 00:00:00 2001
From: Marcin Juszkiewicz <marcin.juszkiewicz+kolla@linaro.org>
Date: Tue, 5 Apr 2022 15:31:21 +0200
Subject: [PATCH] drop binary install type from templates and config

As we have only source image type then we do not need to handle other
option.

Change-Id: I753aa0182cfc975bb8b5cd1476ab2c336a7691fa
---
 ansible/roles/aodh/templates/wsgi-aodh.conf.j2         |  2 +-
 .../roles/cloudkitty/templates/wsgi-cloudkitty.conf.j2 |  2 +-
 .../roles/freezer/templates/wsgi-freezer-api.conf.j2   |  2 +-
 ansible/roles/gnocchi/templates/wsgi-gnocchi.conf.j2   |  2 +-
 ansible/roles/heat/templates/wsgi-heat-api-cfn.conf.j2 |  2 +-
 ansible/roles/heat/templates/wsgi-heat-api.conf.j2     |  2 +-
 ansible/roles/horizon/templates/horizon.conf.j2        | 10 +---------
 ansible/roles/horizon/templates/local_settings.j2      |  3 ---
 ansible/roles/ironic/templates/ironic-api-wsgi.conf.j2 |  2 +-
 ansible/roles/keystone/templates/wsgi-keystone.conf.j2 |  2 +-
 ansible/roles/masakari/templates/wsgi-masakari.conf.j2 |  2 +-
 .../monasca/templates/monasca-api/wsgi-api.conf.j2     |  2 +-
 ansible/roles/nova/templates/nova-api-wsgi.conf.j2     |  2 +-
 ansible/roles/octavia/templates/octavia-wsgi.conf.j2   |  2 +-
 .../placement/templates/placement-api-wsgi.conf.j2     |  2 +-
 etc/kolla/globals.yml                                  |  2 +-
 16 files changed, 15 insertions(+), 26 deletions(-)

diff --git a/ansible/roles/aodh/templates/wsgi-aodh.conf.j2 b/ansible/roles/aodh/templates/wsgi-aodh.conf.j2
index 3099e35106..49aece190f 100644
--- a/ansible/roles/aodh/templates/wsgi-aodh.conf.j2
+++ b/ansible/roles/aodh/templates/wsgi-aodh.conf.j2
@@ -1,5 +1,5 @@
 {% set aodh_log_dir = '/var/log/kolla/aodh' %}
-{% set binary_path = '/usr/bin' if aodh_install_type == 'binary' else '/var/lib/kolla/venv/bin' %}
+{% set binary_path = '/var/lib/kolla/venv/bin' %}
 Listen {{ api_interface_address | put_address_in_context('url') }}:{{ aodh_api_listen_port }}
 
 ServerSignature Off
diff --git a/ansible/roles/cloudkitty/templates/wsgi-cloudkitty.conf.j2 b/ansible/roles/cloudkitty/templates/wsgi-cloudkitty.conf.j2
index 5da0b72aef..2ebbf8ca61 100644
--- a/ansible/roles/cloudkitty/templates/wsgi-cloudkitty.conf.j2
+++ b/ansible/roles/cloudkitty/templates/wsgi-cloudkitty.conf.j2
@@ -1,5 +1,5 @@
 {% set cloudkitty_log_dir = '/var/log/kolla/cloudkitty' %}
-{% set binary_path = '/usr/bin' if cloudkitty_install_type == 'binary' else '/var/lib/kolla/venv/bin' %}
+{% set binary_path = '/var/lib/kolla/venv/bin' %}
 Listen {{ api_interface_address | put_address_in_context('url') }}:{{ cloudkitty_api_port }}
 
 ServerSignature Off
diff --git a/ansible/roles/freezer/templates/wsgi-freezer-api.conf.j2 b/ansible/roles/freezer/templates/wsgi-freezer-api.conf.j2
index 7239bcb6e8..a4662d7d7e 100644
--- a/ansible/roles/freezer/templates/wsgi-freezer-api.conf.j2
+++ b/ansible/roles/freezer/templates/wsgi-freezer-api.conf.j2
@@ -1,5 +1,5 @@
 {% set freezer_log_dir = '/var/log/kolla/freezer' %}
-{% set python_path = '/usr/lib/python' ~ distro_python_version ~ '/site-packages' if freezer_install_type == 'binary' else '/var/lib/kolla/venv/lib/python' ~ distro_python_version ~ '/site-packages' %}
+{% set python_path = '/var/lib/kolla/venv/lib/python' ~ distro_python_version ~ '/site-packages' %}
 Listen {{ api_interface_address | put_address_in_context('url') }}:{{ freezer_api_port }}
 
 ServerSignature Off
diff --git a/ansible/roles/gnocchi/templates/wsgi-gnocchi.conf.j2 b/ansible/roles/gnocchi/templates/wsgi-gnocchi.conf.j2
index 12eb1748db..9c1021f47f 100644
--- a/ansible/roles/gnocchi/templates/wsgi-gnocchi.conf.j2
+++ b/ansible/roles/gnocchi/templates/wsgi-gnocchi.conf.j2
@@ -1,5 +1,5 @@
 {% set gnocchi_log_dir = '/var/log/kolla/gnocchi' %}
-{% set wsgi_path = '/usr/bin' if gnocchi_install_type == 'binary' else '/var/lib/kolla/venv/bin' %}
+{% set wsgi_path = '/var/lib/kolla/venv/bin' %}
 Listen {{ api_interface_address | put_address_in_context('url') }}:{{ gnocchi_api_listen_port }}
 
 ServerSignature Off
diff --git a/ansible/roles/heat/templates/wsgi-heat-api-cfn.conf.j2 b/ansible/roles/heat/templates/wsgi-heat-api-cfn.conf.j2
index ab4e1a1fb1..742d986347 100644
--- a/ansible/roles/heat/templates/wsgi-heat-api-cfn.conf.j2
+++ b/ansible/roles/heat/templates/wsgi-heat-api-cfn.conf.j2
@@ -1,5 +1,5 @@
 {% set heat_log_dir = '/var/log/kolla/heat' %}
-{% set binary_path = '/usr/bin' if heat_install_type == 'binary' else '/var/lib/kolla/venv/bin' %}
+{% set binary_path = '/var/lib/kolla/venv/bin' %}
 {% if heat_enable_tls_backend | bool %}
 {% if kolla_base_distro in ['centos']  %}
 LoadModule ssl_module /usr/lib64/httpd/modules/mod_ssl.so
diff --git a/ansible/roles/heat/templates/wsgi-heat-api.conf.j2 b/ansible/roles/heat/templates/wsgi-heat-api.conf.j2
index a164af2dbd..4874314db0 100644
--- a/ansible/roles/heat/templates/wsgi-heat-api.conf.j2
+++ b/ansible/roles/heat/templates/wsgi-heat-api.conf.j2
@@ -1,5 +1,5 @@
 {% set heat_log_dir = '/var/log/kolla/heat' %}
-{% set binary_path = '/usr/bin' if heat_install_type == 'binary' else '/var/lib/kolla/venv/bin' %}
+{% set binary_path = '/var/lib/kolla/venv/bin' %}
 {% if heat_enable_tls_backend | bool %}
 {% if kolla_base_distro in ['centos']  %}
 LoadModule ssl_module /usr/lib64/httpd/modules/mod_ssl.so
diff --git a/ansible/roles/horizon/templates/horizon.conf.j2 b/ansible/roles/horizon/templates/horizon.conf.j2
index e9671a2d07..c0e2edb531 100644
--- a/ansible/roles/horizon/templates/horizon.conf.j2
+++ b/ansible/roles/horizon/templates/horizon.conf.j2
@@ -1,4 +1,4 @@
-{% set python_path = '/usr/share/openstack-dashboard' if horizon_install_type == 'binary' else '/var/lib/kolla/venv/lib/python' + distro_python_version + '/site-packages' %}
+{% set python_path = '/var/lib/kolla/venv/lib/python' + distro_python_version + '/site-packages' %}
 
 {% if horizon_enable_tls_backend | bool %}
 {% if kolla_base_distro in ['centos']  %}
@@ -22,11 +22,7 @@ TraceEnable off
     WSGIScriptReloading On
     WSGIDaemonProcess horizon-http processes={{ horizon_wsgi_processes }} threads={{ horizon_wsgi_threads }} user=horizon group=horizon display-name=horizon
     WSGIProcessGroup horizon-http
-{% if kolla_base_distro in ['debian'] and horizon_install_type == 'binary' %}
-    WSGIScriptAlias / {{ python_path }}/wsgi.py
-{% else %}
     WSGIScriptAlias / {{ python_path }}/openstack_dashboard/wsgi.py
-{% endif %}
     WSGIPassAuthorization On
     WSGIApplicationGroup %{GLOBAL}
 
@@ -34,11 +30,7 @@ TraceEnable off
         Require all granted
     </Location>
 
-{% if kolla_base_distro in ['debian', 'ubuntu'] and horizon_install_type == 'binary' %}
-    Alias /static /var/lib/openstack-dashboard/static
-{% else %}
     Alias /static {{ python_path }}/static
-{% endif %}
     <Location "/static">
         SetHandler None
     </Location>
diff --git a/ansible/roles/horizon/templates/local_settings.j2 b/ansible/roles/horizon/templates/local_settings.j2
index c46dacc683..a0aaf8385a 100644
--- a/ansible/roles/horizon/templates/local_settings.j2
+++ b/ansible/roles/horizon/templates/local_settings.j2
@@ -864,9 +864,6 @@ KEY_MANAGER = {
         'project_domain_name': '{{ default_project_domain_name }}'
 }
 {% endif %}
-{% if kolla_base_distro in ['debian', 'ubuntu'] and horizon_install_type == 'binary' %}
-STATIC_ROOT = "/var/lib/openstack-dashboard/static/"
-{% endif %}
 
 # Allow operators to overwrite variables (LP: #1769970).
 from .custom_local_settings import *
diff --git a/ansible/roles/ironic/templates/ironic-api-wsgi.conf.j2 b/ansible/roles/ironic/templates/ironic-api-wsgi.conf.j2
index bc5c13c9f4..7b05325182 100644
--- a/ansible/roles/ironic/templates/ironic-api-wsgi.conf.j2
+++ b/ansible/roles/ironic/templates/ironic-api-wsgi.conf.j2
@@ -1,5 +1,5 @@
 {% set ironic_log_dir = '/var/log/kolla/ironic' %}
-{% set wsgi_directory = '/usr/bin' if ironic_install_type == 'binary' else '/var/lib/kolla/venv/bin' %}
+{% set wsgi_directory = '/var/lib/kolla/venv/bin' %}
 {% if ironic_enable_tls_backend | bool %}
 {% if kolla_base_distro in ['centos']  %}
 LoadModule ssl_module /usr/lib64/httpd/modules/mod_ssl.so
diff --git a/ansible/roles/keystone/templates/wsgi-keystone.conf.j2 b/ansible/roles/keystone/templates/wsgi-keystone.conf.j2
index 8408268e31..9a40f68533 100644
--- a/ansible/roles/keystone/templates/wsgi-keystone.conf.j2
+++ b/ansible/roles/keystone/templates/wsgi-keystone.conf.j2
@@ -1,5 +1,5 @@
 {% set keystone_log_dir = '/var/log/kolla/keystone' %}
-{% set binary_path = '/usr/bin' if keystone_install_type == 'binary' else '/var/lib/kolla/venv/bin' %}
+{% set binary_path = '/var/lib/kolla/venv/bin' %}
 {% if keystone_enable_tls_backend | bool %}
 {% if kolla_base_distro in ['centos']  %}
 LoadModule ssl_module /usr/lib64/httpd/modules/mod_ssl.so
diff --git a/ansible/roles/masakari/templates/wsgi-masakari.conf.j2 b/ansible/roles/masakari/templates/wsgi-masakari.conf.j2
index b0148177e4..bf015d66c6 100644
--- a/ansible/roles/masakari/templates/wsgi-masakari.conf.j2
+++ b/ansible/roles/masakari/templates/wsgi-masakari.conf.j2
@@ -1,5 +1,5 @@
 {% set masakari_log_dir = '/var/log/kolla/masakari' %}
-{% set binary_path = '/usr/bin' if masakari_install_type == 'binary' else '/var/lib/kolla/venv/bin' %}
+{% set binary_path = '/var/lib/kolla/venv/bin' %}
 
 Listen {{ api_interface_address | put_address_in_context('url') }}:{{ masakari_api_port }}
 
diff --git a/ansible/roles/monasca/templates/monasca-api/wsgi-api.conf.j2 b/ansible/roles/monasca/templates/monasca-api/wsgi-api.conf.j2
index 93e2e3ce36..848b39ab5b 100644
--- a/ansible/roles/monasca/templates/monasca-api/wsgi-api.conf.j2
+++ b/ansible/roles/monasca/templates/monasca-api/wsgi-api.conf.j2
@@ -1,5 +1,5 @@
 {% set monasca_log_dir = '/var/log/kolla/monasca' %}
-{% set wsgi_path = '/usr/bin' if monasca_install_type == 'binary' else '/monasca-api/monasca_api/api' %}
+{% set wsgi_path = '/monasca-api/monasca_api/api' %}
 
 Listen {{ api_interface_address | put_address_in_context('url') }}:{{ monasca_api_port }}
 
diff --git a/ansible/roles/nova/templates/nova-api-wsgi.conf.j2 b/ansible/roles/nova/templates/nova-api-wsgi.conf.j2
index 798547cde0..ad5d69a5d6 100644
--- a/ansible/roles/nova/templates/nova-api-wsgi.conf.j2
+++ b/ansible/roles/nova/templates/nova-api-wsgi.conf.j2
@@ -1,5 +1,5 @@
 {% set nova_log_dir = '/var/log/kolla/nova' %}
-{% set wsgi_directory = '/usr/bin' if nova_install_type == 'binary' else '/var/lib/kolla/venv/bin' %}
+{% set wsgi_directory = '/var/lib/kolla/venv/bin' %}
 {% if nova_enable_tls_backend | bool %}
 {% if kolla_base_distro in ['centos']  %}
 LoadModule ssl_module /usr/lib64/httpd/modules/mod_ssl.so
diff --git a/ansible/roles/octavia/templates/octavia-wsgi.conf.j2 b/ansible/roles/octavia/templates/octavia-wsgi.conf.j2
index c0c0bb40de..4cbb56fc99 100644
--- a/ansible/roles/octavia/templates/octavia-wsgi.conf.j2
+++ b/ansible/roles/octavia/templates/octavia-wsgi.conf.j2
@@ -1,4 +1,4 @@
-{% set wsgi_directory = '/usr/bin' if octavia_install_type == 'binary' else '/var/lib/kolla/venv/bin' %}
+{% set wsgi_directory = '/var/lib/kolla/venv/bin' %}
 {% if octavia_enable_tls_backend | bool %}
 {% if kolla_base_distro in ['centos']  %}
 LoadModule ssl_module /usr/lib64/httpd/modules/mod_ssl.so
diff --git a/ansible/roles/placement/templates/placement-api-wsgi.conf.j2 b/ansible/roles/placement/templates/placement-api-wsgi.conf.j2
index 2d99f8d12d..8fe8be01e2 100644
--- a/ansible/roles/placement/templates/placement-api-wsgi.conf.j2
+++ b/ansible/roles/placement/templates/placement-api-wsgi.conf.j2
@@ -1,5 +1,5 @@
 {% set log_dir = '/var/log/kolla/placement' %}
-{% set wsgi_directory = '/usr/bin' if placement_install_type == 'binary' else '/var/lib/kolla/venv/bin' %}
+{% set wsgi_directory = '/var/lib/kolla/venv/bin' %}
 {% if placement_enable_tls_backend | bool %}
 {% if kolla_base_distro in ['centos']  %}
 LoadModule ssl_module /usr/lib64/httpd/modules/mod_ssl.so
diff --git a/etc/kolla/globals.yml b/etc/kolla/globals.yml
index dd66c24530..46fb9da888 100644
--- a/etc/kolla/globals.yml
+++ b/etc/kolla/globals.yml
@@ -30,7 +30,7 @@
 # Valid options are ['centos', 'debian', 'rhel', 'ubuntu']
 #kolla_base_distro: "centos"
 
-# Valid options are [ binary, source ]
+# Valid options are [ source ]
 #kolla_install_type: "source"
 
 # Do not override this unless you know what you are doing.