openstack/kolla-ansible
Code Issues Proposed changes

Merge "external/internal vip: use proper ip comparison"

Browse Source
This commit is contained in:
Zuul 2024-08-22 14:26:53 +00:00 committed by Gerrit Code Review
commit dd4aa966a6
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible/group_vars/all.yml
View File

@ -56,7 +56,7 @@ kolla_base_distro: "rocky"
kolla_internal_vip_address: "{{ kolla_internal_address | default('') }}"
kolla_internal_fqdn: "{{ kolla_internal_vip_address }}"
kolla_external_vip_address: "{{ kolla_internal_vip_address }}"
kolla_same_external_internal_vip: "{{ kolla_external_vip_address == kolla_internal_vip_address }}"
kolla_same_external_internal_vip: "{{ kolla_external_vip_address | ansible.utils.ipaddr('address') == kolla_internal_vip_address | ansible.utils.ipaddr('address') }}"
kolla_external_fqdn: "{{ kolla_internal_fqdn if kolla_same_external_internal_vip | bool else kolla_external_vip_address }}"
kolla_dev_repos_directory: "/opt/stack/"

7
releasenotes/notes/use_proper_ip_comparison-1ed77a21eb560079.yaml Normal file
View File

@ -0,0 +1,7 @@
---
fixes:
- |
Fixes a bug where the IP address comparison was not done properly
for the variable ``kolla_same_external_internal_vip``.
Fix the comparison to use the ``ipaddr`` filter instead.
For details see `LP#2076889 <https://bugs.launchpad.net/kolla/+bug/2076889>`__.