Verify YAML syntax in gates

This patchset implements yamllint test to all *.yml
files.

Also fixes syntax errors to make jobs to pass.

Change-Id: I3186adf9835b4d0cada272d156b17d1bc9c2b799

.yamllint

@@ -0,0 +1,15 @@
+extends: default
+ignore: |
+  .tox/
+
+rules:
+  line-length: disable
+  truthy: disable
+  braces:
+    max-spaces-inside: 1
+  comments:
+    # Ignore first space in comment because we set default options as:
+    #openstack_version: "pike"
+    require-starting-space: true
+    ignore: |
+      etc/kolla/globals.yml

.zuul.yaml

@@ -1,3 +1,4 @@
+---
 - project:
     check:
       jobs:

ansible/kolla-host.yml

@@ -37,4 +37,3 @@
   roles:
     - { role: baremetal,
         tags: baremetal }
-

ansible/roles/chrony/tasks/config.yml

@@ -49,4 +49,3 @@
   with_dict: "{{ chrony_services }}"
   notify:
     - Restart chrony container
-

ansible/roles/common/defaults/main.yml

@@ -28,7 +28,7 @@ common_services:
       - "/dev/:/dev/"
       - "/run/:/run/:shared"
       - "kolla_logs:/var/log/kolla/"
-# DUMMY_ENVIRONMENT is needed because empty environment is not supported
+  # DUMMY_ENVIRONMENT is needed because empty environment is not supported
   cron:
     container_name: cron
     enabled: True

ansible/roles/glance/handlers/main.yml

@@ -45,4 +45,3 @@
       or glance_conf.changed | bool
       or policy_overwriting.changed | bool
       or glance_registry_container.changed | bool
-

ansible/roles/glance/tasks/config.yml

@@ -125,4 +125,3 @@
   notify:
     - Restart glance-api container
     - Restart glance-registry container
-

ansible/roles/haproxy/tasks/config.yml

@@ -109,4 +109,3 @@
   with_dict: "{{ haproxy_services }}"
   notify:
     - "Restart {{ item.key }} container"
-

ansible/roles/horizon/tasks/config.yml

@@ -131,4 +131,3 @@
     - horizon.enabled | bool
   notify:
     - Restart horizon container
-

ansible/roles/memcached/tasks/config.yml

@@ -37,4 +37,3 @@
     - service.enabled | bool
     - action != "config"
   notify: Restart memcached container
-

ansible/roles/neutron/tasks/config-neutron-fake.yml

@@ -86,4 +86,3 @@
     group: "{{ config_owner_group }}"
   when: inventory_hostname in groups['compute']
   with_sequence: start=1 end={{ num_nova_fake_per_node }}
-

ansible/roles/neutron/tasks/config.yml

@@ -436,4 +436,3 @@
   with_dict: "{{ neutron_services }}"
   notify:
     - "Restart {{ item.key }} container"
-

ansible/roles/nova/tasks/bootstrap_xenapi.yml

@@ -1,3 +1,4 @@
+---
 - name: Install package python-os-xenapi
   package:
     name: python-os-xenapi

ansible/roles/nova/tasks/config.yml

@@ -203,4 +203,3 @@
   with_dict: "{{ nova_services }}"
   notify:
     - "Restart {{ item.key }} container"
-

ansible/roles/openvswitch/tasks/config.yml

@@ -70,4 +70,3 @@
   with_dict: "{{ openvswitch_services }}"
   notify:
     - "Restart {{ item.key }} container"
-

ansible/roles/ovs-dpdk/defaults/main.yml

@@ -50,7 +50,7 @@ ovsdpdk_services:
 ####################
 ovs_bridge_mappings: "{% for bridge in neutron_bridge_name.split(',') %}physnet{{ loop.index0 + 1 }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}"
 ovs_port_mappings: "{% for bridge in neutron_bridge_name.split(',') %} {{ neutron_external_interface.split(',')[loop.index0] }}:{{ bridge }}{% if not loop.last %},{% endif %}{% endfor %}"
-dpdk_tunnel_interface : "{{neutron_external_interface}}"
+dpdk_tunnel_interface: "{{neutron_external_interface}}"
 dpdk_tunnel_interface_address: "{{ hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['address'] }}"
 tunnel_interface_network: "{{ hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['network']}}/{{hostvars[inventory_hostname]['ansible_' + dpdk_tunnel_interface]['ipv4']['netmask']}}"
 tunnel_interface_cidr: "{{dpdk_tunnel_interface_address}}/{{ tunnel_interface_network | ipaddr('prefix') }}"

ansible/roles/ovs-dpdk/tasks/pull.yml

@@ -8,4 +8,3 @@
     - item.value.enabled | bool
     - item.value.host_in_groups | bool
   with_dict: "{{ ovsdpdk_services }}"
-

ansible/roles/prechecks/tasks/user_checks.yml

@@ -10,10 +10,8 @@
     key: "{{ config_owner_group }}"
   register: getent_group
 
-#(duonghq) it's only a basic check, should be refined later
+# NOTE(duonghq): it's only a basic check, should be refined later
 - name: Check if ansible user can do passwordless sudo
   shell: sudo -n true
   register: result
   failed_when: result | failed
-
-

ansible/roles/skydive/defaults/main.yml

@@ -34,4 +34,3 @@ skydive_analyzer_image_full: "{{ skydive_analyzer_image }}:{{ skydive_analyzer_t
 skydive_agent_image: "{{ docker_registry ~ '/' if docker_registry else '' }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-skydive-agent"
 skydive_agent_tag: "{{ openstack_release }}"
 skydive_agent_image_full: "{{ skydive_agent_image }}:{{ skydive_agent_tag }}"
-

ansible/roles/skydive/handlers/main.yml

@@ -41,4 +41,3 @@
     - config_json.changed | bool
       or skydive_conf.changed |bool
       or skydive_agent_container.changed | bool
-

ansible/roles/skydive/tasks/precheck.yml

@@ -31,4 +31,3 @@
     - container_facts['skydive_agent'] is not defined
     - inventory_hostname in groups[skydive_agent.group]
     - skydive_agent.enabled | bool
-

ansible/roles/stop/tasks/stop_containers.yml

@@ -1,4 +1,3 @@
 ---
 - name: Stopping Kolla containers
   command: /tmp/kolla-stop/tools/stop-containers
-

ansible/roles/vitrage/defaults/main.yml

@@ -121,8 +121,8 @@ vitrage_datasource:
     enabled: "{{ enable_cinder | bool }}"
   - name: "neutron.network,neutron.port"
     enabled: "{{ enable_neutron | bool }}"
-#TODO(egonzalez) Heat cannot be used with default policy.json due stacks:global_index=rule:deny_everybody.
+  # TODO(egonzalez) Heat cannot be used with default policy.json due stacks:global_index=rule:deny_everybody.
-# Document process to deploy vitrage+heat.
+  # Document process to deploy vitrage+heat.
   - name: "heat.stack"
     enabled: "no"
 

etc/kolla/passwords.yml

@@ -179,7 +179,7 @@ vitrage_keystone_password:
 
 memcache_secret_key:
 
-#HMAC secret key
+# HMAC secret key
 osprofiler_secret:
 
 nova_ssh_key:

releasenotes/notes/add-congress-877644b4b0e2ed0a.yaml

@@ -1,5 +1,5 @@
 ---
 features:
-- Add ansible role for openstack congress project which provide
+  - Add ansible role for openstack congress project which provide
     policy as a service across any collection of cloud services in
     order to offer governance and compliance for dynamic infrastructures.

releasenotes/notes/add-watcher-a97995ace827cf71.yaml

@@ -1,5 +1,5 @@
 ---
- features:
+features:
   - Introduce OpenStack Infrastructure Optimization
     service, also known as Watcher.  This project makes
     use of Ceilometer data to rebalance the cloud to

releasenotes/notes/congress-broken-cbf8ca59d90a85cb.yaml

@@ -1,4 +1,4 @@
 ---
 other:
   - Congress doesn't work correctly out of the box and will
-    not deploy.  See Bug #1634641.
+    not deploy. See Bug https://bugs.launchpad.net/kolla-ansible/+bug/1634641.

releasenotes/notes/deprecate-some-config-files-0ed8c75f6bb4aa26.yaml

@@ -6,4 +6,3 @@ deprecations:
 
     * /etc/kolla/config/database.conf
     * /etc/kolla/config/messaging.conf
-

releasenotes/notes/remove-nova-network-76e1c9b51a4acd5f.yaml

@@ -2,4 +2,3 @@
 deprecations:
   - The nova-network was deprecated, we remove it from the nova ansible
     role.
-

tests/pre.yml

@@ -1,3 +1,4 @@
+---
 - hosts: all
   vars:
     logs_dir: "/tmp/logs"

tox.ini

@@ -30,11 +30,15 @@ setenv = VIRTUAL_ENV={envdir}
 commands = python setup.py testr --coverage --testr-args='{posargs}'
 
 [testenv:pep8]
+deps =
+    {[testenv]deps}
+    yamllint
 commands =
   {toxinidir}/tools/run-bashate.sh
   flake8 {posargs}
   python {toxinidir}/tools/validate-all-file.py
   bandit -r ansible kolla_ansible tests tools
+  yamllint .
 
 [testenv:bandit]
 commands = bandit -r ansible kolla_ansible tests tools