openstack/kolla-ansible
Code Issues Proposed changes

Nova oslo_messaging_notifications config error

Browse Source 
With the following configuration in globals.yml
enable_ceilometer="no"
enable_designate="no"
enable_searchlight="yes"

nova.conf is generated like following:

[oslo_messaging_notifications]
driver = messagingv2
topics =

topics value is missing.

Change-Id: I27145c0da8b864b2614091933c33d83bdec8b9be
Closes-Bug: #1671935
Co-Authored-By: Jeffrey Zhang <jeffrey.zhang@99cloud.net>
This commit is contained in:
Bertrand Lallau 2017-03-10 22:23:58 +01:00
parent 62972a6c8e
commit f45e18144d
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ansible/roles/nova/defaults/main.yml
View File

@ -236,3 +236,14 @@ openstack_placement_auth: "{{ openstack_auth }}"
nova_ssh_port: "8022" nova_ssh_port: "8022"
####################
# Notification
####################
nova_notification_topics:
- name: notifications
enabled: "{{ enable_ceilometer | bool or enable_searchlight | bool }}"
- name: notifications_designate
enabled: "{{ enable_designate | bool }}"
nova_enabled_notification_topics: "{{ nova_notification_topics | selectattr('enabled', 'equalto', true) | list }}"

5
ansible/roles/nova/templates/nova.conf.j2
View File

@ -201,10 +201,9 @@ rbd_secret_uuid = {{ rbd_secret_uuid }}
compute = auto compute = auto
[oslo_messaging_notifications] [oslo_messaging_notifications]
{% if enable_ceilometer | bool or enable_searchlight | bool or enable_designate | bool %} {% if nova_enabled_notification_topics %}
driver = messagingv2 driver = messagingv2
{% set topics=["notifications" if enable_ceilometer | bool else "", "notifications_designate" if enable_designate | bool else ""] %} topics = {{ nova_enabled_notification_topics | map(attribute='name') | join(',') }}
topics = {{ topics|reject("equalto", "")|list|join(",") }}
{% else %} {% else %}
driver = noop driver = noop
{% endif %} {% endif %}