6506 Commits

Author SHA1 Message Date
Zuul
0761285f90 Merge "Adding container engine to kolla_container_facts" 2022-11-03 21:26:04 +00:00
Ivan Halomi
7a9f04573a Adding container engine to kolla_container_facts
Second part of patchset:
https://review.opendev.org/c/openstack/kolla-ansible/+/799229/
in which was suggested to split patch into smaller ones.

This change adds container_engine variable to kolla_container_facts
module, this prepares module to be used with docker and podman as well
without further changes in roles.

Signed-off-by: Ivan Halomi <i.halomi@partner.samsung.com>
Co-authored-by: Martin Hiner <m.hiner@partner.samsung.com>
Change-Id: I9e8fa30646844ab4a288555f3aafdda345b3a118
2022-11-02 13:44:45 +01:00
Zuul
4fa36cbe08 Merge "Fix ironic interface option for ironic-inspector" 2022-11-02 08:04:43 +00:00
Michal Arbet
6c9d1f9b55 Fix missing logrotate configuration for proxysql logs
This trivial patch is just adding missed logrotate
configuration for proxysql.

Closes-Bug: #1995248
Change-Id: I3ad88d03836930160b6db43a7cad63b34ffc62b0
2022-10-31 11:26:43 +01:00
Mark Goddard
fa96fd1a2f Fix ironic interface option for ironic-inspector
The correct option to use is valid_interfaces [1], not os_endpoint_type.
The os_endpoint_type option was removed in Train.

[1] https://docs.openstack.org/ironic-inspector/wallaby/configuration/sample-config.html

Change-Id: I3906d7b9a2bebfe5c323cba5f80add3e932468c8
Closes-Bug: #1995246
Related-Bug: #1990675
2022-10-31 09:45:38 +00:00
Zuul
c3dde9933e Merge "Mount /run directory into zun_cni_daemon container" 2022-10-28 12:03:36 +00:00
Zuul
beb15b62e2 Merge "Usage of kolla_container_engine variable instead of docker" 2022-10-28 10:00:44 +00:00
Ivan Halomi
910f9bd36f Usage of kolla_container_engine variable instead of docker
First part of patchset:
 https://review.opendev.org/c/openstack/kolla-ansible/+/799229/
in which was suggested to split patch into smaller ones.

This implements kolla_container_engine variable
in command calls of docker,so later on it can be
also used for podman without further change.

Signed-off-by: Ivan Halomi <i.halomi@partner.samsung.com>
Change-Id: Ic30b67daa2e215524096ad1f4385c569e3d41b95
2022-10-28 09:15:55 +02:00
Zuul
5baec2f43e Merge "[ironic] Drop an extra wait" 2022-10-27 15:59:47 +00:00
Zuul
bede68572a Merge "Support specifying Nova compute provider config" 2022-10-27 13:31:45 +00:00
Zuul
065d61f329 Merge "Adds ability to configure ProxySQL's max replication lag" 2022-10-20 14:40:51 +00:00
Zuul
e35eb12b9e Merge "Update RHEL family information" 2022-10-20 11:02:23 +00:00
Michal Arbet
bee253e337 Adds ability to configure ProxySQL's max replication lag
By default ProxySQL's default value of max_replication_lag
is 0 which is in fact disabling this feature [1].
If it is greater than 0, ProxySQL will regularly monitor
replication lag and if it goes beyond the configured threshold
it will temporary shun the host until replication catches up.

This should be configurable via kolla-ansible as every
openstack deployment can be different in terms of network
delays, database load etc.. , so user should have option
to configure when database backend will be shunned.

[1] https://proxysql.com/documentation/main-runtime/

Change-Id: I66171638abc712cb84b380042f1d29f54c499e73
2022-10-20 11:41:34 +02:00
wuchunyang
ccbdfaea5c Mount /run directory into zun_cni_daemon container
During zun_cni_daemon binds the port to container netns,
zun_cni_damon creates a new net namepsaces(cni-xxx),
Currently, the namespace is only present inside the
zun_cni_daemon container, if this container restart or
rerun, all zun capsules will lost network capability.

Closes-Bug: #1993551

Change-Id: I3642bbf1ad8e8f4744b215fb8deff25fd4ceae75
2022-10-19 22:56:29 +08:00
Maksim Malchuk
9d5924cbc4 Fix freezer deployment
Following up on [1] and fix freezer deployment accidentally broken
after removing 'domain_name' from the 'openstack_auth'.

1. Ib631e2211682862296cce9ea179f2661c90fa585

Change-Id: Ie928f8a4506f41407d76edcb6b52ca7cddb52214
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2022-10-18 16:13:36 +03:00
Marcin Juszkiewicz
33d37575f9 Update RHEL family information
Some time ago we dropped RHEL as one of possible options. During 'Zed'
cycle we added Rocky Linux 9 as alternative to CentOS Stream 9.

This change updates some mentions of both.

Change-Id: I9ed93efcb7d1ff97b1c7d8342db8252aba2a9887
2022-10-18 14:42:39 +02:00
Michal Nasiadka
b6c68e2bb4 Skip ansible-lint fqcn for module actions and role-name
Add noqa for:
Object of type PosixPath is not JSON serializable

Change-Id: Id6ef88bb8cd16120bf31da679d1129d99f4b9fd8
2022-10-12 10:02:52 +02:00
Zuul
2d56e829ac Merge "Make Keystone admin endpoint creation optional" 2022-10-10 12:28:16 +00:00
Zuul
2e2cd75979 Merge "Stop showing image locations" 2022-10-10 08:39:34 +00:00
Zuul
b83cba838a Merge "Fix image from volume upload ERRORs and WARNINGs with Ceph RBD" 2022-10-10 08:35:27 +00:00
Zuul
c1f31c909d Merge "Make Cinder with iSCSI use fewer volumes" 2022-10-07 17:00:04 +00:00
Radosław Piliszek
a4b4043308 Fix image from volume upload ERRORs and WARNINGs with Ceph RBD
By resetting image_upload_use_cinder_backend to upstream default.

When uploading volume to glance image, cinder looks at the backend's
image_upload_use_cinder_backend config knob to decide whether to try link
the glance image to a cloned volume made by cinder, i.e. by doing all work
locally and only updating glance's locations for the image (when the knob
is set to True). However, after all [1], [2] and [3], which happens since
Victoria, this option requires further config from user (using volume type
with image_service:store_id property (aka extra spec) set to the desired
glance store (even if there is only one cinder store configured).

Please read the bug report as to why the option removal is the
best option (TL;DR it is the most compatible approach).

[1] https://review.opendev.org/c/openstack/kolla-ansible/+/708114
[2] https://review.opendev.org/c/openstack/glance_store/+/746556
[3] https://review.opendev.org/c/openstack/cinder/+/661676

Closes-Bug: #1991516
Change-Id: Ife87ee0241d907a0c407eb21811a354ed1734408
2022-10-07 15:05:12 +00:00
Radosław Piliszek
febd99eb69 Make Cinder with iSCSI use fewer volumes
These are not used by the relevant daemons and so can be dropped to,
e.g., avoid creating the cinder volume on hosts where there is no
cinder.

Change-Id: Ia8d906a9e0227f361883a7ec1ec8dcd73e4104dc
2022-10-07 14:20:45 +00:00
Radosław Piliszek
da292982b1 Stop showing image locations
This is generally considered insecure because it may reveal
sensitive data [1].
Furthermore, it happens that the default Ceph perms cause fatal
ERRORs with this setting:
1) when Glance wants to remove an image, it cannot list children
because Cinder or Nova might have created a linked volume clone
behind the scenes and it is put in another pool (volumes/vms)
which Glance cannot normally access;
2) when Nova wants to create an image, it lacks permissions
to write to the images pool.

Thus, I propose that Kolla Ansible stops setting this by default
and relies on the working defaults.
The downside is that this disables optimisations in Cinder and Nova.
On the other hand, these optimisations have nasty behaviour of
being linked directly to the original image, preventing its removal.

[1] https://docs.openstack.org/glance/yoga/configuration/glance_api.html#DEFAULT.show_multiple_locations

Change-Id: I63ee9a6eefd8593f2169bba34dbb699f413d7cf8
Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/860093
Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/860291
Closes-Bug: #1992153
2022-10-07 14:20:08 +00:00
Radosław Piliszek
39269a4f64 [heat] Remove an ancient deprecated task
Change-Id: Ic267b0bc1153940f7595a1cf93ff2c62dd084d4e
2022-10-07 14:19:47 +00:00
Doug Szumski
522c3291cd Support specifying Nova compute provider config
In the Victoria cycle, Nova merged improved support for
managing resource providers:
https://review.opendev.org/q/topic:bp%252Fprovider-config-file

See the blueprint for more details:
https://docs.openstack.org/nova/latest/admin/managing-resource-providers.html

This change allows us to copy the necessary configuration.

Change-Id: I0a3caaad73bc6fe27380e7f6bf6b792aca51c84c
2022-10-07 12:58:38 +00:00
Zuul
17aeda1fcf Merge "Bump Ansible min version to 2.12/5 and max to 2.13/6" 2022-10-05 18:04:38 +00:00
Zuul
5b848d01f0 Merge "[glance][cinder] Stop owning RBD defaults" 2022-10-04 15:53:27 +00:00
Zuul
c2cbf061b6 Merge "Remove the deprecated enable_ironic_ipxe" 2022-10-04 14:21:23 +00:00
Zuul
2d37ce15e7 Merge "set haproxy balance algorithm to roundrobin for horizon" 2022-10-04 14:21:20 +00:00
Zuul
1cddf8050d Merge "Keystone OIDC JWKS fix" 2022-10-04 14:21:17 +00:00
Michal Nasiadka
98a691a7c9 Bump Ansible min version to 2.12/5 and max to 2.13/6
Change-Id: Ie09bf108250a71d539002dd5ccfa63dd71bcfe90
2022-10-04 11:45:28 +00:00
Zuul
0052deac23 Merge "Remove dhcp-sequential-ip in ironic dnsmasq config" 2022-10-04 10:54:21 +00:00
Zuul
447ee7b269 Merge "Fix interface option for ironic-neutron-agent" 2022-10-04 10:40:02 +00:00
Serhat Rıfat Demircan
155ed969ae set haproxy balance algorithm to roundrobin for horizon
Currently kolla-ansible sets haproxy balance algorithm to source for
horizon. We can set it to round-robin if the cache backend is memcached
or using the database as the session storage backend. So we can
distribute http requests evenly to all available horizon instances.

Closes-Bug: #1990523
Change-Id: I0721cadcf53d59947bc0db6a193bfafe49c41ad3
2022-10-03 22:42:41 +03:00
Radosław Piliszek
52ec5ef390 [glance][cinder] Stop owning RBD defaults
These are upstream defaults, no need to carry them around.

TrivialFix

Change-Id: I2907d5f38c6a74776961bd473553edf2d83f7257
2022-10-03 16:53:35 +02:00
Jakub Darmach
9892976119
Keystone OIDC JWKS fix
JWT failed to validate on auth-oidc endpoint used by openstack cli
with "could not find key with kid: XX" error. To fix this we need
to use jwks provided in "jwks_uri" by OIDC metadata endpoint.

Missing "ServerName" directive from vhost config causes redirection
to fail in some cases when external tls is enabled.

  - added "keystone_federation_oidc_jwks_uri" variable
  - added "OIDCOAuthVerifyJwksUri" to keystone vhost config
  - added "ServerName" to keystone vhost config
  - jinja templating additional whitespace trimmed to
    correct end result indentation and empty newlines

Closes-bug: 1990375
Change-Id: I4f5c1bd8be8e23cf6299ca4bdfd79e9d98c9a9eb
2022-10-03 12:36:11 +02:00
Pierre Riteau
9ce47b2fff Remove dhcp-sequential-ip in ironic dnsmasq config
With this option enabled, dnsmasq can offer the same IP address to
multiple hosts when their requests are close to each other. Remove this
option in order to use the built-in hashing mechanism which will
allocate random IP addresses, which should be less likely to conflict.

Closes-Bug: #1991390
Change-Id: I09a9fa2d0c54635b899ad7906cc2e2e4580ef5ad
2022-09-30 13:26:23 +02:00
Radosław Piliszek
8d646af3b5 [ironic] Drop an extra wait
By the comment message, it should no longer be necessary to wait
at this stage and we can speed up the process a little bit.

Change-Id: Ia96bfa79aaad5fbd54a9f527702cca7a63616bf7
2022-09-29 16:31:31 +02:00
Michal Nasiadka
4a40418e48 bifrost: Use the combined Ironic service instead of API+conductor
Fix bifrost stop.yml after I9faecfe6ece6d3c35396e3378c1e3930a487e130

Change-Id: I850cbbb83d10b1518cc73612a591b160c2d49f1c
2022-09-29 12:11:13 +02:00
Radosław Piliszek
3029281c1d Remove the deprecated enable_ironic_ipxe
Change-Id: Ia8acdf69cb3676ec939777c32f0568cb720c471f
2022-09-29 10:39:19 +02:00
Michal Nasiadka
9d5f9080da CI: rocky9 - add to multiple if base_distro statements
Change-Id: Ib068117237a199db380fcdfb757d5d0e5d34326b
2022-09-28 15:59:05 +02:00
Zuul
6bff120d2d Merge "Introduce variables for cinder backend names" 2022-09-27 17:13:40 +00:00
Zuul
652bbe30c8 Merge "Fix Ironic API healthcheck with backend TLS" 2022-09-27 16:15:55 +00:00
Zuul
80c059a2a1 Merge "Do not enable nova_legacy service by default" 2022-09-27 16:09:02 +00:00
Radosław Piliszek
4277c1a1a4 Do not enable nova_legacy service by default
Change-Id: Ic89097fdc72d4fa11754201ed6e388bf79ca40b6
2022-09-27 08:37:05 +00:00
Michal Arbet
02ce483852 Specify number of threads for designate bind9 backend
Bind9 is running without limit for UDP listeners.
This patch is changing this behaviour and sets max 32
of UDP listeners. This is needed because of bug below [1].

[1] https://bugs.launchpad.net/ubuntu/+source/bind9/+bug/1827923

Change-Id: Ie4c2ac4d5e990ebdc30c3a94d855703d814f1fee
2022-09-26 20:18:25 +02:00
Radosław Piliszek
ee32736c15 Make Keystone admin endpoint creation optional
The admin endpoint is kept on upgrade to allow the upgrade to
happen (as it allows to rewrite the previous admin endpoint entry
to the new one).

Change-Id: I1c16892bab67f281d539843f1f0fa658df1c4874
Depends-On: https://review.opendev.org/c/openstack/kolla/+/854837
2022-09-26 18:17:39 +00:00
Radosław Piliszek
6a7e6a25bc Remove deprecated sysctl knobs
Kolla Ansible stopped setting them as they turned out to be
unnecessary for its operations, yet may have conflicted with
security policies of the hosts. [1] [2]

[1] https://launchpad.net/bugs/1837551
[2] https://launchpad.net/bugs/1945453

Change-Id: Ie8ccd3ab6f22a6f548b1da8d3acd334068dc48f5
2022-09-26 11:54:08 +00:00
Pierre Riteau
39eafd068b Fix interface option for ironic-neutron-agent
The correct option to use is valid_interfaces [1], not os_endpoint_type.

[1] https://docs.openstack.org/networking-baremetal/latest/configuration/ironic-neutron-agent/config.html#ironic

Closes-Bug: #1990675
Change-Id: I35e7d3072c6340f4ecbe02f8961158bcb663954e
2022-09-26 10:52:38 +02:00