12419 Commits

Author SHA1 Message Date
Maksim Malchuk
5c19f9a5e0 Add forgotten 'Restart container' handler for swift
Since I0474324b60a5f792ef5210ab336639edf7a8cd9e swift role uses the new
service-cert-copy role introduced in the
I6351147ddaff8b2ae629179a9bc3bae2ebac9519 but the swift role itself
doesn't contain the handler used in the service-cert-copy. Right now,
restarting the swift container isn't necessary, but the handler should
exist. Also we should fix the name of the service used.

Closes-Bug: #1931097
Change-Id: I2d0615ce6914e1f875a2647c8a95b86dd17eeb22
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2021-06-08 02:48:40 +03:00
John Garbutt
70f6f8e4c0 Reduce RabbitMQ busy waiting, lowering CPU load
On machines with many cores, we were seeing excessive CPU load on systems
that were not very busy. With the following Erlang VM argument we saw
RabbitMQ CPU usage drop from about 150% to around 20%, on a system with
40 hyperthreads.

    +S 2:2

By default RabbitMQ starts N schedulers where N is the number of CPU
cores, including hyper-threaded cores. This is fine when you assume all
your CPUs are dedicated to RabbitMQ. Its not a good idea in a typical
Kolla Ansible setup. Here we go for two scheduler threads.
More details can be found here:
https://www.rabbitmq.com/runtime.html#scheduling
and here:
https://erlang.org/doc/man/erl.html#emulator-flags

    +sbwt none

This stops busy waiting of the scheduler, for more details see:
https://www.rabbitmq.com/runtime.html#busy-waiting
Newer versions of rabbit may need additional flags:
"+sbwt none +sbwtdcpu none +sbwtdio none"
But this patch should be back portable to older versions of RabbitMQ
used in Train and Stein.

Note that information on this tuning was found by looking at data from:
rabbitmq-diagnostics runtime_thread_stats
More details on that can be found here:
https://www.rabbitmq.com/runtime.html#thread-stats

Related-Bug: #1846467

Change-Id: Iced014acee7e590c10848e73feca166f48b622dc
2021-06-07 13:18:39 +01:00
Zuul
dda787fca9 Merge "Bump min Docker version" 2021-06-07 09:00:26 +00:00
Zuul
3337e9873a Merge "chrony: allow to remove the container" 2021-06-07 08:55:19 +00:00
John Garbutt
e7ff199dcf Robustify fluentd output tag matching
We really want elasticsearch or monasca to catch all logs,
to providd the required centrailsed logging.

While these appears to make little material difference,
it should make it harder for logs to not get caught by
any of the outputs we have configured.

TrivialFix

Change-Id: I3bb74dcdc3cbe78cd1e1657f44e2a0af9d6508ef
2021-06-07 09:16:03 +01:00
Scott Shambarger
aea9bf3550 monasca-thresh: Fix topology submission to storm
monasca-thresh currently runs a local copy of the storm
to handle the threshold topology.  However, it doesn't setup
the environment correctly, and the executable fails, causing
the container to continually restart.

This patch updates the container command to correctly
submit the topology to the running Apache storm.  The
container will exit after it finishes the submission,
so the restart_policy is updated to on-failure, this way
if the storm is temporarily unavailable, the submission
will be retried. (NOTE: further deploys will see the
container as "changed" as it won't be running)

Patch uses KOLLA_BOOTSTRAP to trigger the container to
check if the topology is already submitted, and if so skips
the submission command so the container doesn't fail.

The config task now triggers a new reconfigure handler that
spawns a one-shot container to replace any existing topology
if the configuration has changed.

Also, all the storm.* variables in storm.yml.j2 are
removed as they were only needed for local mode and
make submitted topologies fail to load when the storm
is restarted (the referenced directories not mounted
on nimbus).

Depends-On: https://review.opendev.org/c/openstack/kolla/+/792751
Closes-Bug: #1808805
Change-Id: Ib225d76076782d695c9387e1c2693bae9a4521d7
2021-06-06 13:41:29 -07:00
Zuul
fad696be8d Merge "Fix release note markup" 2021-06-05 09:32:16 +00:00
likui
cccf4f7771 [TrivialFix] Remove extra slash
Change-Id: Ic45f618204875684f52133ec0f69fe7512ec9e2c
2021-06-05 07:14:27 +00:00
Mark Goddard
46bd05250d baremetal: fix /etc/hosts generation when api_interface has dashes
Interface names with dashes can cause problems in Ansible since dashes
are replaced with underscores when referencing facts. In the baremetal
role we reference the fact for api_interface without replacing dashes
with underscores. This may result in host entries being omitted from
/etc/hosts.

This change fixes the issue.

Change-Id: I667adc7d8a7dbd20dbfa293f389e02355f8275bb
Related-Bug: #1927357
2021-06-04 17:11:05 +01:00
John Garbutt
dee9d22dcf Add suppress_type_name to stop warnings with ES7
When using elasticsearch 7 with fluentd, you seem to get a lot
of warnings in the docker logs output that look like:

    [types removal] Specifying types in bulk requests is deprecated.

The docs suggest adding suppress_type_name to stop these warnings,
and that seems to work without affecting any functionality.

Further info here:
https://github.com/uken/fluent-plugin-elasticsearch/issues/785

Closes-Bug: #1930856
Change-Id: I45be67df3717f78d78bcdc7df69600ab8681922f
2021-06-04 10:21:24 +01:00
John Garbutt
7f1248fee5 Fix parsing of infra.mariadb.xinetd logs
Currently the logs tagged with infra.mariadb.xinetd flow into
elasticsearch with no hostname or programname attach, thus making
navigating the logs very hard.

The quick fix is renaming the tag to infra.mariadb-xinetd, which is just
enought to ensure the logs are processed correctly with the existing
filters.

TrivialFix

Change-Id: Icd72206de7c1f701bdf35c8fb3b128ef2dbe29a8
2021-06-03 18:16:20 +01:00
John Garbutt
0c7ba86e05 Stop fluentd deprecation warnings of type vs @type
Currently when elasticsearch log output is enabled there are lots
of warnings going into elasticsearch about type being deprecated
and needing to move to @type. This change stops those warnings.

TrivialFix

Change-Id: Ideac1925cb764ad0d7d8416f56d5e4a993c6d8b6
2021-06-03 18:08:14 +01:00
Mark Goddard
84ac7b3096 chrony: allow to remove the container
The chrony container is deprecated in Wallaby, and disabled by default.
This change allows to remove the container if chrony is disabled.

Change-Id: I1c4436072c2d47a95625e64b731edb473384b395
2021-06-02 17:28:35 +00:00
Zuul
008ada9062 Merge "[CI] Drop Zuul host groups" 2021-06-02 11:09:26 +00:00
Zuul
45712d5e0d Merge "[CI] Move to Debian Bullseye" 2021-06-02 10:58:06 +00:00
Zuul
f2d42d80f4 Merge "Add support for Debian Bullseye (11) as host distro" 2021-06-02 02:52:30 +00:00
Zuul
667d145ae3 Merge "[docker] Add support for setting CgroupnsMode" 2021-06-02 02:49:39 +00:00
Zuul
70ebc91e7e Merge "Make rabbitmq cluster_partition_handling configurable" 2021-05-31 16:08:40 +00:00
Zuul
13f8fd75db Merge "Trivial if conditional fix in keystone.json" 2021-05-31 14:30:39 +00:00
Radosław Piliszek
e48d0a7fab [CI] Drop Zuul host groups
They are not used.

Change-Id: Icea1a5f882e2e032c22d897efbd1f137536ae580
2021-05-31 12:42:36 +00:00
Pierre Riteau
887bf6f1f3 Fix release note markup
Change-Id: I73c2b0ab9c81bfad59725a3ea16eab5c13e07815
2021-05-31 11:14:38 +02:00
Michał Nasiadka
278b63a0eb docs: Update Freenode to OFTC
Change-Id: Idaae03612dd7feabd2cdc57e510947328524e98b
2021-05-31 09:51:04 +02:00
Marcin Juszkiewicz
d60c5591c1 [CI] Move to Debian Bullseye
Wallaby upgrades run on Buster.
To be amended in Xena.

Change-Id: I8d3a320c9fb19e18d959c555d16b736b85e010cd
2021-05-30 18:44:38 +00:00
Radosław Piliszek
9a77fb1ca0 Add support for Debian Bullseye (11) as host distro
Makes nova-libvirt container always run in 'host' CgroupnsMode
to ensure it works.

Change-Id: I75105baf434977c68bc5c8ca1f5213e602c52c8c
2021-05-30 18:40:12 +00:00
Maksim Malchuk
4d6a79d217 Add the ansible_managed header for admin-openrc.sh
This change inform us that the file is 'Ansible managed'

TrivialFix

Change-Id: I99ebeb493ff9c3c7af0010ce1efea45c7f9a2559
Signed-off-by: Maksim Malchuk <maksim.malchuk@gmail.com>
2021-05-30 21:38:12 +03:00
Radosław Piliszek
95520df094 [docker] Add support for setting CgroupnsMode
This is required to support Debian Bullseye (11) - need to set
nova-libvirt to use 'host' CgroupnsMode.

Change-Id: I40213d4092fa325bcf37bb1fb4437ab125fe328b
2021-05-30 18:28:54 +00:00
Radosław Piliszek
a3caf8c3a0 Bump min Docker version
And python-docker version.
Make them less scary.

Change-Id: I134e8aa8ed5eae479e5af743464dc2a0e40a1353
2021-05-28 13:22:38 +00:00
Pierre Riteau
bb56861cc5 Use mariadb-server image for mariabackup
The mariadb image was removed in Wallaby, leading to database backup
failures.

Change-Id: I90986e7521779997df2782767bb95efcbd8ef232
Closes-Bug: #1928129
2021-05-28 13:24:11 +02:00
Zuul
99e09537f2 Merge "cinder: fix condition to copy backend TLS certs" 2021-05-28 10:56:48 +00:00
Zuul
af861f98bf Merge "CI: Use PATH to find kolla-ansible script" 2021-05-27 19:49:25 +00:00
Scott Shambarger
283b0dec63 fluentd: Fix check for external elasticsearch
When enable_elasticsearch is False, and kolla_internal_fqdn is set
and elasticsearch_address is the default, fluentd is still enabling
output to elasticsearch.

elasticsearch_address defaults to kolla_internal_fqdn, but the
check to enable logging to an "external" elasticsearch host
compares with kolla_internal_vip_address (fqdn != vip address).

This patch fixes the comparison to use the kolla_internal_fqdn.

Closes-Bug: #1927880
Change-Id: If23a6b1273c2639d1296becc9d222546d52f63ac
2021-05-27 17:26:04 +00:00
Zuul
3b9dafdf29 Merge "Indented two spaces to match the other things in this block" 2021-05-27 15:25:45 +00:00
Mark Goddard
21efaf3f4e CI: fix backups Ceph pool name
We configure Cinder to use a 'backups' pool by default, but in CI we
create a 'backup' pool in Ceph. This change fixes CI to use 'backups'.

Change-Id: I53892137eb65ecc9530bd3859c651b12ab228a58
2021-05-27 15:33:47 +01:00
Pierre Riteau
7d1af053b5 Remove [octavia]/base_url option from neutron.conf
This configuration option was only used by neutron-lbaas, which is now
retired. It should have been added to neutron_lbaas.conf.j2 instead.

Change-Id: Iba591473abf4304413eca0d84e0b2be197c527fc
2021-05-26 15:28:09 +02:00
Zuul
5f9c5dab9a Merge "docs: add code reviews to contributor guide" 2021-05-25 12:34:35 +00:00
Zuul
8d806277f2 Merge "docs: Add note about internal VIP when HAProxy is disabled" 2021-05-25 12:34:17 +00:00
Zuul
4e28adbe6e Merge "docs: update supported OS distros" 2021-05-25 12:33:59 +00:00
Zuul
75a9ef4ad5 Merge "Mariadb shards documentation" 2021-05-25 10:29:13 +00:00
Zuul
b2629bf2ee Merge "CI: only run cells job on changes to nova role" 2021-05-25 10:20:16 +00:00
wu.chunyang
13965f40c7 tox: Add find command to allowlist_externals list
whitelist_externals is deprecated now, use allowlist_externals
instead. see[0]
Add find command to allowlist_externals list to fix a warning.[1]

[0]: https://tox.readthedocs.io/en/latest/config.html
[1]: https://zuul.opendev.org/t/openstack/build/9ac7f205080343f29d7e2b519abbdb73/log/job-output.txt#945

Change-Id: I67e9c892a945d04eff59427a0161aafceb136560
2021-05-25 09:43:01 +00:00
Mark Goddard
1ea99147c1 CI: Use PATH to find kolla-ansible script
This change also updates the CI test scripts to use PATH to find the
kolla-ansible script, rather than relying on the file in the source
checkout.

Using the script in the source checkout was hiding an issue with pip
install --user, although that has now been fixed in
I5b47a146627d06bb3fe4a747c5f20290c726b0f9.

Related-Bug: #1915527

Change-Id: I2827a657c8716a9c40391c6bdb7ff1a2a9c1260e
Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/775586
2021-05-25 10:29:12 +01:00
Mark Goddard
86ddc94ec2 Fix exit code with bogus command name
Running this:

$ kolla-ansible bogus-command

Should show usage & give a non-zero exit code. Previously it gave a zero
exit code. This change fixes the issue.

Closes-Bug: #1929397

Change-Id: I580c208d61d5efe115f936dfb8f3f6508acd91b2
2021-05-25 08:52:19 +00:00
Zuul
fa4f99950a Merge "CI: Configure IP on a linux bridge instead of OVS br-ex" 2021-05-24 16:58:07 +00:00
Zuul
bf6a14a55d Merge "linters: Mock additional variables in validate-all-file.py" 2021-05-24 16:23:08 +00:00
Michał Nasiadka
337771143b CI: Configure IP on a linux bridge instead of OVS br-ex
OVS upgrade jobs failed due to assigning an IP on the br-ex interface
(which is recycled during OVS upgrade). This change introduces a bridge
and veth pair for Neutron to use.

Change-Id: Ib3bee6e810fb8d31552d4c72c2a1ccae382c51f0
2021-05-24 14:40:30 +00:00
Mark Goddard
1da7158021 linters: Mock additional variables in validate-all-file.py
The linters job started failing, due to a dependency change.

Change-Id: Ibab350ecf6d9551da8e9c8b704693122cec11559
2021-05-24 14:38:55 +01:00
Zuul
1f5a3a288b Merge "CI: add grafana to monasca image list" 2021-05-21 18:50:24 +00:00
Mark Goddard
bbc27b59f0 CI: add grafana to monasca image list
Without this patch, if there is a change to kolla in the dependency tree
then the monasca scenario does not build grafana, and therefore fails
when trying to pull it.

Change-Id: Ic0a5b9ff940c4971a74345b8812683b29c5cedbf
2021-05-21 16:38:39 +01:00
Zuul
5c95fa32b7 Merge "[CI] Log dbus services" 2021-05-21 13:36:16 +00:00
Zuul
798249ae92 Merge "[CI] Save systemctl info" 2021-05-21 13:35:48 +00:00