4946 Commits

Author SHA1 Message Date
Michal Nasiadka
3f55b87069 Improve Apache logging
Currently we don't put global Apache error logs into /var/log/kolla,
this change adds statements that redirect those logs there.

Adapted the logfile names to catch into openstack wsgi logging fluentd
input config and existing logrotate cron entries.

Change-Id: I21216e688a1993239e3e81411a4e8b6f13e138c2
2019-12-06 13:11:49 +00:00
Zuul
f52082abf7 Merge "Fix Swift with kernel 4.19 and later" 2019-12-04 10:16:10 +00:00
Zuul
f8862c6cc2 Merge "[Train] Fix Tacker config for the local Glance store" 2019-12-03 10:21:34 +00:00
Radosław Piliszek
21488710d6 Fix Swift with kernel 4.19 and later
We mount Swift volumes with xfs.
The 'nobarrier' option we used was made noop [1]
and deprecated [2] (with warning) in kernel 4.10.
In 4.19 it was removed [3] resulting in an error
when using e.g. Debian Buster as host.
The noop patch was backported to CentOS 7 so
it is safe to remove this option with no behavior
change and backport to where needed.
Ubuntu Bionic uses 4.15 which only warns.
CentOS 8 uses 4.18 which only warns as well.
Debian Buster uses 4.19 exactly which breaks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2291dab2c9d1880efd19469df2042e2277c8b7a4
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4cf4573d899cd80d8578c050061dc342f99f3a32
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1c02d502c20809a2a5f71ec16a930a61ed779b81

Change-Id: I006dea21321146c7fc738d0b41c401b72d271a99
Closes-bug: #1800132
2019-11-30 12:56:36 +01:00
Zuul
734e86a02f Merge "Split out OVS/Linuxbridge agent configs from ml2_conf.ini" 2019-11-27 18:14:43 +00:00
Michal Nasiadka
0947974ff6 Split out OVS/Linuxbridge agent configs from ml2_conf.ini
Change-Id: I799993728112a525e34cfbc4e786a10f0ed03be9
2019-11-27 13:42:48 +00:00
Radosław Piliszek
c5f9ea9590 [Train] Fix Tacker config for the local Glance store
It turned out the previous fix ([1]) was incomplete.
Additionally, it seems we have to limit Tacker server
to one instance co-located with conductor.

[1] https://review.opendev.org/684275
commit b96ade3cf01009d822f85744efee523127f2674c

Change-Id: I9ce27d5f68f32ef59e245960e23336ae5c5db905
Closes-bug: #1853715
Related-bug: #1845142
2019-11-25 20:13:15 +01:00
Andrei Nistor
6ff6337230 Fix 'nova_cephx_raw_key' is undefined
When using external ceph without nova integration, kolla-ansible fails
because 'nova_cephx_raw_key' is undefined.
This patch fixes the issue by applying the 'default' filter to
prevent failure on undefined.
The change in behavior was introduced by [1].

[1] https://review.opendev.org/689753
commit 44709f413246a05b891f250e88c43226e1f1b0c9

Change-Id: I2fdca1a6a78e78623733a387a2d8c7e29d449083
Closes-Bug: #1853862
Co-Authored-By: Mark Goddard <mark@stackhpc.com>
2019-11-25 16:33:22 +00:00
Zuul
f8ec9f714b Merge "Remove endpoint_type from neutron.conf [DEFAULT] group" 2019-11-25 14:27:55 +00:00
Zuul
83eff5f493 Merge "Fix hard-coded admin project name and username in blazar task" 2019-11-25 12:38:03 +00:00
Pierre Riteau
c697dc98bc Remove endpoint_type from neutron.conf [DEFAULT] group
This option appears to have been removed in 2015 in Neutron change
I9cf36e1fd3a009c175e0d475af407a30f4e5c408.

Change-Id: Ib2d94743aeeff328c900ab1607900844acb4462b
2019-11-25 12:02:55 +01:00
Zuul
cfdcaf3ab2 Merge "Fixes the compatibility issue at HAProxy role with Ansible 2.9" 2019-11-23 17:02:25 +00:00
Zuul
a876f3b972 Merge "Use valid_interfaces instead of os_interface for placement" 2019-11-22 18:42:13 +00:00
Zuul
25e98f9047 Merge "Change local_action to delegate_to: localhost" 2019-11-22 18:35:54 +00:00
Pierre Riteau
96590822de Use valid_interfaces instead of os_interface for placement
The [placement].os_interface option was replaced by
[placement].valid_interfaces in Queens and was removed in Rocky.

Change-Id: I306c57305b9088159dd18af4aa373bbc39a8b881
Closes-Bug: #1853621
2019-11-22 16:39:04 +01:00
Michal Nasiadka
1009931162 Change local_action to delegate_to: localhost
As part of the effort to implement Ansible code linting in CI
(using ansible-lint) - we need to implement recommendations from
ansible-lint output [1].

One of them is to stop using local_action in favor of delegate_to -
to increase readability and and match the style of typical ansible
tasks.

[1]: https://review.opendev.org/694779/

Partially implements: blueprint ansible-lint

Change-Id: I46c259ddad5a6aaf9c7301e6c44cd8a1d5c457d3
2019-11-22 15:04:44 +00:00
Zuul
22cc65aafc Merge "Allow region setting for ironic-neutron-agent" 2019-11-22 12:21:21 +00:00
Zhuo Zhen
7f457cd928 Allow region setting for ironic-neutron-agent
The "os_region" param is missing in the ironic_neutron_agent.ini.j2
file. Without specifying the region, the neutron service will randomly
pick a region for the ironic-neutron-agent. Therefore, a list of
incorrect agents might be created in the neutron database "agents"
table for nodes from other regions. To list all neutron agents, use
'openstack network agent list'.

Change-Id: Idec265230d0ab63b7559d94690c059608dc2617e
Closes-bug: #1853464
2019-11-21 08:48:18 -06:00
Zhuo Zhen
f2d32d2e01 Fix hard-coded admin project name and username in blazar task
In one of the blazar ansible tasks in "bootstrap.yml", the admin
project name and username are hard-coded as "admin". OpenStack
users can define their admin project name and username differently
and the hard-coded names would cause authentication errors.

In addition, keystone identity api version 3 uses "os-project-name"
instead of "os-tenant-name". Although "os-tenant-name" might be
still accepatable, it's better to keep the latest.

Change-Id: Ie5c1016f9ce6f402ef208f3c295e6883a9edd8ab
Closes-bug: #1853462
2019-11-21 08:39:11 -06:00
Zuul
a1cd432630 Merge "Fix deployment of Qinling" 2019-11-21 13:50:53 +00:00
Zuul
c641096ea6 Merge "Parse MariaDB log messages in different formats into Fluentd" 2019-11-20 21:21:22 +00:00
Zuul
6d63ed6d2b Merge "Fix missing environment variable for Qinling" 2019-11-20 21:07:56 +00:00
Zuul
58968223db Merge "Remove Neutron integration with ONOS" 2019-11-20 18:57:36 +00:00
Gaëtan Trellu
78153195b0 Fix missing environment variable for Qinling
Remove "environment" variable from check-containers.yml task.

Change-Id: Id1e1abfb10df1eb6c8f4f3c7d2f5a0dd94c0a2cc
Closes-bug: #1853336
2019-11-20 11:40:33 -05:00
Radosław Piliszek
73649aeaac Fix deployment of Qinling
Qinling could not be deployed due to use of an undefined variable
(you guessed it, it was a typo).

Change-Id: Iadbf269e66decc0a4c6b24b3d828ac560adeb7a7
Closes-bug: #1853201
2019-11-20 14:08:39 +01:00
Zuul
28e082ea02 Merge "Use internal API for heat -> keystone communication" 2019-11-19 11:14:34 +00:00
Zuul
e5149cbcc2 Merge "Fix local_action and line_length>160 in common role" 2019-11-19 11:14:33 +00:00
Zuul
7c17c3c45e Merge "Vitrage: typo in precheck task" 2019-11-18 17:58:08 +00:00
Michal Nasiadka
2a5532c9a9 Fix local_action and line_length>160 in common role
- transitional handling of fluentd_binary var is no longer required

Change-Id: Ic2978252fb981fe15e600aa486e8af585d05c402
2019-11-18 17:31:52 +00:00
Michal Nasiadka
865ac24fc5 Remove Neutron integration with ONOS
Change-Id: Ie35ea07b8b6f95cbb56eb722ae2366c00243e562
2019-11-18 15:39:19 +00:00
Zuul
c4818ffd16 Merge "Remove OpenDaylight role" 2019-11-18 15:30:39 +00:00
Viktor Michalek
0217ebb82f Vitrage: typo in precheck task
Change-Id: If45d4877c3fa125a3abc71f0a84883fad0a0cf6e
Closes-Bug: 1853011
2019-11-18 15:39:13 +01:00
Michal Nasiadka
eec6831fff Remove OpenDaylight role
Opendaylight support has been deprecated in Train - time to remove it.

Change-Id: I3a61bfbcbf366c327ea3e25d2424bc3fedca29f0
2019-11-18 11:57:32 +00:00
caoyuan
052bc86e34 Adjust the order of src and dest for template module
1. Adjust the order of src and dest for template module
2. Remove the double quotes from task's name to keep consistence with
the others.
3. Add a space after "|"

Change-Id: I580517d5b95dcaa34841def70ec6f57a5cbe0229
2019-11-16 23:19:24 +08:00
Radosław Piliszek
2cd00dadc0 Use internal API for heat -> keystone communication
Continues work from https://review.opendev.org/676716

Change-Id: If0195c38034d404849bf2e8fca4629b2d38a2680
Closes-Bug: #1812864
Related-Bug: #1762754
Related-Bug: #1688331
2019-11-16 13:40:27 +00:00
Zuul
0b24cad92b Merge "Remove transitional support for influxdb in cloudkitty upgrade" 2019-11-15 14:08:15 +00:00
Zuul
31a5848b73 Merge "Start Docker after upgrade" 2019-11-15 13:00:04 +00:00
Zuul
1a82bd91b5 Merge "Fix restart policy after MariaDB recovery" 2019-11-15 12:17:12 +00:00
Zuul
db228d1ad2 Merge "Remove precheck for nova_enable_rolling_upgrade" 2019-11-15 12:17:10 +00:00
Zuul
287a41aa7f Merge "Remove transitional support for neutron-lbaas removal" 2019-11-15 12:17:09 +00:00
Mark Goddard
d98be11e46 Remove precheck for nova_enable_rolling_upgrade
This variable was removed in the Train cycle, and a precheck added for
its use. This precheck can now be removed.

Change-Id: I6d9f0b577631ff9443deecf8ef9d94ca217674c5
2019-11-14 11:53:53 +00:00
Mark Goddard
0bd60388a8 Remove transitional support for neutron-lbaas removal
Support for deploying neutron-lbaas was removed in the Train release. We
no longer need the task to remove the container in the upgrade process.

Change-Id: Ie336f68c710616de29f34dd4011e137ec056973b
2019-11-14 11:48:56 +00:00
Mark Goddard
e6c5aa4a08 Remove transitional support for influxdb in cloudkitty upgrade
During the Stein release the default storage backend for cloudkitty was
switched to influxdb. To aid this transition we added creation of the
influxdb database during upgrade. Now that this transition is complete
we can remove it.

Change-Id: Ieb247f36af932d3a357504c7419ead44b10d1301
2019-11-14 11:40:41 +00:00
Dincer Celik
4f216b3d28 Fixes the compatibility issue at HAProxy role with Ansible 2.9
Change-Id: I36b858b9b03005feabd77e7208674f37c820e9d4
Closes-Bug: #1852430
2019-11-14 12:56:28 +03:00
Keith Plant
a3a1b068fe Add support for custom HAProxy service config
Allow users to create/override HAProxy service configuration by
copying over '*.cfg' files from {{ node_custom_config
}}/haproxy/services.d/

Ex: /etc/kolla/config/haproxy/services.d/radosgw.cfg

Change-Id: Id84e3b6e62e544582d6917047534e846e026798d
Signed-off-by: Keith Plant <kplantjr@gmail.com>
2019-11-11 15:24:46 -05:00
Zuul
a9f7ab1f56 Merge "Collect rabbitmq logs by fluentd" 2019-11-11 16:36:33 +00:00
Mark Goddard
82e58a7a5a Start Docker after upgrade
If you do the following:

* Install legacy Docker (1.12.0) using kolla-ansible bootstrap-servers
  with the Rocky release or earlier.
* Update to Docker CE, using kolla-ansible bootstrap-servers with the
  Stein release or later

The package is upgraded, but docker is stopped. This prevents the 'Wait
for Docker to start' task from completing, since Docker will not start.
Seen on CentOS 7.6, Docker CE 19.03.4.

This was tested and working previously, perhaps something changed with
the Docker package.

This change fixes the issue by starting and enabling Docker after the
upgrade.

Change-Id: If6e9c91f3e8d0ec366eea7ca506c6d10dbf11c3a
Closes-Bug: #1852066
2019-11-11 11:16:05 +00:00
Zuul
f15d5d500c Merge "Fix keystone fernet rotation for source images" 2019-11-07 10:27:58 +00:00
Mark Goddard
f979ae1f8e Fix restart policy after MariaDB recovery
After performing a recovery of MariaDB, the mariadb containers are left
without a restart policy. This leaves them unable to recover from the
crash of a single galera node. There is another issue, in that the
'master' node is left in a bootstrap configuration, with the
--wsrep-new-cluster argument configured as BOOTSTRAP_ARGS.

This change fixes these issues by removing the restart policy of 'no'
from the 'slave' containers, and recreating the master container without
the restart policy or bootstrap arguments.

Change-Id: I36c875611931163ca2c29ae93b71d3af64cb197c
Closes-Bug: #1851594
2019-11-07 10:08:57 +00:00
Zuul
56f355136a Merge "Fix indentation of HAProxy internal http-request config" 2019-11-06 12:06:40 +00:00