13196 Commits

Author SHA1 Message Date
Michal Nasiadka
b6c68e2bb4 Skip ansible-lint fqcn for module actions and role-name
Add noqa for:
Object of type PosixPath is not JSON serializable

Change-Id: Id6ef88bb8cd16120bf31da679d1129d99f4b9fd8
2022-10-12 10:02:52 +02:00
Zuul
a8b601dc12 Merge "CI: Fix init-swift" 2022-10-10 12:53:35 +00:00
Zuul
2d56e829ac Merge "Make Keystone admin endpoint creation optional" 2022-10-10 12:28:16 +00:00
Radosław Piliszek
5b431f0f7f Allow setting any_errors_fatal true for gather-facts
Kolla Ansible now supports failing execution early if fact collection
fails on any of the hosts. This is to avoid late failures due to missing
facts (especially cross-host).

Change-Id: I7a74b937ded0b9da0621cf413f3a5d0d13a2cd68
Partial-Bug: #1833737
2022-10-10 11:11:15 +00:00
Zuul
2e2cd75979 Merge "Stop showing image locations" 2022-10-10 08:39:34 +00:00
Zuul
b83cba838a Merge "Fix image from volume upload ERRORs and WARNINGs with Ceph RBD" 2022-10-10 08:35:27 +00:00
Michal Nasiadka
35f90a31eb CI: Fix init-swift
Container image naming scheme has changed

Change-Id: I775ea3f796290c670e4b04640f4429304dae609c
2022-10-10 08:19:17 +00:00
Zuul
e8887c2cec Merge "[CI] Improve Cinder testing robustness" 2022-10-07 17:05:20 +00:00
Zuul
c1f31c909d Merge "Make Cinder with iSCSI use fewer volumes" 2022-10-07 17:00:04 +00:00
Radosław Piliszek
a4b4043308 Fix image from volume upload ERRORs and WARNINGs with Ceph RBD
By resetting image_upload_use_cinder_backend to upstream default.

When uploading volume to glance image, cinder looks at the backend's
image_upload_use_cinder_backend config knob to decide whether to try link
the glance image to a cloned volume made by cinder, i.e. by doing all work
locally and only updating glance's locations for the image (when the knob
is set to True). However, after all [1], [2] and [3], which happens since
Victoria, this option requires further config from user (using volume type
with image_service:store_id property (aka extra spec) set to the desired
glance store (even if there is only one cinder store configured).

Please read the bug report as to why the option removal is the
best option (TL;DR it is the most compatible approach).

[1] https://review.opendev.org/c/openstack/kolla-ansible/+/708114
[2] https://review.opendev.org/c/openstack/glance_store/+/746556
[3] https://review.opendev.org/c/openstack/cinder/+/661676

Closes-Bug: #1991516
Change-Id: Ife87ee0241d907a0c407eb21811a354ed1734408
2022-10-07 15:05:12 +00:00
Radosław Piliszek
febd99eb69 Make Cinder with iSCSI use fewer volumes
These are not used by the relevant daemons and so can be dropped to,
e.g., avoid creating the cinder volume on hosts where there is no
cinder.

Change-Id: Ia8d906a9e0227f361883a7ec1ec8dcd73e4104dc
2022-10-07 14:20:45 +00:00
Radosław Piliszek
3a0465f89a [CI] Improve Cinder testing robustness
Use the smallest images possible and always wait 5 minutes before
declaring a failure.

Change-Id: I1a5d623a86a27826b3e36dfe5fb4c55f3d46f3f2
2022-10-07 14:20:24 +00:00
Radosław Piliszek
da292982b1 Stop showing image locations
This is generally considered insecure because it may reveal
sensitive data [1].
Furthermore, it happens that the default Ceph perms cause fatal
ERRORs with this setting:
1) when Glance wants to remove an image, it cannot list children
because Cinder or Nova might have created a linked volume clone
behind the scenes and it is put in another pool (volumes/vms)
which Glance cannot normally access;
2) when Nova wants to create an image, it lacks permissions
to write to the images pool.

Thus, I propose that Kolla Ansible stops setting this by default
and relies on the working defaults.
The downside is that this disables optimisations in Cinder and Nova.
On the other hand, these optimisations have nasty behaviour of
being linked directly to the original image, preventing its removal.

[1] https://docs.openstack.org/glance/yoga/configuration/glance_api.html#DEFAULT.show_multiple_locations

Change-Id: I63ee9a6eefd8593f2169bba34dbb699f413d7cf8
Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/860093
Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/860291
Closes-Bug: #1992153
2022-10-07 14:20:08 +00:00
Radosław Piliszek
39269a4f64 [heat] Remove an ancient deprecated task
Change-Id: Ic267b0bc1153940f7595a1cf93ff2c62dd084d4e
2022-10-07 14:19:47 +00:00
Doug Szumski
522c3291cd Support specifying Nova compute provider config
In the Victoria cycle, Nova merged improved support for
managing resource providers:
https://review.opendev.org/q/topic:bp%252Fprovider-config-file

See the blueprint for more details:
https://docs.openstack.org/nova/latest/admin/managing-resource-providers.html

This change allows us to copy the necessary configuration.

Change-Id: I0a3caaad73bc6fe27380e7f6bf6b792aca51c84c
2022-10-07 12:58:38 +00:00
Dr. Jens Harbott
df73e3ab02 Fix indentation in test script
bashate 2.1.1 now also verifies the indentation of comments, so watch
out.

Change-Id: Ia423d8e96884cf1f5a1edbf768ad3202af4bdc86
2022-10-07 13:22:38 +02:00
Zuul
17aeda1fcf Merge "Bump Ansible min version to 2.12/5 and max to 2.13/6" 2022-10-05 18:04:38 +00:00
Radosław Piliszek
1a4689975e [CI] Test image from instance
This is a missing Nova->Glance interaction that is sometimes
useful.

Change-Id: I05b22d90ec31ef3b63210c2563d6e5547d565874
Depends-On: https://review.opendev.org/c/openstack/kolla/+/860230
2022-10-05 09:30:35 +00:00
Zuul
5b848d01f0 Merge "[glance][cinder] Stop owning RBD defaults" 2022-10-04 15:53:27 +00:00
Zuul
c2cbf061b6 Merge "Remove the deprecated enable_ironic_ipxe" 2022-10-04 14:21:23 +00:00
Zuul
2d37ce15e7 Merge "set haproxy balance algorithm to roundrobin for horizon" 2022-10-04 14:21:20 +00:00
Zuul
1cddf8050d Merge "Keystone OIDC JWKS fix" 2022-10-04 14:21:17 +00:00
Michal Nasiadka
98a691a7c9 Bump Ansible min version to 2.12/5 and max to 2.13/6
Change-Id: Ie09bf108250a71d539002dd5ccfa63dd71bcfe90
2022-10-04 11:45:28 +00:00
Zuul
0052deac23 Merge "Remove dhcp-sequential-ip in ironic dnsmasq config" 2022-10-04 10:54:21 +00:00
Zuul
447ee7b269 Merge "Fix interface option for ironic-neutron-agent" 2022-10-04 10:40:02 +00:00
Michal Nasiadka
fc615ec9c6 CI: Enable rocky9-cells job
ProxySQL image has been published, this can be enabled now.

Change-Id: I8e4456750fc690b2d67b6572f2384b45f6199b62
2022-10-04 09:23:10 +02:00
Serhat Rıfat Demircan
155ed969ae set haproxy balance algorithm to roundrobin for horizon
Currently kolla-ansible sets haproxy balance algorithm to source for
horizon. We can set it to round-robin if the cache backend is memcached
or using the database as the session storage backend. So we can
distribute http requests evenly to all available horizon instances.

Closes-Bug: #1990523
Change-Id: I0721cadcf53d59947bc0db6a193bfafe49c41ad3
2022-10-03 22:42:41 +03:00
Radosław Piliszek
52ec5ef390 [glance][cinder] Stop owning RBD defaults
These are upstream defaults, no need to carry them around.

TrivialFix

Change-Id: I2907d5f38c6a74776961bd473553edf2d83f7257
2022-10-03 16:53:35 +02:00
Michal Nasiadka
ec0367c039 CI: Always build images for centos jobs
CentOS 9 Stream images are not getting published so we need to build
them every time.

Change-Id: I782ab105da4f23979dcbe2348c7141a1ae272b9a
2022-10-03 12:47:41 +00:00
Michal Nasiadka
c026666551 Add Rocky to default distro map and use published images
This patch also changes python version and default tag for centos.
prometheus-efk and venus jobs commented out, elasticsearch images
are unbuildable
cells is commented out because proxysql is unbuildable

Change-Id: Ic358f8b600317d3c2fc45130a59785225aea1153
2022-10-03 14:45:50 +02:00
Jakub Darmach
9892976119
Keystone OIDC JWKS fix
JWT failed to validate on auth-oidc endpoint used by openstack cli
with "could not find key with kid: XX" error. To fix this we need
to use jwks provided in "jwks_uri" by OIDC metadata endpoint.

Missing "ServerName" directive from vhost config causes redirection
to fail in some cases when external tls is enabled.

  - added "keystone_federation_oidc_jwks_uri" variable
  - added "OIDCOAuthVerifyJwksUri" to keystone vhost config
  - added "ServerName" to keystone vhost config
  - jinja templating additional whitespace trimmed to
    correct end result indentation and empty newlines

Closes-bug: 1990375
Change-Id: I4f5c1bd8be8e23cf6299ca4bdfd79e9d98c9a9eb
2022-10-03 12:36:11 +02:00
Pierre Riteau
9ce47b2fff Remove dhcp-sequential-ip in ironic dnsmasq config
With this option enabled, dnsmasq can offer the same IP address to
multiple hosts when their requests are close to each other. Remove this
option in order to use the built-in hashing mechanism which will
allocate random IP addresses, which should be less likely to conflict.

Closes-Bug: #1991390
Change-Id: I09a9fa2d0c54635b899ad7906cc2e2e4580ef5ad
2022-09-30 13:26:23 +02:00
Radosław Piliszek
dc9ab52d0d [tox] Fix installation of requirements
Both venv and linters (and its children) environments install
kolla-ansible and thus also install the requirements.
However, they were doing this post-factum and thus without the
constraints pin.
This patch also removes the installation of test-requirements
in venv as it is meant to be used for running the software and
we already have environments for unit tests.
The doc requirements are left in place because docs mention
that ``tox -e venv -- reno`` should work. They should be harmless
but I am open to removing them as well.

Change-Id: I15f1ecc216c9ba81dad740c372d297adf279a945
2022-09-29 16:37:39 +02:00
Radosław Piliszek
8d646af3b5 [ironic] Drop an extra wait
By the comment message, it should no longer be necessary to wait
at this stage and we can speed up the process a little bit.

Change-Id: Ia96bfa79aaad5fbd54a9f527702cca7a63616bf7
2022-09-29 16:31:31 +02:00
Radosław Piliszek
b95de04ff4 [ironic] Remove useless tasks
They served us well in Yoga but they are no longer needed in Zed.
This also avoids the early deletion of the ironic-conductor, making
it really roll.

Change-Id: I9bc85d894b5bf947ac8fca505df446b99b0bb99b
2022-09-29 15:53:22 +02:00
Zuul
4c60cc524c Merge "bifrost: Use the combined Ironic service instead of API+conductor" 2022-09-29 13:16:51 +00:00
Zuul
22cc60b21f Merge "init-runonce: use CirrOS 0.6.0" 2022-09-29 12:43:08 +00:00
Michal Nasiadka
4a40418e48 bifrost: Use the combined Ironic service instead of API+conductor
Fix bifrost stop.yml after I9faecfe6ece6d3c35396e3378c1e3930a487e130

Change-Id: I850cbbb83d10b1518cc73612a591b160c2d49f1c
2022-09-29 12:11:13 +02:00
Zuul
e945b68fab Merge "CI: rocky9 - add to multiple if base_distro statements" 2022-09-29 09:45:40 +00:00
Marcin Juszkiewicz
e17a0ca24a init-runonce: use CirrOS 0.6.0
CirrOS 0.6.0 was released yesterday. Has newer kernel and userspace,
better network configuration (more IPv6 stuff) and some other
improvements.

Change-Id: Ife7767904efe64602531fa3eb163c78260650909
2022-09-29 11:08:32 +02:00
Radosław Piliszek
3029281c1d Remove the deprecated enable_ironic_ipxe
Change-Id: Ia8acdf69cb3676ec939777c32f0568cb720c471f
2022-09-29 10:39:19 +02:00
Michal Nasiadka
81f3aa5ac0 init-runonce: Add KOLLA_CONFIG_PATH support
Kayobe uses it, so let's fix the check.

Change-Id: I99b2a7f8609fd708f4829f21c81029c7b8da5d73
2022-09-28 17:35:09 +00:00
Michal Nasiadka
9d5f9080da CI: rocky9 - add to multiple if base_distro statements
Change-Id: Ib068117237a199db380fcdfb757d5d0e5d34326b
2022-09-28 15:59:05 +02:00
Zuul
6bff120d2d Merge "Introduce variables for cinder backend names" 2022-09-27 17:13:40 +00:00
Zuul
652bbe30c8 Merge "Fix Ironic API healthcheck with backend TLS" 2022-09-27 16:15:55 +00:00
Zuul
80c059a2a1 Merge "Do not enable nova_legacy service by default" 2022-09-27 16:09:02 +00:00
Zuul
7b7ff1a3fb Merge "Specify number of threads for designate bind9 backend" 2022-09-27 15:01:43 +00:00
Zuul
aef2c36d86 Merge "Change clouds.yaml location" 2022-09-27 13:56:10 +00:00
Michal Nasiadka
ed2cf2f5e5 Change clouds.yaml location
It's a followup to 73a1812c5856be635827b6c6de81b39c22346457
addressing post-merge comments.

Change-Id: Idd458ad6ef29e4eee2f9e537b4eae39d26eb9f64
2022-09-27 11:10:12 +00:00
Radosław Piliszek
4277c1a1a4 Do not enable nova_legacy service by default
Change-Id: Ic89097fdc72d4fa11754201ed6e388bf79ca40b6
2022-09-27 08:37:05 +00:00