Currently, we have a lot of logic for checking if a handler should run,
depending on whether config files have changed and whether the
container configuration has changed. As rm_work pointed out during
the recent haproxy refactor, these conditionals are typically
unnecessary - we can rely on Ansible's handler notification system
to only trigger handlers when they need to run. This removes a lot
of error prone code.
This patch removes conditional handler logic for all services. It is
important to ensure that we no longer trigger handlers when unnecessary,
because without these checks in place it will trigger a restart of the
containers.
Implements: blueprint simplify-handlers
Change-Id: I4f1aa03e9a9faaf8aecd556dfeafdb834042e4cd
Remove the erroneous curly braces that prevent the Telegraf
configuration template from being rendered.
Change-Id: Ibb8738b258245b4e43d5d877b156ed296fc66e4e
Closes-Bug: 1810505
With this change, an operator may be able to stop a
service container without stopping all services in a host.
This change is the starting point to start
fast-forward upgrades support.
In next changes new flags will be introducced to disable
stop dataplane services during upgrades.
Change-Id: Ifde7a39d7d8596ef0d7405ecf1ac1d49a459d9ef
Implements: blueprint support-stop-containers
This commit is the final commit to apply resource-constraints
to all OpenStack services.
Depends-on: I39004f54281f97d53dfa4b1dbcf248650ad6f186
Change-Id: I072d69be9698be54775cb0ae286ea2b6ed78776c
Implements: blueprint resource-constraints
Add become to all tasks that use the module "kolla_docker"
Change-Id: I4309c4011687b88ec31d739fd8f834fe2326ff10
Partial-Implements: blueprint ansible-specific-task-become
- rename action and serial to kolla_ansible and kolla_serial
- use become instead of "sudo <command>" in shell
- Remove quota for failed_when and changed_when in rabbitmq tasks
Change-Id: I78cb60168aaa40bb6439198283546b7faf33917c
Implements: blueprint migrate-to-ansible-2-2-0
Kolla add multiple url in one outputs.influxdb.
This configuration is when influxdb is in cluster mode.
We need to write one conf by influxdb server.
Change-Id: I1c788b3c8400e74d50cace5a334311408989c5e1
This change allows the following use cases:
1. Using an already-configured MariaDB / MySQL server / Cluster
2. Using already-created DB users, without requiring root DB access.
Update: added external mariadb precheck
Change-Id: I78b0d178306d7c5293b0bf53e445f19f18b4b824
Implements: blueprint external-mariadb-support.
Closes-Bug: #1603121
Telegraf can collect sample from collectd via UDP.
Configure collectd to exposed samples and telegraf to collect them.
Change-Id: Ie868a4c23cb793e6054e14ee1209a56256c130ac
Depends-On: I33b1a3fe606bf5bd4a08901c7bf274aed5303055
Certain services such as Murano and trove require access to a rabbitmq
instance from tenant networks. [0]
Exposing the internal rabbitmq to end users is a security hole, hence
there are two options, 1) use vhosts in the existing rabbitmq, or two a
separate rabbitmq instances. Given the importance of rabbitmq to the
OpenStack deployment, we have decided to go with a separate instance.
Refer to [1] for more detail on the various options.
This change makes the rabbitmq role generic so that it can be reused, in
this case to start 'outward_rabbitmq'. It needs to be exposed via
haproxy both for network isolation and also because this is what Murano
configuration requires.
Follow on patches will be added to add a vhost in this outward instance
for Murano and other services which require access.
Based on the original work by bdaca[2]
[0] http://murano.readthedocs.io/en/stable-liberty/intro/architecture.html
[1] http://lists.openstack.org/pipermail/openstack-dev/2016-December/109091.html
[2] https://review.openstack.org/#/c/374525
Change-Id: Ib2bcc7ed4bf4f883a7cd1dfad3db89201e3cfd8d
Partial-Bug: #1620374
Depends-On: I020eb6219f89a310451becde41f6f1c7f54baadd
Co-Authored-By: Bartłomiej Daca <bartek.daca@gmail.com>
Influxdb is standalone deployed by kolla-ansible,
The cluster mode is charged now.
Previously configured, each telegraf monitors all influxdb.
If the telegraf is more, It is a disaster to influxdb.
So, telegraf should monitor influxdb deployed on the same server.
Change-Id: I9f4003a55de2a7be53c644b1d2f89d00cdf9478a
Telegraf always restart containers when doing reconfigure, due to
"pid_mode" attribut missing during compare_container.
Hence compare_container always evaluated to True.
Change-Id: I335816ebf99a218a5400b2baae5b55788459bfff
Closes-Bug: #1686349
During "Optimize reconfigure action for Telegraf" previous commit, a
regression has been introduced on the "reconfigure" action.
https://review.openstack.org/#/c/424202/
The start.yml file has been deleted but reconfigure.yml still using it.
This patch fix it.
Change-Id: I8879b83ce7a1f886f6870d79f63c3f1cc706059b
Closes-Bug: #1676403
Telegraf allow plugin configuration in /etc/telegraf/telegraf.d
directory. These files comes from telegraf/templates/config/*.conf,
but this directory is optional.
Closes-Bug: #1673691
Change-Id: Idc695c86c5f6b6b0bd514728f2025321cd200907
Add a new subcommand 'check' to kolla-ansible, used to run the
smoke/sanity checks.
Add stub files to all services that don't currently have checks.
Change-Id: I9f661c5fc51fd5b9b266f23f6c524884613dee48
Partially-implements: blueprint sanity-check-container
When enabling telegraf, task failed with "the field 'vars' has an invalid value,
which appears to include a variable that is undefined. The error was: 'dict
object' has no attribute 'telegraf_services'"
Change-Id: I6dd5c401bf9b673685ad1b4a20f85c55ce04abbc
Closes-bug: #1662807
Added mysql plugin for telegraf to be used by default.
Plugin gathers the statistic data from MySQL server.
Change-Id: I853af61b64739eedb70ab2b8dc78f0285a839671
Closes-Bug: #1652609
do_reconfigure.yml is introduced to use serial directive. But we use
it in wrong. Now serial has moved to playbook file. So it is time to
remove the do_reconfigure.yml file
Closes-Bug: #1628152
Change-Id: I8d42d27e6bc302a0e575b0353956eaef9b2ca9fd
Added ansible role to deploy telegraf
Roll out telegraf to all nodes
Introduce parameter to toggle deployment of performance monitoring
Co-Authored-By: zhubingbing <zhubingbing10@gmail.com>
Change-Id: Ia09b20ce65bf557c1a1030eda99df5cc88debd01
Partially-Implements: Blueprint performance-monitoring