53376aed8f
This patch builds upon genconfig optimisation and it takes it
further by not having genconfig ever touch the handlers!
Calling the handlers and skipping them created an unnecessary slow down
if only config was ran. It also depends on the config checking fix.
This gets us closer to the single responsibility principle -
config only generates the config, container checks only validate
whether container restart is needed.
And this also means that we will have single place were containers
are restarted, were we can fix the ansible quirk of it restarting
the whole group even when one container changed in the following patches.
The only exception is the loadbalance role. As the loadbalancer services
have their config altered by other roles registering their services
using loadbalancer-config. This is in contrast to typical roles,
which do config in one step and can then run check-containers in
the next step.
Fixes some handlers that were missing the necessary guard,
making genconfig actually able to restart some containers.
Future work:
- optimise config by doing local generation and mass rsync
- support for reloads
- unconditional restart/reload (separate action)
- make 'reconfigure' act like 'genconfig' + 'deploy-containers'
- this would avoid calling bootstrapping each time but might
be tricky as it would break current compatibility
- could call this 'reconfigure-containers' and deprecate
'reconfigure'
- fix the ansible quirk that notifies more handlers then intended
Change-Id: I0ce24043ae5486b2b55489ba40abe2b96b0991a6
Partially-Implements: blueprint performance-improvements
Co-Authored-By: Roman Krček <roman.krcek@tietoevry.com>
72 lines
2.2 KiB
YAML
72 lines
2.2 KiB
YAML
---
|
|
- name: Ensuring config directories exist
|
|
file:
|
|
path: "{{ node_config_directory }}/{{ item.key }}"
|
|
state: "directory"
|
|
owner: "{{ config_owner_user }}"
|
|
group: "{{ config_owner_group }}"
|
|
mode: "0770"
|
|
become: true
|
|
with_dict: "{{ skyline_services | select_services_enabled_and_mapped_to_host }}"
|
|
|
|
- include_tasks: copy-certs.yml
|
|
when:
|
|
- skyline_copy_certs
|
|
|
|
- name: Copying over skyline.yaml files for services
|
|
merge_yaml:
|
|
sources:
|
|
- "{{ role_path }}/templates/skyline.yaml.j2"
|
|
- "{{ node_custom_config }}/skyline/skyline.yaml"
|
|
dest: "{{ node_config_directory }}/{{ item.key }}/skyline.yaml"
|
|
mode: "0660"
|
|
become: true
|
|
with_dict: "{{ skyline_services | select_services_enabled_and_mapped_to_host }}"
|
|
|
|
- name: Copying over gunicorn.py files for services
|
|
vars:
|
|
service: "{{ skyline_services['skyline-apiserver'] }}"
|
|
template:
|
|
src: "{{ item }}"
|
|
dest: "{{ node_config_directory }}/skyline-apiserver/gunicorn.py"
|
|
mode: "0660"
|
|
become: true
|
|
when: service | service_enabled_and_mapped_to_host
|
|
with_first_found:
|
|
- "{{ node_custom_config }}/skyline/gunicorn.py"
|
|
- "gunicorn.py.j2"
|
|
|
|
- name: Copying over nginx.conf files for services
|
|
vars:
|
|
service: "{{ skyline_services['skyline-console'] }}"
|
|
template:
|
|
src: "{{ item }}"
|
|
dest: "{{ node_config_directory }}/skyline-console/nginx.conf"
|
|
mode: "0660"
|
|
become: true
|
|
when: service | service_enabled_and_mapped_to_host
|
|
with_first_found:
|
|
- "{{ node_custom_config }}/skyline/nginx.conf"
|
|
- "nginx.conf.j2"
|
|
|
|
- name: Copying over config.json files for services
|
|
template:
|
|
src: "{{ item.key }}.json.j2"
|
|
dest: "{{ node_config_directory }}/{{ item.key }}/config.json"
|
|
mode: "0660"
|
|
become: true
|
|
with_dict: "{{ skyline_services | select_services_enabled_and_mapped_to_host }}"
|
|
|
|
- name: Copying over custom logos
|
|
become: true
|
|
vars:
|
|
service: "{{ skyline_services['skyline-console'] }}"
|
|
copy:
|
|
src: "{{ node_custom_config }}/skyline/logos/{{ item }}"
|
|
dest: "{{ node_config_directory }}/skyline-console/logos/"
|
|
mode: 0660
|
|
when:
|
|
- service | service_enabled_and_mapped_to_host
|
|
- skyline_custom_logos | length > 0
|
|
with_items: "{{ skyline_custom_logos }}"
|