kolla-ansible/ansible/roles/prechecks/tasks/main.yml
Mark Goddard b685ac44e0 Performance: replace unconditional include_tasks with import_tasks
Including tasks has a performance penalty when compared with importing
tasks. If the include has a condition associated with it, then the
overhead of the include may be lower than the overhead of skipping all
imported tasks. For unconditionally included tasks, switching to
import_tasks provides a clear benefit.

Benchmarking of include vs. import is available at [1].

This change switches from include_tasks to import_tasks where there is
no condition applied to the include.

[1] https://github.com/stackhpc/ansible-scaling/blob/master/doc/include-and-import.md#task-include-and-import

Partially-Implements: blueprint performance-improvements

Change-Id: Ia45af4a198e422773d9f009c7f7b2e32ce9e3b97
2020-08-28 16:12:03 +00:00

22 lines
450 B
YAML

---
- include_tasks: host_os_checks.yml
when: prechecks_enable_host_os_checks | bool
- include_tasks: timesync_checks.yml
when:
- not enable_chrony | bool
- import_tasks: datetime_checks.yml
- include_tasks: port_checks.yml
when:
- inventory_hostname not in groups['deployment']|default([])
- import_tasks: service_checks.yml
- import_tasks: package_checks.yml
- import_tasks: user_checks.yml
- import_tasks: database_checks.yml