openstack/manila
Code Issues Proposed changes

Merge "vast: return all available export locations"

Browse Source
This commit is contained in:
Zuul
2024-12-04 00:43:30 +00:00
committed by Gerrit Code Review
parent 66ac1ce69a 82238c7800
commit 037ffdfb2f
3 changed files with 20 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
manila/share/drivers/vastdata/driver.py
View File

@@ -169,7 +169,7 @@ class VASTShareDriver(driver.ShareDriver):
return f"{root}/manila-{share_id}"
def create_share(self, context, share, share_server=None):
return self._ensure_share(share)[0]
return self._ensure_share(share)
def delete_share(self, context, share, share_server=None):
"""Called to delete a share"""

16
manila/tests/share/drivers/vastdata/test_driver.py
View File

@@ -192,12 +192,18 @@ class VASTShareDriverTestCase(unittest.TestCase):
mock_rest.views.ensure.assert_called_once_with(
name="fakeid", path="/fake/manila-fakeid", policy_id=1
)
self.assertDictEqual(
self.assertListEqual(
location,
{
'path': '1.1.1.0:/fake/manila-fakeid',
'is_admin_only': False
}
[
{
'path': '1.1.1.0:/fake/manila-fakeid',
'is_admin_only': False
},
{
'path': '1.1.1.1:/fake/manila-fakeid',
'is_admin_only': False
},
]
)
if not policy:
mock_rest.views.update.assert_called_once_with(

8
releasenotes/notes/bug-2088269-vast-add-multiple-export-locations-39243a9091c145f9.yaml Normal file
View File

@@ -0,0 +1,8 @@
---
fixes:
- |
`Launchpad bug #2037422 <https://bugs.launchpad.net/manila/+bug/2088269>`_:
Fixed an issue within the VASTData driver that made only one export path
available for mounting, regardless if more mount paths were available. Now,
the amount of export locations will correspond to the way the storage is
configured for better load balancing.