openstack/manila
Code Issues Proposed changes

Merge "Implement secure RBAC for share locations"

Browse Source
This commit is contained in:
Zuul 2021-03-08 19:58:30 +00:00 committed by Gerrit Code Review
commit 06a9cb1c41
1 changed files with 28 additions and 4 deletions

32
manila/policies/share_export_location.py

@ -10,6 +10,7 @@
# License for the specific language governing permissions and limitations
# under the License.
from oslo_log import versionutils
from oslo_policy import policy
from manila.policies import base
@ -17,21 +18,40 @@ from manila.policies import base
BASE_POLICY_NAME = 'share_export_location:%s'
DEPRECATED_REASON = """
The share export location API now support system scope and default roles.
"""
deprecated_export_location_index = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_DEFAULT
)
deprecated_export_location_show = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_DEFAULT
)
share_export_location_policies = [
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_DEFAULT,
check_str=base.SYSTEM_OR_PROJECT_READER,
scope_types=['system', 'project'],
description="Get all export locations of a given share.",
operations=[
{
'method': 'GET',
'path': '/shares/{share_id}/export_locations',
}
]),
],
deprecated_rule=deprecated_export_location_index,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_DEFAULT,
check_str=base.SYSTEM_OR_PROJECT_READER,
scope_types=['system', 'project'],
description="Get details about the requested export location.",
operations=[
{
@ -39,7 +59,11 @@ share_export_location_policies = [
'path': ('/shares/{share_id}/export_locations/'
'{export_location_id}'),
}
]),
],
deprecated_rule=deprecated_export_location_show,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
]