openstack/manila
Code Issues Proposed changes

Merge "[NetApp] Fixed share creation workflow via REST"

Browse Source
This commit is contained in:
Zuul 2024-12-06 21:52:11 +00:00 committed by Gerrit Code Review
commit 0990ddf73a
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py
View File

@ -1146,16 +1146,16 @@ class NetAppRestClient(object):
efficiency_status = self.get_volume_efficiency_status(volume_name)
# cDOT compression requires dedup to be enabled
dedup_enabled = dedup_enabled or compression_enabled
# enable/disable dedup if needed
if dedup_enabled and not efficiency_status['dedupe']:
self.enable_dedupe_async(volume_name)
elif not dedup_enabled and efficiency_status['dedupe']:
self.disable_dedupe_async(volume_name)
# enable/disable compression if needed
if compression_enabled and not efficiency_status['compression']:
self.enable_compression_async(volume_name)
elif not compression_enabled and efficiency_status['compression']:
self.disable_compression_async(volume_name)
# enable/disable dedup if needed
if dedup_enabled and not efficiency_status['dedupe']:
self.enable_dedupe_async(volume_name)
elif not dedup_enabled and efficiency_status['dedupe']:
self.disable_dedupe_async(volume_name)
self.apply_volume_efficiency_policy(
volume_name, efficiency_policy=efficiency_policy)

8
releasenotes/notes/bug-1964089-fix-share-creation-via-rest-9bb4180fc87af6c2.yaml Normal file
View File

@ -0,0 +1,8 @@
---
fixes:
- |
NetApp driver `bug #2080951
<https://bugs.launchpad.net/manila/+bug/2080951>`_:
Fixed the share creation workflow via REST.
Changed the order of dedupe/compression to disable compression first followed
by disabling dedupe so that the share creation workflow goes through.