openstack/manila
Code Issues Proposed changes

Implement secure RBAC for share networks

Browse Source 
This commit updates the policies for share networks to understand scope
checking and account for a read-only role. This is part of a broader series of
changes across OpenStack to provide a consistent RBAC experience and improve
security.

Change-Id: Ie5e87c73e97d4a464ec91db8fba1c5d3e9abfff5
This commit is contained in:
Lance Bragstad 2020-11-19 18:48:36 +00:00 committed by Goutham Pacha Ravi
parent aa298c9a8c
commit 19d182c429
1 changed files with 105 additions and 18 deletions

123
manila/policies/share_network.py

@ -10,37 +10,90 @@
# License for the specific language governing permissions and limitations
# under the License.
from oslo_log import versionutils
from oslo_policy import policy
from manila.policies import base
BASE_POLICY_NAME = 'share_network:%s'
DEPRECATED_REASON = """
The share network API now support system scope and default roles.
"""
deprecated_share_network_create = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'create',
check_str=base.RULE_DEFAULT
)
deprecated_share_network_show = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_DEFAULT
)
deprecated_share_network_index = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_DEFAULT
)
deprecated_share_network_detail = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'detail',
check_str=base.RULE_DEFAULT
)
deprecated_share_network_update = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'update',
check_str=base.RULE_DEFAULT
)
deprecated_share_network_delete = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'delete',
check_str=base.RULE_DEFAULT
)
deprecated_share_network_add_security_service = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'add_security_service',
check_str=base.RULE_DEFAULT
)
deprecated_share_network_remove_security_service = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'remove_security_service',
check_str=base.RULE_DEFAULT
)
deprecated_share_network_get_all = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'get_all_share_networks',
check_str=base.RULE_ADMIN_API
)
share_network_policies = [
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'create',
check_str=base.RULE_DEFAULT,
check_str=base.SYSTEM_ADMIN_OR_PROJECT_MEMBER,
scope_types=['system', 'project'],
description="Create share network.",
operations=[
{
'method': 'POST',
'path': '/share-networks'
}
]),
],
deprecated_rule=deprecated_share_network_create,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_DEFAULT,
check_str=base.SYSTEM_OR_PROJECT_READER,
scope_types=['system', 'project'],
description="Get details of a share network.",
operations=[
{
'method': 'GET',
'path': '/share-networks/{share_network_id}'
}
]),
],
deprecated_rule=deprecated_share_network_show,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_DEFAULT,
check_str=base.SYSTEM_OR_PROJECT_READER,
scope_types=['system', 'project'],
description="Get all share networks.",
operations=[
{
@ -51,10 +104,15 @@ share_network_policies = [
'method': 'GET',
'path': '/share-networks?{query}'
}
]),
],
deprecated_rule=deprecated_share_network_index,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'detail',
check_str=base.RULE_DEFAULT,
check_str=base.SYSTEM_OR_PROJECT_READER,
scope_types=['system', 'project'],
description="Get details of share networks .",
operations=[
{
@ -65,50 +123,75 @@ share_network_policies = [
'method': 'GET',
'path': '/share-networks/detail'
},
]),
],
deprecated_rule=deprecated_share_network_detail,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'update',
check_str=base.RULE_DEFAULT,
check_str=base.SYSTEM_ADMIN_OR_PROJECT_MEMBER,
scope_types=['system', 'project'],
description="Update a share network.",
operations=[
{
'method': 'PUT',
'path': '/share-networks/{share_network_id}'
}
]),
],
deprecated_rule=deprecated_share_network_update,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'delete',
check_str=base.RULE_DEFAULT,
check_str=base.SYSTEM_ADMIN_OR_PROJECT_MEMBER,
scope_types=['system', 'project'],
description="Delete a share network.",
operations=[
{
'method': 'DELETE',
'path': '/share-networks/{share_network_id}'
}
]),
],
deprecated_rule=deprecated_share_network_delete,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'add_security_service',
check_str=base.RULE_DEFAULT,
check_str=base.SYSTEM_ADMIN_OR_PROJECT_MEMBER,
scope_types=['system', 'project'],
description="Add security service to share network.",
operations=[
{
'method': 'POST',
'path': '/share-networks/{share_network_id}/action'
}
]),
],
deprecated_rule=deprecated_share_network_add_security_service,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'remove_security_service',
check_str=base.RULE_DEFAULT,
check_str=base.SYSTEM_ADMIN_OR_PROJECT_MEMBER,
scope_types=['system', 'project'],
description="Remove security service from share network.",
operations=[
{
'method': 'POST',
'path': '/share-networks/{share_network_id}/action'
}
]),
],
deprecated_rule=deprecated_share_network_remove_security_service,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'get_all_share_networks',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Get share networks belonging to all projects.",
operations=[
{
@ -119,7 +202,11 @@ share_network_policies = [
'method': 'GET',
'path': '/share-networks/detail?all_tenants=1'
}
]),
],
deprecated_rule=deprecated_share_network_get_all,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
]