openstack/manila
Code Issues Proposed changes

db: Migrate "backend info" APIs to enginefacade

Browse Source 
Migrate backend info-related APIs from the legacy enginefacade to the
modern context-based enginefacade.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Change-Id: Id3eef5abaa5745dfd13f902a79de97dcca4fa7fe
This commit is contained in:
Stephen Finucane 2022-09-08 11:33:00 +01:00
parent bc2078b697
commit 1d4beed95b
1 changed files with 22 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
manila/db/sqlalchemy/api.py
View File

@ -6383,50 +6383,43 @@ def cleanup_expired_messages(context):
@require_context
@context_manager.reader
def backend_info_get(context, host):
"""Get hash info for given host."""
session = get_session()
result = _backend_info_query(session, context, host)
result = _backend_info_query(context, host)
return result
@require_context
@context_manager.writer
def backend_info_create(context, host, value):
session = get_session()
with session.begin():
info_ref = models.BackendInfo()
info_ref.update({"host": host,
"info_hash": value})
info_ref.save(session)
return info_ref
info_ref = models.BackendInfo()
info_ref.update({"host": host, "info_hash": value})
info_ref.save(context.session)
return info_ref
@require_context
@context_manager.writer
def backend_info_update(context, host, value=None, delete_existing=False):
"""Remove backend info for host name."""
session = get_session()
with session.begin():
info_ref = _backend_info_query(session, context, host)
if info_ref:
if value:
info_ref.update({"info_hash": value})
elif delete_existing and info_ref['deleted'] != 1:
info_ref.update({"deleted": 1,
"deleted_at": timeutils.utcnow()})
else:
info_ref = models.BackendInfo()
info_ref.update({"host": host,
"info_hash": value})
info_ref.save(session)
return info_ref
info_ref = _backend_info_query(context, host)
if info_ref:
if value:
info_ref.update({"info_hash": value})
elif delete_existing and info_ref['deleted'] != 1:
info_ref.update({"deleted": 1, "deleted_at": timeutils.utcnow()})
else:
info_ref = models.BackendInfo()
info_ref.update({"host": host, "info_hash": value})
info_ref.save(context.session)
return info_ref
def _backend_info_query(session, context, host, read_deleted=False):
def _backend_info_query(context, host, read_deleted=False):
result = model_query(
context, models.BackendInfo, session=session,
context,
models.BackendInfo,
read_deleted=read_deleted,
).filter_by(
host=host,