From 81d29caae7c6cf5d3e3dc590130c7f77498be916 Mon Sep 17 00:00:00 2001 From: Thomas Bechtold Date: Sun, 28 Dec 2014 10:20:25 +0100 Subject: [PATCH] Remove unused sslutils module The sslutils module from olso-incubator is not used by Manila so remove it. Change-Id: Iadf05570d6cbfc3dda22c9647ee710dd8d1a580e --- manila/openstack/common/sslutils.py | 95 ----------------------------- manila/opts.py | 3 - openstack-common.conf | 1 - 3 files changed, 99 deletions(-) delete mode 100644 manila/openstack/common/sslutils.py diff --git a/manila/openstack/common/sslutils.py b/manila/openstack/common/sslutils.py deleted file mode 100644 index 47c82d3056..0000000000 --- a/manila/openstack/common/sslutils.py +++ /dev/null @@ -1,95 +0,0 @@ -# Copyright 2013 IBM Corp. -# -# Licensed under the Apache License, Version 2.0 (the "License"); you may -# not use this file except in compliance with the License. You may obtain -# a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT -# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the -# License for the specific language governing permissions and limitations -# under the License. - -import os -import ssl - -from oslo.config import cfg - -from manila.openstack.common._i18n import _ - - -ssl_opts = [ - cfg.StrOpt('ca_file', - help="CA certificate file to use to verify " - "connecting clients."), - cfg.StrOpt('cert_file', - help="Certificate file to use when starting " - "the server securely."), - cfg.StrOpt('key_file', - help="Private key file to use when starting " - "the server securely."), -] - - -CONF = cfg.CONF -CONF.register_opts(ssl_opts, "ssl") - - -def is_enabled(): - cert_file = CONF.ssl.cert_file - key_file = CONF.ssl.key_file - ca_file = CONF.ssl.ca_file - use_ssl = cert_file or key_file - - if cert_file and not os.path.exists(cert_file): - raise RuntimeError(_("Unable to find cert_file : %s") % cert_file) - - if ca_file and not os.path.exists(ca_file): - raise RuntimeError(_("Unable to find ca_file : %s") % ca_file) - - if key_file and not os.path.exists(key_file): - raise RuntimeError(_("Unable to find key_file : %s") % key_file) - - if use_ssl and (not cert_file or not key_file): - raise RuntimeError(_("When running server in SSL mode, you must " - "specify both a cert_file and key_file " - "option value in your configuration file")) - - return use_ssl - - -def wrap(sock): - ssl_kwargs = { - 'server_side': True, - 'certfile': CONF.ssl.cert_file, - 'keyfile': CONF.ssl.key_file, - 'cert_reqs': ssl.CERT_NONE, - } - - if CONF.ssl.ca_file: - ssl_kwargs['ca_certs'] = CONF.ssl.ca_file - ssl_kwargs['cert_reqs'] = ssl.CERT_REQUIRED - - return ssl.wrap_socket(sock, **ssl_kwargs) - - -_SSL_PROTOCOLS = { - "tlsv1": ssl.PROTOCOL_TLSv1, - "sslv23": ssl.PROTOCOL_SSLv23, - "sslv3": ssl.PROTOCOL_SSLv3 -} - -try: - _SSL_PROTOCOLS["sslv2"] = ssl.PROTOCOL_SSLv2 -except AttributeError: - pass - - -def validate_ssl_version(version): - key = version.lower() - try: - return _SSL_PROTOCOLS[key] - except KeyError: - raise RuntimeError(_("Invalid SSL version : %s") % version) diff --git a/manila/opts.py b/manila/opts.py index 8ecd4896f5..f3baf693ab 100644 --- a/manila/opts.py +++ b/manila/opts.py @@ -36,7 +36,6 @@ import manila.openstack.common.eventlet_backdoor import manila.openstack.common.lockutils import manila.openstack.common.log import manila.openstack.common.policy -import manila.openstack.common.sslutils import manila.quota import manila.scheduler.driver import manila.scheduler.host_manager @@ -117,8 +116,6 @@ _global_opt_lists = [ _opts = [ (None, list(itertools.chain(*_global_opt_lists))), - # ssl namespace: - ("ssl", manila.openstack.common.sslutils.ssl_opts) ] diff --git a/openstack-common.conf b/openstack-common.conf index ff3a5bb63c..0238d37172 100644 --- a/openstack-common.conf +++ b/openstack-common.conf @@ -12,7 +12,6 @@ module=scheduler module=scheduler.filters module=scheduler.weights module=service -module=sslutils module=systemd module=threadgroup