Fix the remaining review comments from SnapLock patch

This is follow-up patch to fix the few left over comment from
patch https://review.opendev.org/c/openstack/manila/+/926049

Closes-Bug: #2079967
Change-Id: I275a3680d3ea6b1b1ea69d78d4b7fecb4f61af03
This commit is contained in:
Gireesh Awasthi 2024-09-09 09:11:10 -04:00
parent 84ab5df84a
commit 2439d95993
4 changed files with 6 additions and 6 deletions

View File

@ -6476,8 +6476,8 @@ class NetAppCmodeClient(client_base.NetAppBaseClient):
api_args[na_api_attr] = options.get(share_type_attr) api_args[na_api_attr] = options.get(share_type_attr)
if all(value is None for value in api_args.values()): if all(value is None for value in api_args.values()):
LOG.debug("All SnapLock attributes are None, doesn't" LOG.debug("All SnapLock attributes are None, not"
" updated SnapLock attributes") " updating SnapLock attributes")
return return
api_args['volume'] = volume_name api_args['volume'] = volume_name

View File

@ -5581,8 +5581,8 @@ class NetAppRestClient(object):
options.get(share_type_attr)) options.get(share_type_attr))
if all(value is None for value in body.values()): if all(value is None for value in body.values()):
LOG.debug("All SnapLock attributes are None, doesn't" LOG.debug("All SnapLock attributes are None, not"
" updated SnapLock attributes") " updating SnapLock attributes")
return return
volume = self._get_volume_by_args(vol_name=volume_name) volume = self._get_volume_by_args(vol_name=volume_name)

View File

@ -3114,7 +3114,7 @@ SNAPLOCK_CLOCK_CONFIG_2 = etree.XML("""
</compliance-clock-info> </compliance-clock-info>
</snaplock-node-compliance-clock> </snaplock-node-compliance-clock>
</results>""" % { </results>""" % {
'clock_info': 'not configured' 'clock_info': 'ComplianceClock is not configured'
}) })
FAKE_XML1 = """<options>\ FAKE_XML1 = """<options>\

View File

@ -3,6 +3,6 @@ features:
- | - |
NetApp Driver: The NetApp Driver now supports the creation of WORM NetApp Driver: The NetApp Driver now supports the creation of WORM
shares using the SnapLock feature. To create these shares, set the shares using the SnapLock feature. To create these shares, set the
'netapp:snaplock_type' in the share type extra specs, along with the 'netapp_snaplock_type' in the share type extra specs, along with the
SnapLock related retention period extra specs. SnapLock related retention period extra specs.