openstack/manila
Code Issues Proposed changes

Implement secure RBAC for share instances

Browse Source 
This commit updates the policies for share instances to understand scope
checking and account for a read-only role. This is part of a broader series of
changes across OpenStack to provide a consistent RBAC experience and improve
security.

Change-Id: I1978fd95f5a9f798dd2d5a2ca011952515319746
This commit is contained in:
Lance Bragstad 2020-11-19 18:25:11 +00:00 committed by Goutham Pacha Ravi
parent 16232ce01a
commit 264636575a
1 changed files with 50 additions and 8 deletions

58
manila/policies/share_instance.py

@ -10,6 +10,7 @@
# License for the specific language governing permissions and limitations
# under the License.
from oslo_log import versionutils
from oslo_policy import policy
from manila.policies import base
@ -17,11 +18,33 @@ from manila.policies import base
BASE_POLICY_NAME = 'share_instance:%s'
DEPRECATED_REASON = """
The share instances API now supports system scope and default roles.
"""
deprecated_share_instances_index = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_ADMIN_API
)
deprecated_share_instance_show = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_ADMIN_API
)
deprecated_share_instance_force_delete = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'force_delete',
check_str=base.RULE_ADMIN_API
)
deprecated_share_instance_reset_status = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'reset_status',
check_str=base.RULE_ADMIN_API
)
shares_policies = [
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Get all share instances.",
operations=[
{
@ -32,37 +55,56 @@ shares_policies = [
'method': 'GET',
'path': '/share_instances?{query}',
}
]),
],
deprecated_rule=deprecated_share_instances_index,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Get details of a share instance.",
operations=[
{
'method': 'GET',
'path': '/share_instances/{share_instance_id}'
},
]),
],
deprecated_rule=deprecated_share_instance_show,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'force_delete',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Force delete a share instance.",
operations=[
{
'method': 'POST',
'path': '/share_instances/{share_instance_id}/action',
}
]),
],
deprecated_rule=deprecated_share_instance_force_delete,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'reset_status',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Reset share instance's status.",
operations=[
{
'method': 'POST',
'path': '/share_instances/{share_instance_id}/action',
}
]),
],
deprecated_rule=deprecated_share_instance_reset_status,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
]