openstack/manila
Code Issues Proposed changes

Implement secure RBAC for share snapshot instances

Browse Source 
This commit updates the policies for share snapshot instances to understand
scope checking and account for a read-only role. This is part of a broader
series of changes across OpenStack to provide a consistent RBAC experience and
improve security.

Change-Id: I6ec289e82d8f37ea7e832476345a3cac42662280
This commit is contained in:
Lance Bragstad 2020-11-19 20:19:41 +00:00 committed by Tom Barron
parent 217438084b
commit 3388e9aeec
1 changed files with 50 additions and 8 deletions

58
manila/policies/share_snapshot_instance.py

@ -10,6 +10,7 @@
# License for the specific language governing permissions and limitations
# under the License.
from oslo_log import versionutils
from oslo_policy import policy
from manila.policies import base
@ -17,21 +18,48 @@ from manila.policies import base
BASE_POLICY_NAME = 'share_snapshot_instance:%s'
DEPRECATED_REASON = """
The share snapshot instance API now supports system scope and default roles.
"""
deprecated_snapshot_instance_show = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_ADMIN_API
)
deprecated_snapshot_instance_index = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_ADMIN_API
)
deprecated_snapshot_instance_detail = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'detail',
check_str=base.RULE_ADMIN_API
)
deprecated_snapshot_instance_reset_status = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'reset_status',
check_str=base.RULE_ADMIN_API
)
share_snapshot_instance_policies = [
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Get share snapshot instance.",
operations=[
{
'method': 'GET',
'path': '/snapshot-instances/{snapshot_instance_id}',
}
]),
],
deprecated_rule=deprecated_snapshot_instance_show,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Get all share snapshot instances.",
operations=[
{
@ -42,10 +70,15 @@ share_snapshot_instance_policies = [
'method': 'GET',
'path': '/snapshot-instances?{query}',
},
]),
],
deprecated_rule=deprecated_snapshot_instance_index,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'detail',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Get details of share snapshot instances.",
operations=[
{
@ -56,17 +89,26 @@ share_snapshot_instance_policies = [
'method': 'GET',
'path': '/snapshot-instances/detail?{query}',
},
]),
],
deprecated_rule=deprecated_snapshot_instance_detail,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'reset_status',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Reset share snapshot instance's status.",
operations=[
{
'method': 'POST',
'path': '/snapshot-instances/{snapshot_instance_id}/action',
}
]),
],
deprecated_rule=deprecated_snapshot_instance_reset_status,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
]