openstack/manila
Code Issues Proposed changes

Trivial: Remove unused logging import

Browse Source 
In some Manila source code files, oslo log is imported but not used.
Remove it.
from oslo_log import logging
LOG = logging.getLogger(__name__)

Closes-Bug: #1529254
Change-Id: I06a98b4929e2adb5c43c754799026d4637107bd7
This commit is contained in:
houming-wang 2015-12-25 09:31:07 -05:00
parent 2cc722e125
commit 3cb2500722
16 changed files with 0 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manila/api/urlmap.py
View File

@ -19,7 +19,6 @@ try:
except ImportError: except ImportError:
from urllib2 import parse_http_list # noqa from urllib2 import parse_http_list # noqa
from oslo_log import log
import paste.urlmap import paste.urlmap
from manila.api.openstack import wsgi from manila.api.openstack import wsgi
@ -31,8 +30,6 @@ _option_header_piece_re = re.compile(
r'(?:=\s*([^;]+|%s))?\s*' % r'(?:=\s*([^;]+|%s))?\s*' %
(_quoted_string_re, _quoted_string_re)) (_quoted_string_re, _quoted_string_re))
LOG = log.getLogger(__name__)
def unquote_header_value(value): def unquote_header_value(value):
"""Unquotes a header value. """Unquotes a header value.

4
manila/api/v1/router.py
View File

@ -19,8 +19,6 @@
WSGI middleware for OpenStack Share API v1. WSGI middleware for OpenStack Share API v1.
""" """
from oslo_log import log
from manila.api import extensions from manila.api import extensions
import manila.api.openstack import manila.api.openstack
from manila.api.v1 import limits from manila.api.v1 import limits
@ -41,8 +39,6 @@ from manila.api.v2 import services
from manila.api.v2 import share_types from manila.api.v2 import share_types
from manila.api import versions from manila.api import versions
LOG = log.getLogger(__name__)
class APIRouter(manila.api.openstack.APIRouter): class APIRouter(manila.api.openstack.APIRouter):
"""Route API requests. """Route API requests.

4
manila/api/v1/scheduler_stats.py
View File

@ -12,14 +12,10 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from oslo_log import log
from manila.api.openstack import wsgi from manila.api.openstack import wsgi
from manila.api.views import scheduler_stats as scheduler_stats_views from manila.api.views import scheduler_stats as scheduler_stats_views
from manila.scheduler import rpcapi from manila.scheduler import rpcapi
LOG = log.getLogger(__name__)
class SchedulerStatsController(wsgi.Controller): class SchedulerStatsController(wsgi.Controller):
"""The Scheduler Stats API controller for the OpenStack API.""" """The Scheduler Stats API controller for the OpenStack API."""

4
manila/api/v2/router.py
View File

@ -20,8 +20,6 @@
WSGI middleware for OpenStack Share API v2. WSGI middleware for OpenStack Share API v2.
""" """
from oslo_log import log
from manila.api import extensions from manila.api import extensions
import manila.api.openstack import manila.api.openstack
from manila.api.v1 import limits from manila.api.v1 import limits
@ -45,8 +43,6 @@ from manila.api.v2 import share_types
from manila.api.v2 import shares from manila.api.v2 import shares
from manila.api import versions from manila.api import versions
LOG = log.getLogger(__name__)
class APIRouter(manila.api.openstack.APIRouter): class APIRouter(manila.api.openstack.APIRouter):
"""Route API requests. """Route API requests.

3
manila/api/v2/services.py
View File

@ -14,7 +14,6 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from oslo_log import log
import webob.exc import webob.exc
from manila.api.openstack import wsgi from manila.api.openstack import wsgi
@ -22,8 +21,6 @@ from manila.api.views import services as services_views
from manila import db from manila import db
from manila import utils from manila import utils
LOG = log.getLogger(__name__)
class ServiceMixin(object): class ServiceMixin(object):
"""The Services API controller common logic. """The Services API controller common logic.

5
manila/api/views/cgsnapshots.py
View File

@ -15,14 +15,9 @@
"""The consistency groups snapshot API.""" """The consistency groups snapshot API."""
from oslo_log import log
from manila.api import common from manila.api import common
LOG = log.getLogger(__name__)
class CGSnapshotViewBuilder(common.ViewBuilder): class CGSnapshotViewBuilder(common.ViewBuilder):
"""Model a cgsnapshot API response as a python dictionary.""" """Model a cgsnapshot API response as a python dictionary."""

5
manila/api/views/consistency_groups.py
View File

@ -15,14 +15,9 @@
"""The consistency groups API.""" """The consistency groups API."""
from oslo_log import log
from manila.api import common from manila.api import common
LOG = log.getLogger(__name__)
class CGViewBuilder(common.ViewBuilder): class CGViewBuilder(common.ViewBuilder):
"""Model a consistency group API response as a python dictionary.""" """Model a consistency group API response as a python dictionary."""

2
manila/network/neutron/neutron_network_plugin.py
View File

@ -15,7 +15,6 @@
# under the License. # under the License.
from oslo_config import cfg from oslo_config import cfg
from oslo_log import log
from manila.common import constants from manila.common import constants
from manila import exception from manila import exception
@ -41,7 +40,6 @@ neutron_single_network_plugin_opts = [
] ]
CONF = cfg.CONF CONF = cfg.CONF
LOG = log.getLogger(__name__)
class NeutronNetworkPlugin(network.NetworkBaseAPI): class NeutronNetworkPlugin(network.NetworkBaseAPI):

2
manila/share/configuration.py
View File

@ -43,10 +43,8 @@ and registered in the group in which they are used.
""" """
from oslo_config import cfg from oslo_config import cfg
from oslo_log import log
CONF = cfg.CONF CONF = cfg.CONF
LOG = log.getLogger(__name__)
class Configuration(object): class Configuration(object):

3
manila/share/drivers/emc/plugins/isilon/isilon_api.py
View File

@ -13,7 +13,6 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from oslo_log import log
from oslo_serialization import jsonutils from oslo_serialization import jsonutils
import requests import requests
import six import six
@ -21,8 +20,6 @@ import six
from manila import exception from manila import exception
from manila.i18n import _ from manila.i18n import _
LOG = log.getLogger(__name__)
class IsilonApi(object): class IsilonApi(object):

3
manila/test.py
View File

@ -31,7 +31,6 @@ from oslo_concurrency import lockutils
from oslo_config import cfg from oslo_config import cfg
from oslo_config import fixture as config_fixture from oslo_config import fixture as config_fixture
import oslo_i18n import oslo_i18n
from oslo_log import log
from oslo_messaging import conffixture as messaging_conffixture from oslo_messaging import conffixture as messaging_conffixture
import oslotest.base as base_test import oslotest.base as base_test
import six import six
@ -53,8 +52,6 @@ test_opts = [
CONF = cfg.CONF CONF = cfg.CONF
CONF.register_opts(test_opts) CONF.register_opts(test_opts)
LOG = log.getLogger(__name__)
_DB_CACHE = None _DB_CACHE = None

2
manila/tests/fake_compute.py
View File

@ -15,10 +15,8 @@
from oslo_config import cfg from oslo_config import cfg
from oslo_log import log
CONF = cfg.CONF CONF = cfg.CONF
LOG = log.getLogger(__name__)
class FakeServer(object): class FakeServer(object):

2
manila/tests/fake_network.py
View File

@ -16,10 +16,8 @@
import uuid import uuid
from oslo_config import cfg from oslo_config import cfg
from oslo_log import log
CONF = cfg.CONF CONF = cfg.CONF
LOG = log.getLogger(__name__)
class FakeNetwork(object): class FakeNetwork(object):

3
manila/tests/fake_service_instance.py
View File

@ -13,12 +13,9 @@
# under the License. # under the License.
import mock import mock
from oslo_log import log
from manila.tests import fake_compute from manila.tests import fake_compute
LOG = log.getLogger(__name__)
class FakeServiceInstanceManager(object): class FakeServiceInstanceManager(object):

2
manila/tests/fake_volume.py
View File

@ -15,10 +15,8 @@
from oslo_config import cfg from oslo_config import cfg
from oslo_log import log
CONF = cfg.CONF CONF = cfg.CONF
LOG = log.getLogger(__name__)
class FakeVolume(object): class FakeVolume(object):

3
manila/tests/share/drivers/emc/test_driver.py
View File

@ -14,7 +14,6 @@
# under the License. # under the License.
import mock import mock
from oslo_log import log
from stevedore import extension from stevedore import extension
from manila import network from manila import network
@ -23,8 +22,6 @@ from manila.share.drivers.emc import driver as emcdriver
from manila.share.drivers.emc.plugins import base from manila.share.drivers.emc.plugins import base
from manila import test from manila import test
LOG = log.getLogger(__name__)
class FakeConnection(base.StorageConnection): class FakeConnection(base.StorageConnection):
def __init__(self, logger): def __init__(self, logger):