openstack/manila
Code Issues Proposed changes

Implement secure RBAC for share servers

Browse Source 
This commit updates the policies for share servers to understand scope checking
and account for a read-only role. This is part of a broader series of changes
across OpenStack to provide a consistent RBAC experience and improve security.

Change-Id: Ib6645980a84e911431862680161b48c4ff8ea494
This commit is contained in:
Lance Bragstad 2020-11-19 20:01:22 +00:00 committed by Tom Barron
parent f7fbe9837e
commit 62119602c4
1 changed files with 149 additions and 26 deletions

175
manila/policies/share_server.py

@ -10,6 +10,7 @@
# License for the specific language governing permissions and limitations
# under the License.
from oslo_log import versionutils
from oslo_policy import policy
from manila.policies import base
@ -17,11 +18,69 @@ from manila.policies import base
BASE_POLICY_NAME = 'share_server:%s'
DEPRECATED_REASON = """
The share server API now supports system scope and default roles.
"""
deprecated_server_index = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_ADMIN_API
)
deprecated_server_show = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_ADMIN_API
)
deprecated_server_details = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'details',
check_str=base.RULE_ADMIN_API
)
deprecated_server_delete = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'delete',
check_str=base.RULE_ADMIN_API
)
deprecated_manage_server = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'manage_share_server',
check_str=base.RULE_ADMIN_API
)
deprecated_unmanage_server = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'unmanage_share_server',
check_str=base.RULE_ADMIN_API
)
deprecated_server_reset_status = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'reset_status',
check_str=base.RULE_ADMIN_API
)
deprecated_server_migration_start = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'share_server_migration_start',
check_str=base.RULE_ADMIN_API
)
deprecated_server_migration_check = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'share_server_migration_check',
check_str=base.RULE_ADMIN_API
)
deprecated_server_migration_complete = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'share_server_migration_complete',
check_str=base.RULE_ADMIN_API
)
deprecated_server_migration_cancel = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'share_server_migration_cancel',
check_str=base.RULE_ADMIN_API
)
deprecated_server_migration_get_progress = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'share_server_migration_get_progress',
check_str=base.RULE_ADMIN_API
)
deprecated_server_reset_task_state = policy.DeprecatedRule(
name=BASE_POLICY_NAME % 'share_server_reset_task_state',
check_str=base.RULE_ADMIN_API
)
share_server_policies = [
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'index',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Get share servers.",
operations=[
{
@ -32,80 +91,120 @@ share_server_policies = [
'method': 'GET',
'path': '/share-servers?{query}',
}
]),
],
deprecated_rule=deprecated_server_index,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'show',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Show share server.",
operations=[
{
'method': 'GET',
'path': '/share-servers/{server_id}',
}
]),
],
deprecated_rule=deprecated_server_show,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'details',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Get share server details.",
operations=[
{
'method': 'GET',
'path': '/share-servers/{server_id}/details',
}
]),
],
deprecated_rule=deprecated_server_details,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'delete',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Delete share server.",
operations=[
{
'method': 'DELETE',
'path': '/share-servers/{server_id}',
}
]),
],
deprecated_rule=deprecated_server_delete,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'manage_share_server',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Manage share server.",
operations=[
{
'method': 'POST',
'path': '/share-servers/manage'
}
]),
],
deprecated_rule=deprecated_manage_server,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'unmanage_share_server',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Unmanage share server.",
operations=[
{
'method': 'POST',
'path': '/share-servers/{share_server_id}/action'
}
]),
],
deprecated_rule=deprecated_unmanage_server,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'reset_status',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Reset the status of a share server.",
operations=[
{
'method': 'POST',
'path': '/share-servers/{share_server_id}/action'
}
]),
],
deprecated_rule=deprecated_server_reset_status,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'share_server_migration_start',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Migrates a share server to the specified host.",
operations=[
{
'method': 'POST',
'path': '/share-servers/{share_server_id}/action',
}
]),
],
deprecated_rule=deprecated_server_migration_start,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'share_server_migration_check',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Check if can migrates a share server to the specified "
"host.",
operations=[
@ -113,30 +212,45 @@ share_server_policies = [
'method': 'POST',
'path': '/share-servers/{share_server_id}/action',
}
]),
],
deprecated_rule=deprecated_server_migration_check,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'share_server_migration_complete',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Invokes the 2nd phase of share server migration.",
operations=[
{
'method': 'POST',
'path': '/share-servers/{share_server_id}/action',
}
]),
],
deprecated_rule=deprecated_server_migration_complete,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'share_server_migration_cancel',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Attempts to cancel share server migration.",
operations=[
{
'method': 'POST',
'path': '/share-servers/{share_server_id}/action',
}
]),
],
deprecated_rule=deprecated_server_migration_cancel,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'share_server_migration_get_progress',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_READER,
scope_types=['system'],
description=("Retrieves the share server migration progress for a "
"given share server."),
operations=[
@ -144,17 +258,26 @@ share_server_policies = [
'method': 'POST',
'path': '/share-servers/{share_server_id}/action',
}
]),
],
deprecated_rule=deprecated_server_migration_get_progress,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
policy.DocumentedRuleDefault(
name=BASE_POLICY_NAME % 'share_server_reset_task_state',
check_str=base.RULE_ADMIN_API,
check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description=("Resets task state."),
operations=[
{
'method': 'POST',
'path': '/share-servers/{share_server_id}/action',
}
]),
],
deprecated_rule=deprecated_server_reset_task_state,
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
),
]