openstack/manila
Code Issues Proposed changes

Add read-only tests for cephx access rules

Browse Source 
In the Newton cycle the ability to create read-only rules for
cephx-backed access rules was added but there were no functional tests
to exercise this feature. This patchset adds new parameters to the
existing cephx access rule test to also test read-only rules.

Change-Id: I4b4fd5790526ebc596471fd913ffe9cdb2faa520
This commit is contained in:
Dustin Schoenbrun 2017-03-29 17:33:31 -04:00
parent 38044bd968
commit 8d3dbe2e13
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
manila_tempest_tests/tests/api/test_rules.py
View File

@ -422,13 +422,15 @@ class ShareCephxRulesForCephFSTest(base.BaseSharesTest):
@tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND) @tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)
@ddt.data(*itertools.product( @ddt.data(*itertools.product(
set(['2.13', '2.27', '2.28', LATEST_MICROVERSION]), set(['2.13', '2.27', '2.28', LATEST_MICROVERSION]),
("alice", "alice_bob", "alice bob"))) ("alice", "alice_bob", "alice bob"),
('rw', 'ro')))
@ddt.unpack @ddt.unpack
def test_create_delete_cephx_rule(self, version, access_to): def test_create_delete_cephx_rule(self, version, access_to, access_level):
rule = self.shares_v2_client.create_access_rule( rule = self.shares_v2_client.create_access_rule(
self.share["id"], self.access_type, access_to, version=version) self.share["id"], self.access_type, access_to, version=version,
access_level=access_level)
self.assertEqual('rw', rule['access_level']) self.assertEqual(access_level, rule['access_level'])
for key in ('deleted', 'deleted_at', 'instance_mappings'): for key in ('deleted', 'deleted_at', 'instance_mappings'):
self.assertNotIn(key, rule.keys()) self.assertNotIn(key, rule.keys())
self.shares_v2_client.wait_for_access_rule_status( self.shares_v2_client.wait_for_access_rule_status(