openstack/manila
Code Issues Proposed changes

Replace assertEqual([], items) with assertEmpty(items)

Browse Source 
Since assertEmpty() function has already been implemented in tempest,
let's use this function instead of generic assertEqual() function.
This change makes the code and the error messages to be more readable.
Therefore it improves maintainability a little bit.

TrivialFix
Change-Id: I3d671436e9ea2f7cbdda6d3dbf5c8a3f9d7625d4
This commit is contained in:
Vu Cong Tuan 2017-06-12 15:48:27 +07:00
parent 117729f45c
commit 9863c1b93d
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manila_tempest_tests/tests/api/admin/test_share_group_types.py
View File

@ -217,7 +217,7 @@ class ShareGroupTypesTest(base.BaseSharesAdminTest):
# List projects that have access for share group type - none expected
access = self.shares_v2_client.list_access_to_share_group_type(sgt_id)
self.assertEqual([], access)
self.assertEmpty(access)
# Add project access to share group type
access = self.shares_v2_client.add_access_to_share_group_type(
@ -242,4 +242,4 @@ class ShareGroupTypesTest(base.BaseSharesAdminTest):
# List projects that have access for share group type - none expected
access = self.shares_v2_client.list_access_to_share_group_type(sgt_id)
self.assertEqual([], access)
self.assertEmpty(access)

4
manila_tempest_tests/tests/api/admin/test_share_types.py
View File

@ -160,7 +160,7 @@ class ShareTypesAdminTest(base.BaseSharesAdminTest):
# List projects that have access for share type - none expected
access = self.shares_v2_client.list_access_to_share_type(st_id)
self.assertEqual([], access)
self.assertEmpty(access)
# Add project access to share type
access = self.shares_v2_client.add_access_to_share_type(
@ -187,4 +187,4 @@ class ShareTypesAdminTest(base.BaseSharesAdminTest):
# List projects that have access for share type - none expected
access = self.shares_v2_client.list_access_to_share_type(st_id)
self.assertEqual([], access)
self.assertEmpty(access)