openstack/manila
Code Issues Proposed changes

Fix using anyjson in fake_notifier

Browse Source 
For some reason we were using anyjson.serialize() in our fake_notifier.
That may have been to mirror kombu, but really we need to mirror
what we do when we convert our payloads to primitives, which is using
jsonutils.
anyjson is then no longer needed as a requirement.

Change-Id: I7f1bb8e0f6eecde37a0c9ac16ca84d0629e843b2
This commit is contained in:
Thomas Bechtold 2014-12-28 18:16:39 +01:00
parent d934530b80
commit a26022e62b
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manila/tests/fake_notifier.py
View File

@ -15,8 +15,8 @@
import collections import collections
import functools import functools
import anyjson
from oslo import messaging from oslo import messaging
from oslo.serialization import jsonutils
from manila import rpc from manila import rpc
@ -53,7 +53,7 @@ class FakeNotifier(object):
# NOTE(sileht): simulate the kombu serializer # NOTE(sileht): simulate the kombu serializer
# this permit to raise an exception if something have not # this permit to raise an exception if something have not
# been serialized correctly # been serialized correctly
anyjson.serialize(payload) jsonutils.to_primitive(payload)
msg = dict(publisher_id=self.publisher_id, msg = dict(publisher_id=self.publisher_id,
priority=priority, priority=priority,
event_type=event_type, event_type=event_type,

1
requirements.txt
View File

@ -6,7 +6,6 @@
pbr>=0.6,!=0.7,<1.0 pbr>=0.6,!=0.7,<1.0
alembic>=0.7.1 alembic>=0.7.1
anyjson>=0.3.3
Babel>=1.3 Babel>=1.3
eventlet>=0.15.2 eventlet>=0.15.2
greenlet>=0.3.2 greenlet>=0.3.2