From c341e52b5e34930dd64af43249504fb7b8413aae Mon Sep 17 00:00:00 2001 From: Peter Wang <peter.wang13@emc.com> Date: Thu, 29 Dec 2016 00:46:37 +0800 Subject: [PATCH] Report create_share_from_snapshot_support Set create_share_from_snapshot_support as True in order to be able to create share from snapshot. This fixes all Dell EMC drivers issue like below: Share cannot be created from snapshot Change-Id: If43d9b15b21a2ae74c6872726e9e537501697405 Closes-Bug: #1652911 --- manila/share/drivers/dell_emc/driver.py | 4 +++- manila/tests/share/drivers/dell_emc/test_driver.py | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/manila/share/drivers/dell_emc/driver.py b/manila/share/drivers/dell_emc/driver.py index 9568eaf4c3..5d08f266cd 100644 --- a/manila/share/drivers/dell_emc/driver.py +++ b/manila/share/drivers/dell_emc/driver.py @@ -140,7 +140,9 @@ class EMCShareDriver(driver.ShareDriver): data = dict( share_backend_name=backend_name, vendor_name='Dell EMC', - storage_protocol='NFS_CIFS') + storage_protocol='NFS_CIFS', + snapshot_support=True, + create_share_from_snapshot_support=True) self.plugin.update_share_stats(data) super(EMCShareDriver, self)._update_share_stats(data) diff --git a/manila/tests/share/drivers/dell_emc/test_driver.py b/manila/tests/share/drivers/dell_emc/test_driver.py index 360f241d04..6e874664aa 100644 --- a/manila/tests/share/drivers/dell_emc/test_driver.py +++ b/manila/tests/share/drivers/dell_emc/test_driver.py @@ -128,6 +128,8 @@ class EMCShareFrameworkTestCase(test.TestCase): data['replication_domain'] = None data['filter_function'] = None data['goodness_function'] = None + data['snapshot_support'] = True + data['create_share_from_snapshot_support'] = True self.assertEqual(data, self.driver._stats) def _fake_safe_get(self, value):