Merge "Implement secure RBAC for share replica locations"

manila/policies/share_replica_export_location.py

@@ -10,6 +10,7 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
+from oslo_log import versionutils
 from oslo_policy import policy
 
 from manila.policies import base
@@ -17,21 +18,41 @@ from manila.policies import base
 
 BASE_POLICY_NAME = 'share_replica_export_location:%s'
 
+DEPRECATED_REASON = """
+The share replica export location API now supports system scope and default
+roles.
+"""
+
+deprecated_replica_location_index = policy.DeprecatedRule(
+    name=BASE_POLICY_NAME % 'index',
+    check_str=base.RULE_DEFAULT
+)
+deprecated_replica_location_show = policy.DeprecatedRule(
+    name=BASE_POLICY_NAME % 'show',
+    check_str=base.RULE_DEFAULT
+)
+
 
 share_replica_export_location_policies = [
     policy.DocumentedRuleDefault(
         name=BASE_POLICY_NAME % 'index',
-        check_str=base.RULE_DEFAULT,
+        check_str=base.SYSTEM_OR_PROJECT_READER,
+        scope_types=['system', 'project'],
         description="Get all export locations of a given share replica.",
         operations=[
             {
                 'method': 'GET',
                 'path': '/share-replicas/{share_replica_id}/export-locations',
             }
-        ]),
+        ],
+        deprecated_rule=deprecated_replica_location_index,
+        deprecated_reason=DEPRECATED_REASON,
+        deprecated_since=versionutils.deprecated.WALLABY
+    ),
     policy.DocumentedRuleDefault(
         name=BASE_POLICY_NAME % 'show',
-        check_str=base.RULE_DEFAULT,
+        check_str=base.SYSTEM_OR_PROJECT_READER,
+        scope_types=['system', 'project'],
         description="Get details about the requested share replica export "
                     "location.",
         operations=[
@@ -40,7 +61,11 @@ share_replica_export_location_policies = [
                 'path': ('/share-replicas/{share_replica_id}/export-locations/'
                          '{export_location_id}'),
             }
-        ]),
+        ],
+        deprecated_rule=deprecated_replica_location_show,
+        deprecated_reason=DEPRECATED_REASON,
+        deprecated_since=versionutils.deprecated.WALLABY
+    ),
 ]