openstack/manila
Code Issues Proposed changes

Fix race condition in tempest test

Browse Source 
Test "test_create_get_delete_share" located in
"manila_tempest_tests/tests/api/test_shares.py" assumes
that share is created not so fast and has "creating" status.
But it can be "available" in case of really fast creation
as in case of "dummy" driver.

Change-Id: Ie8a01e9352da47ff6e47ad8baeb5409282d3305c
Closes-Bug: #1607723
This commit is contained in:
Valeriy Ponomaryov 2016-07-29 13:20:08 +03:00
parent 20adb836c3
commit d5e8b8d9e8
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
manila_tempest_tests/tests/api/test_shares.py
View File

@ -57,8 +57,10 @@ class SharesNFSTest(base.BaseSharesTest):
self.assertFalse(share['is_public']) self.assertFalse(share['is_public'])
# The 'status' of the share returned by the create API must be # The 'status' of the share returned by the create API must be
# the default value - 'creating'. # set and have value either 'creating' or
self.assertEqual('creating', share['status']) # 'available' (if share creation is really fast as in
# case of Dummy driver).
self.assertIn(share['status'], ('creating', 'available'))
# Get share using v 2.1 - we expect key 'snapshot_support' to be absent # Get share using v 2.1 - we expect key 'snapshot_support' to be absent
share_get = self.shares_v2_client.get_share(share['id'], version='2.1') share_get = self.shares_v2_client.get_share(share['id'], version='2.1')
@ -178,8 +180,10 @@ class SharesNFSTest(base.BaseSharesTest):
self.protocol, snapshot_id=snap["id"], cleanup_in_class=False) self.protocol, snapshot_id=snap["id"], cleanup_in_class=False)
# The 'status' of the share returned by the create API must be # The 'status' of the share returned by the create API must be
# the default value - 'creating'. # set and have value either 'creating' or
self.assertEqual('creating', child['status']) # 'available' (if share creation is really fast as in
# case of Dummy driver).
self.assertIn(child['status'], ('creating', 'available'))
# verify share, created from snapshot # verify share, created from snapshot
get = self.shares_client.get_share(child["id"]) get = self.shares_client.get_share(child["id"])