openstack/manila
Code Issues Proposed changes

Fix doc build if git is absent

Browse Source 
When building packages if git is absent, then we should not set
html_last_updated_fmt. It can still be set via the -D switch
when building with sphinx-build.

Change-Id: I02a6bcb43c8283848fb3866bb52cc4c0f50f4c92
Closes-Bug: #1552251
This commit is contained in:
Thomas Bechtold 2016-04-13 09:00:12 +02:00
parent a44c8c3f6f
commit fd9b5c0435
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
doc/source/conf.py
View File

@ -15,6 +15,7 @@
import subprocess
import sys
import os
import warnings
# If extensions (or modules to document with autodoc) are in another directory,
# add these directories to sys.path here. If the directory is relative to the
@ -171,8 +172,12 @@ html_theme_options = {}
git_cmd = [
"git", "log", "--pretty=format:'%ad, commit %h'", "--date=local", "-n1"
]
html_last_updated_fmt = subprocess.Popen(
git_cmd, stdout=subprocess.PIPE).communicate()[0]
try:
html_last_updated_fmt = subprocess.Popen(
git_cmd, stdout=subprocess.PIPE).communicate()[0]
except Exception:
warnings.warn('Cannot get last updated time from git repository. '
'Not setting "html_last_updated_fmt".')
# If true, SmartyPants will be used to convert quotes and dashes to
# typographically correct entities.