3157 Commits

Author SHA1 Message Date
Alexey Ovchinnikov
332cbf253a Fix check for nfsd presence
Check for nfsd has been implemented incorrectly and has
apparently checked nothing. This change fixes that.

Change-Id: I2cc735744fcb588e9945e34de4cd4cc2270078f8
Closes-Bug: 1616061
2016-09-23 16:24:49 +03:00
Jenkins
4b77503863 Merge "3PAR driver fails to validate conf share server IPs" 2016-09-23 02:55:08 +00:00
zengyingzhe
f20ab15beb Fix huawei driver cannot delete qos while status is idle
Currently, there are 3 statuses for qos:
  - 'active', 'inactivated' and 'idle'

If qos status is 'idle', the qos deletion will fail because
huawei driver doesn't deactivate it before deleting.

This change fixes this bug by deactivating qos first if qos
status is not 'inactivated'.

Change-Id: I40f937c22d77d8e07fba176bdc09ca461f01733a
Closes-Bug: #1625424
2016-09-22 11:35:55 +00:00
Jenkins
1238c79f24 Merge "Add tempest tests for mtu and gateway fields" 2016-09-22 11:01:34 +00:00
Alexey Ovchinnikov
49856dc9c8 Bring remote and local executors into accord
It appears that remote executor (processutils.ssh_execute)
and local executor (processutils.execute) have different
expectations for command keywords containing spaces. This
difference manifests itself in helper failures either for
one executor type or for another. This change adds command
preprocessing to generic driver which seems to be the only
active user of both remote executor and failing helpers.

Change-Id: I26eaca3ca652171fbf20d7580f90eef4f935332e
Closes-Bug: 1621033
2016-09-22 09:18:35 +03:00
Jenkins
da04d7bcf1 Merge "Make port_binding_extension mandatory if host_id is specified" 2016-09-21 16:30:54 +00:00
Jenkins
6868d8a8c5 Merge "[api-ref] Refactor Manila quota set API" 2016-09-21 15:21:27 +00:00
Marc Koderer
f60a0683bc Add tempest tests for mtu and gateway fields
This adds a cross check whether the neutron values
are matching the manila db/api value.

Change-Id: I096579704e217a91431dc5201a60beb43e015417
Closes-bug: #1612528
2016-09-21 16:35:05 +02:00
Jenkins
d7befa90cc Merge "Make nfs-kernel-server run on a clean host" 2016-09-21 14:21:50 +00:00
Marc Koderer
e0080bff62 Make port_binding_extension mandatory if host_id is specified
In case create_port is called with host_id it's better to fail if
port_binding_extension is not available. Otherwise there won't
be any binding and no logging that the port will be inactive.

Change-Id: I65595308bc71ae78c992fd97e3f26fd718b249ec
Closes-bug: #1602525
2016-09-21 14:54:51 +02:00
Ha Van Tu
02a0cb8b3e [api-ref] Refactor Manila quota set API
This patch refactors Manila quota set API to make it be readable
and maintainable.

Change-Id: I0a275b3ab4dc8e7ba5675562599bd853f03fa30e
2016-09-21 11:04:59 +00:00
Nguyen Phuong An
583aea4949 [api-ref] Remove temporary block in conf.py
The os-api-ref 1.0.0 is out. We can remove the support to older version
now.

Change-Id: I9974796c2e2ccab5d2f4f651d082632de040f3c4
Reference: Ia6245d502fde38cd4d63aa4a786b6296b22a37a1
2016-09-21 08:26:31 +00:00
Alexey Ovchinnikov
a2ce6c0aa3 Make nfs-kernel-server run on a clean host
nfsd refuses to start on a host with empty /etc/exports. This
change adds a workaround for affected first-party drivers.

Change-Id: If62fdc4219ceb02455bc55c717b7f2c7f34b0dca
Closes-Bug: 1616061
2016-09-21 11:26:28 +03:00
Jenkins
cbb58baada Merge "delete python bytecode including pyo before every test run" 2016-09-20 15:12:23 +00:00
Jenkins
570f498281 Merge "Updated from global requirements" 2016-09-20 10:05:50 +00:00
Jenkins
2e44248d1f Merge "[api-ref] Refactor limits and services API" 2016-09-20 09:19:05 +00:00
Jenkins
71266b2f64 Merge "[api-ref] Refactor manila extension API" 2016-09-20 09:17:42 +00:00
Jenkins
5c3e6a8099 Merge "[api-ref] Refactor consistency group API" 2016-09-20 09:17:36 +00:00
Jenkins
b4ff5fe27d Merge "Update reno for stable/newton" 2016-09-20 08:22:16 +00:00
Bin Zhou
b6fa89bae3 Modify use of assertTrue(A in B)
Developers should use assertIn(A, B) instead of assertTrue(A in B ).

TrivialFix

Change-Id: Icb1f58f462f982d9c4b0795d1a7f010b08c9b387
2016-09-20 09:11:20 +08:00
OpenStack Proposal Bot
be82d59280 Updated from global requirements
Change-Id: Ica7a006e2203c3f004bf2718f800790e3f441b22
2016-09-20 00:26:30 +00:00
Jay Mehta
cef6dddcee 3PAR driver fails to validate conf share server IPs
With 3PAR, share server(VFS) can have up to 4 IP addresses.
During bootup, driver queries 3PAR to get list of all IP addresses
and validates it against IP addresses provided in manila.conf. If
there is a mismatch, driver throws exception.

The bug was with 3PAR file client which always returns only one IP
address. To make driver backward compatible with 3PAR client,
mediator.py formats the value retured by client and passes it to
driver.py. This patch now correctly accepts all the IP addresses
as obtained from 3PAR and validates configured IPs against it.

Also removing unused function.

Updated and added new unit tests

Added release notes

Closes-Bug: #1621016

Change-Id: I1eeb18cc9905a71cd38c383bc0ab49e0a560ffc9
2016-09-19 15:10:22 -07:00
Goutham Pacha Ravi
bc4712e35e Manila install guide: Fix wrong instructions
Previously only the DHSS=True mode was documented
in post install steps. The assumption that the generic driver
was being configured existed in other places as well.

* add DHSS=False documentation as necessary with the
   LVM driver.
* correct assumptions in other places to clarify usage
   of appropriate share driver modes.

Change-Id: Ic1356453e510e8f360269fb45a41379329ce68c2
Closes-Bug: #1616257
2016-09-16 17:35:43 +00:00
Lucky samadhiya
d82ac34d0a delete python bytecode including pyo before every test run
Change-Id: Ib1cee0ee3d482b23bbaa19956a10bb2e8fc7d559
2016-09-16 13:57:08 +05:30
Jenkins
16c522bf5e Merge "Update installation tutorial and api-ref instructions" 2016-09-16 00:23:47 +00:00
Goutham Pacha Ravi
d2f1d289e9 Update installation tutorial and api-ref instructions
This documentation has been brought in-tree in Newton.

TrivialFix

Change-Id: I943b55b22d23a1b84a886746852165656c5aa01e
2016-09-15 14:09:04 +00:00
Doug Hellmann
3d39c901a0 Update reno for stable/newton
Change-Id: I22edc0930670ec615461d0f78554dbfdfe0d1d8e
2016-09-15 08:55:22 -04:00
Ha Van Tu
5e6eef7a60 [api-ref] Refactor limits and services API
This patch refactors limits and services API to make it clear to
understand and maintain.

Change-Id: I0e214f59e193f861e4959dfef951854bea530b7b
2016-09-15 11:02:08 +07:00
Ha Van Tu
0dc2fdc1da [api-ref] Refactor manila extension API
This patch refactors manila extension API to make it clear
to understand and maintain.

Change-Id: I35b8b135acc02238daf7c2fb9f42bf276806f7d8
2016-09-15 11:01:45 +07:00
Ha Van Tu
8eaf23982c [api-ref] Refactor consistency group API
This patch refactors consistency group API to make it clear to
understand and maintain.

Change-Id: I5b48f354cb32d2606e6eaf2c01c49a333921ff4f
2016-09-15 11:00:49 +07:00
Jenkins
8f2fa31d8a Merge "Fix allow/deny error message and race in migration" 2016-09-14 21:13:27 +00:00
Jenkins
4d54f96f96 Merge "Improve Share Migration tempest tests" 2016-09-14 21:08:11 +00:00
Jenkins
0475c15703 Merge "[ZFSonLinux] Fix share migration using remote host" 2016-09-14 20:55:09 +00:00
Jenkins
ab7f29aa6a Merge "Add cleanup to create from snap in Manila HNAS driver" 2016-09-14 20:02:16 +00:00
Jenkins
fdd8cd808a Merge "Fix access rules for managed shares in HSP driver" 2016-09-14 19:56:41 +00:00
Alyson Rosa
9d6823b3ea Add cleanup to create from snap in Manila HNAS driver
Adding a cleanup to method create_from_snapshot in case
of a failure.

Also, raising the correct exception on backend layer in
case of a failure when exporting shares.

Change-Id: I86d2c3c5ff5a790868f8362e065df1eb2be8a3ad
Closes-Bug: #1613721
2016-09-14 13:38:49 -03:00
Jenkins
a97983dd0e Merge "Put all imports from manila.i18n in one line" 2016-09-14 15:04:07 +00:00
Jenkins
79a345f9d6 Merge "huawei driver default create thin type share" 2016-09-14 13:46:21 +00:00
Valeriy Ponomaryov
eaf153d1ad [ZFSonLinux] Fix share migration using remote host
For the moment, share migration works only when manila-share and
ZFS storage are located on the same host. So, fix it adding SSH
command to migration command.

Change-Id: I25f211de6a278c6f303ef3f33ff30f504146a0fa
Closes-Bug: #1623379
2016-09-14 15:31:11 +03:00
zzxwill
fb44a0a49e Put all imports from manila.i18n in one line
Put '_', '_LW', '_LI', '_LE' from manila.i18n in one line
to make it beautify. Nova, neutron and many other projects
follow this rule. Like
bc5035343d/nova/virt/disk/mount/nbd.py
ee42af1011/neutron/cmd/ipset_cleanup.py
(added more files)

Change-Id: If7ed442ebe946b32b3234ce37b38ee3a5ccbcb39
2016-09-14 06:07:33 +00:00
Alyson Rosa
b29a0e553f Fix access rules for managed shares in HSP driver
A share managed in HSP could have some access rules that
are not in Manila. Trying to add a rule that already exists
in backend results in an error. Also, rules in backend that
names are not "share_id + ip" can't be deleted.
Additionally, if this share has a rule only in backend and not in
Manila, trying to delete it would fail, because HSP doesn't allow
delete share when it still has rules.

Fix it by adding a check in update access when rules already
exist in backend. Check for access rule name in backend when
denying access. And cleaning all rules from backend before
deleting a share to ensure that it has no children in HSP.

Change-Id: I0c8ee5c47efe22f004692022dd952f301d669b06
Closes-Bug: #1620756
2016-09-13 21:09:33 -03:00
Jenkins
3f922aab6e Merge "glusterfs: handle new cli XML format" 2016-09-13 20:46:53 +00:00
Jenkins
3eb24b54c6 Merge "Fix for LV mounting issue in docker containers" 2016-09-13 17:19:31 +00:00
Jenkins
2559043bf9 Merge "Fix flaky Neutron port binding unit tests" 2016-09-13 16:55:20 +00:00
Rodrigo Barbieri
053acc8db1 Improve Share Migration tempest tests
Improve coverage by adding tests that validate the share-type
change while also changing the driver mode.

Closes-bug: #1620800

Change-Id: I924c34aa69591754b437d75f43db91d77e73fb07
2016-09-13 13:17:07 -03:00
Rodrigo Barbieri
10487a14a3 Fix allow/deny error message and race in migration
Share migration code [1] merged in newton intending to allow admins
to mount the share between phase1 and phase2, but API code for
allow_access and deny_access was set incorrectly, blocking it.

After discussing this feature's purpose further, we decided we do
not want this feature at this moment, so we are just fixing the
allow_access and deny_access error messages.

Also, addressed a small case of concurrency that was happening
once in a while in CI. Update_access was being invoked while
other rules were being applied, thus setting the access_rule_state
to "UPDATING_MULTIPLE", ignoring the migration access rule change
RPC request completely, failing migration. By refreshing the
model we are able to assign the proper access_rule_state at the
time the function is invoked, setting the access_rule_state
correctly.

[1] If4bfaf7e9d963b83c13a6fea241c2eda14f7f409

APIImpact

Closes-bug: #1623051
Closes-bug: #1623052

Change-Id: I76a7d8c3bdd597b951e700350f8f3f82bfb21e03
2016-09-13 13:09:17 -03:00
Jenkins
e7d27ffc02 Merge "[docs] Update dev docs for ZFSonLinux share driver" 2016-09-13 14:30:49 +00:00
Jenkins
8c5882d859 Merge "Fix useless statements in unit tests" 2016-09-13 14:29:52 +00:00
Alexey Ovchinnikov
0a40a64224 Fix for LV mounting issue in docker containers
Docker containers were previously started with insufficient
privileges to successfully mount a LV created on host.
This change fixes this problem.

Closes-Bug: 1613675
Change-Id: I63f3480ace3be70100a245570d7f3579b333e972
2016-09-13 17:18:03 +03:00
Clinton Knight
f240f77b58 Fix flaky Neutron port binding unit tests
A couple unit tests were attempting to test a wrapped method,
and the tests failed randomly. It is straightforward, and preferable,
to test the code with the decorator as it is called during normal
operation.

Change-Id: If0b92adcf974b4509424912f5fde1cf26ebfaf48
Closes-bug: #1622998
2016-09-13 09:25:16 -04:00