3301 Commits

Author SHA1 Message Date
Li Wei
f8b962b9c8 Correct the order of parameters in assertEqual()
The order of parameters should be assertEqual(expected, actual).

Change-Id: I0815b1d76fd1f8a90ad3d5f08d70fc5cc4e5d7b7
2016-11-04 15:40:21 +08:00
Li Wei
ed59f6bd1a Use cors.set_defaults instead of cfg.set_defaults
Cors has been added setdefaults method, just use it.
Related link:
https://review.openstack.org/#/c/285368/

Change-Id: I26e1ecdf4a92ab55eeb794a0df7ba6a323f9141a
2016-11-04 14:48:51 +08:00
Rodrigo Barbieri
3f6fb58810 Fix missing 'migration_completing' task state
For driver-assisted migration, 'migration_completing' task state
was not being set when accepting migration-complete requests.

APIImpact

Change-Id: Ie0ccd587232a4a8007c45d855f0f575a30b881b2
Closes-bug: #1638896
2016-11-03 10:14:16 -02:00
howardlee
4c3d247192 Replace 'assertEqual(None, ...)' with 'assertIsNone(...)'
[H203] Use assertIs(Not)None to check for None (off by default) Unit
test assertions tend to give better messages for more specific
assertions. As a result, assertIsNone(...) is preferred over
assertEqual(None, ...) and assertIs(None, ...), and assertIsNotNone(...)
is preferred over assertNotEqual(None, ...) and assertIsNot(None,
...). Off by default.

TrivialFix

Change-Id: Ib635a7f73c9ab86ca6ca322542b19e7889486070
2016-11-03 16:45:23 +08:00
zengyingzhe
3f2800ede5 Compare the encoded tag more accurately for huawei driver
huawei driver uses a tag '!$$$' to indicate if username/password
is encoded or not in huawei configuration file.

Currently 'find' method is used to check if this tag is included
in the configuration string, but it'll misread if the tag is
included not in front of the string.

So change the comparing statement to a more accurate way, compare
the front slice of the string directly to the tag.

Change-Id: Ic343970578477362460340b01e5766e03c7d63a4
Closes-Bug: 1635073
2016-11-03 02:34:39 +00:00
OpenStack Proposal Bot
08285a764d Updated from global requirements
Change-Id: Idd8b0051f1b4f0543a5b7f8f54d24b5e0e25e199
2016-11-02 21:54:33 +00:00
Jenkins
ef91e54df4 Merge "[Tempest] Fix visibility of test_quotas.py module" 2016-11-02 20:02:18 +00:00
Valeriy Ponomaryov
11b38f3188 Add support of endpoint_type and region_name to clients manila uses
Since change [1] it is impossible to set endpoint_type and region_name
for nova, cinder and neutron clients that are used by manila in some
cases.
So, to fix it, add additional options called 'endpoint_type' and
'region_name' for each of config groups related to these clients.
These options can be defined in appropriate config group as following:

[nova]
endpoint_type = publicURL
region_name = SomeRegionName

[cinder]
endpoint_type = internalURL
region_name = SomeRegionName

[neutron]
endpoint_type = adminURL
region_name = SomeRegionName

[1] Ic211a11308a3295409467efd88bff413482ee58d

Change-Id: I6be0e77bbc0e4b1e9905eba7a7b48ff540e9e377
Closes-Bug: #1633454
2016-11-02 18:14:04 +02:00
OpenStack Proposal Bot
b442ee349a Updated from global requirements
Change-Id: I8b2078292034d425e5c022df4220c63d0d2c339a
2016-11-02 03:35:06 +00:00
Jenkins
6d7b758f5a Merge "Clarify language in release notes" 2016-11-01 15:37:13 +00:00
Jenkins
2ac0077041 Merge "Remove broken modindex link from devref" 2016-11-01 15:37:06 +00:00
Jenkins
6cd83cd148 Merge "Fix concurrency issues in container driver" 2016-11-01 15:00:32 +00:00
Jenkins
63423ec0f7 Merge "Fix a typo" 2016-11-01 13:38:21 +00:00
Valeriy Ponomaryov
4475a5ca00 [Tempest] Fix visibility of test_quotas.py module
Commit [1] added wrong decorator to test class located in
"manila_tempest_tests/tests/api/test_quotas.py" module that
made it invisible for tempest.

It should be "ddt.ddt" instead of "ddt.data" as it is now.

Also, fix negative quota tests that were testing wrong thing.
It should have been testing "quota-sets" and "os-quota-sets", not
"services" and "os-services" as it is now.

[1] I82f00114db985b4b3bf4db0a64191559508ac600

Change-Id: Ie0eb7d32b7b032ffdb7f7dd47f68841211e7d7a6
Closes-Bug: #1635588
2016-11-01 13:17:20 +02:00
Jenkins
5d8257cabd Merge "Remove warnings for dropped context arguments" 2016-11-01 11:17:03 +00:00
zengyingzhe
90f6b6cc86 Fix a typo
TrivialFix

Change-Id: Ie8a4f21c902f5081823c28c5eb4b8cc975a3397c
2016-11-01 11:20:39 +08:00
Jenkins
78e500c52b Merge "NetApp cDOT driver enhanced support logging" 2016-10-31 18:56:36 +00:00
Goutham Pacha Ravi
cdb1422fe1 Remove broken modindex link from devref
It was pointed out by the Docs team that we have
one unresolved link [1] in our devref.

Let's torch it with fire.

[1] http://lists.openstack.org/pipermail/openstack-docs/2016-October/009274.html

TrivialFix

Change-Id: Ie73890c8d6db816d8ddd582f1bcefc5cddab21d8
2016-10-30 17:30:59 -04:00
Goutham Pacha Ravi
0b5125d285 Clarify language in release notes
The end results aren't entirely pretty:
http://docs.openstack.org/releasenotes/manila/newton.html

Having these instructions may help developers and reviewers.

Change-Id: Ibfe6a0850cff72968d2917f0ceae0e70afa21625
2016-10-28 06:22:31 +00:00
OpenStack Proposal Bot
68cb027873 Updated from global requirements
Change-Id: Ida1ac4b9102c2032d6c44e50897f869674ede2d6
2016-10-27 12:15:27 +00:00
Arne Wiebalck
38c1eaede5 Remove warnings for dropped context arguments
This patch removes the warning messages for dropped arguments upon
context setup. They are of limited use and dropping them should
increase the readability of the logs.

Change-Id: I8003dd576a575be4d87e69ef5459009eeb15fabe
Closes-Bug: #1607444
2016-10-26 22:52:36 +02:00
Clinton Knight
04686f2d18 NetApp cDOT driver enhanced support logging
The NetApp cDOT driver logs some info about OpenStack deployments
already, and more info is needed about the specific storage
resources managed by Manila.

Implements: blueprint netapp-cdot-enhanced-support-logging
Change-Id: I8e4f81b3f1291e3c88fc88ab71ac93a415990ee3
2016-10-25 10:10:30 +00:00
Jenkins
44ce1d4d29 Merge "Fix a typo in parameters.yaml" 2016-10-24 07:31:16 +00:00
zhongjun2
1370902302 Add utility of boolean value parser
We parse the boolean value from string in dict with identical
logic in different areas, it's reasonable to add an util function
to cover this.

Change-Id: Id54029e2e4a0dd2f2093e6ef2583a9cada84c540
2016-10-21 17:47:11 +08:00
Jenkins
ebc7f0541c Merge "Remove unused functions in utils" 2016-10-21 05:49:42 +00:00
Alexey Ovchinnikov
a915b75d00 Fix concurrency issues in container driver
Previously container driver failed in concurrent environments
deleting shares and share servers.
Fix it by adding shared external lock.

Change-Id: I543fd1226b3d99e06c736f4d925991d0bda7ea6d
Closes-Bug: 1613676
2016-10-20 14:52:50 +03:00
OpenStack Proposal Bot
b9b3b96249 Updated from global requirements
Change-Id: If586508e8753144ee9c83eb7ca7824acf98fd6d2
2016-10-19 17:39:37 +00:00
Jenkins
45c2640e7f Merge "[Grenade] Update devstack and pre_test_hook" 2016-10-19 17:24:31 +00:00
Jenkins
1cd59f2461 Merge "Fix huawei driver username/password encoding bug" 2016-10-19 12:45:46 +00:00
ChangBo Guo(gcb)
6dccb17ace Remove unused functions in utils
Change-Id: I83057f5bcb61c566407f11c6f5304de05455a563
2016-10-19 20:45:34 +08:00
pawnesh.kumar
10429b2724 Update .coveragerc after the removal of openstack directory
The openstack directory was used to keep codes from oslo-incubator,
we have retired oslo-incubator,so don't use this directory any more.

Change-Id: I1e6d93e1bb91f4d82c4538b680141f51b8ddff27
2016-10-17 19:49:12 +05:30
Valeriy Ponomaryov
5be1e8f3d3 [Grenade] Update devstack and pre_test_hook
Make devstack grenade code use 'newton' as base branch for migration to
master (ocata).
After switch [1] to dummy driver we need to override defaults.
So, update pre_test_hook approach for saving configuration data properly.

[1] I2b698f69a29ef983b13534b2f4d393570be4dac8

Change-Id: Ie5fa0f78b0e3caa06d34a0822a8ed60b69406f9d
Closes-Bug: #1631412
2016-10-17 13:42:26 +03:00
melissaml
319f016fde Fix a typo in parameters.yaml
Removed redundant 'is'.

TrivialFix

Change-Id: Iae1e3c1914a0439b93db62e8c86e25c8b3980c15
2016-10-14 22:16:11 +08:00
Jenkins
34a1879e6b Merge "NetApp cDOT driver should not report untenable pools" 2016-10-13 17:17:05 +00:00
Jenkins
6fe0ef4355 Merge "updated positional argument and output" 2016-10-13 15:32:29 +00:00
Jenkins
8d7e1fc6e2 Merge "Updated from global requirements" 2016-10-13 14:52:17 +00:00
Jenkins
8315a9761c Merge "Fix a typo in api_version_request.py" 2016-10-13 13:44:33 +00:00
npraveen35
65ccdc2f5c updated positional argument and output
Closes-Bug: #1625261

Change-Id: If1cb20211e928150e23dc43567ce0271a03adcd9
2016-10-13 12:42:09 +00:00
Jenkins
44c186bc70 Merge "Use assert(Not)In/Greater(Equal)/LessEqual/IsNotNone" 2016-10-13 10:33:53 +00:00
melissaml
2ddb2f6f19 Fix a typo in api_version_request.py
Removed redundant 'the'.

TrivialFix

Change-Id: Ie2b966302f873488d6e2cadbf6bcc6bc8a2c6f0d
2016-10-13 16:12:33 +08:00
OpenStack Proposal Bot
a9c9584327 Updated from global requirements
Change-Id: Idb078f6b413c6484f6ebfcfcb48f3dba2757215f
2016-10-12 22:47:43 +00:00
Jenkins
c64115e9a6 Merge "Manila install guide: Fix wrong instructions" 2016-10-12 20:17:19 +00:00
Clinton Knight
eb2d9640e2 NetApp cDOT driver should not report untenable pools
The NetApp cDOT driver now explicitly filters root aggregates
from the pools reported to the manila scheduler if the driver
is operating with cluster credentials.

Change-Id: I659edada559e50d2332790025c65fae265a27c3d
Closes-Bug: #1624526
2016-10-12 18:58:11 +00:00
Jenkins
5faab23a36 Merge "Avoid Forcing the Translation of Translatable Variables" 2016-10-11 16:24:43 +00:00
Jenkins
75c9aaf50d Merge "Enable release notes translation" 2016-10-11 11:51:52 +00:00
Jenkins
a47950d006 Merge "[Container] Fix deletion of veths" 2016-10-10 15:25:43 +00:00
Jenkins
b50d63110f Merge "Modify use of assertTrue(A in B)" 2016-10-10 13:38:23 +00:00
Ha Van Tu
b09faaf43e [api-ref] Refactor Manila snapshot API
This patch makes the Manila snapshot API reference more readable
and maintainable.

Change-Id: If34bfb99852bcca61b65edc14ec98c859e995344
2016-10-09 15:00:53 -04:00
Valeriy Ponomaryov
8401c150f3 [Container] Fix deletion of veths
In '_teardown_server' method driver was searching for all matches of
'veth' prefix and looping them for deletion. But using Xenial host
it finds each such veth name twice and tries to delete the same veth
twice too getting following error:

ovs-vsctl: no row "veth7ac5738" in table Interface

So, fix it by translating 'list' of veths to 'set' that
will have only unique names.

Change-Id: I819a885547f9fc595b15f98e4c94de21e33914ac
Closes-Bug: #1630512
2016-10-07 14:36:06 +03:00
OpenStack Proposal Bot
dd3bfeb722 Updated from global requirements
Change-Id: Id1c5b4acea148bba9477935781ab2e73975f0f51
2016-10-07 05:31:26 +00:00