oslo.utils provides similar function[1] to check if ipv6 is supported.
Though Manila and oslo.utils implemented in different way, we can
improve the version of oslo.utils to make it suitable to other projects.
[1]https://github.com/openstack/oslo.utils/blob\
/d1e08f533d4351f10b8103e24c254004b6627a29/oslo_utils/netutils.py#L170
TrivialFix
Change-Id: I4ff99189943f4ca56f0532e58b1aedc63516074d
As per OpenStack licensing guide lines [1]:
[H104] Files with no code shouldn't contain any license header nor
comments, and must be left completely empty.
[1] http://docs.openstack.org/developer/hacking/#openstack-licensing
Change-Id: I7704e9defc555373f47036b28cfa2287ad67b0f8
Drop the undesired executable bit for the following files:
1. manila_tempest_tests/services/share/v2/json/shares_client.py
2. manila_tempest_tests/tests/api/test_share_networks.py
Also add pep8 check for new executable files under manila_tempest_tests.
Change-Id: Iaa509fdf4e0ebeb60d71b053f62459992c938468
There are two ways to give other greenthread chance to run:
greenthread.sleep(0) or time.sleep(0). Add the second way in
threading.rst and recommend the first way for contributors.
Also, PyMySQL works well with eventlet [1], and it's the default MySQL
DB API driver for oslo.db now[2].
So adjust 'threading model' doc with such info.
[1] https://wiki.openstack.org/wiki/PyMySQL_evaluation
[2] http://docs.openstack.org/developer/oslo.db/installation.html
Change-Id: Ifcf48cddcf52ce720ceb275cc3eb4d6be61a3ca5
This patch updates the documentation for the Hitachi NAS Platform
File Services Driver for OpenStack.
Closes-bug: #1536812
Closes-bug: #1614833
Closes-bug: #1616618
Closes-bug: #1623105
Change-Id: I0291efcadf244b7911969cfb367387a5998f1a23
Manila doesn't use methods ensure_tree and delete_if_exists anywhere,
and oslo.utils provides same methods in module fileutils. We can use
them from oslo.utils if we need in the futrue.
TrivialFix
Change-Id: I280b674dca3738d26c2bed2cf71e94775b370cd5
While huawei driver reads username/password configuration from
configuration file, if the value is plain text, huawei driver'll
encode this text and write back to configuration file.
huawei driver leverages base64.b64encode to implement the encoding.
The encoded result is a byte string, and then is converted to
unicode string.
In py2, this works fine. However, in py3, the unicode string
converted from byte string is like "b'***'", *** is the orginal
string supposed to be.
So the encoded string is broken, and exception occurs while decoding
from it.
This patch fixes the incorrect unicode string converting and make
the encoded result string right.
Change-Id: I2483ae4999484b3a67c7d443f9b3cc214a3473b2
Closes-Bug: #1613242
Standard library fnmatch in Python versions <= 2.7.9 has thread safe
issue[1], we can use thread safe version from oslo.utils.
[1]https://bugs.python.org/issue23191
Change-Id: I42e9deed338ef6a9a75bb84fa9efd1aaf2baeccd
Check for nfsd has been implemented incorrectly and has
apparently checked nothing. This change fixes that.
Change-Id: I2cc735744fcb588e9945e34de4cd4cc2270078f8
Closes-Bug: 1616061
Currently, there are 3 statuses for qos:
- 'active', 'inactivated' and 'idle'
If qos status is 'idle', the qos deletion will fail because
huawei driver doesn't deactivate it before deleting.
This change fixes this bug by deactivating qos first if qos
status is not 'inactivated'.
Change-Id: I40f937c22d77d8e07fba176bdc09ca461f01733a
Closes-Bug: #1625424
It appears that remote executor (processutils.ssh_execute)
and local executor (processutils.execute) have different
expectations for command keywords containing spaces. This
difference manifests itself in helper failures either for
one executor type or for another. This change adds command
preprocessing to generic driver which seems to be the only
active user of both remote executor and failing helpers.
Change-Id: I26eaca3ca652171fbf20d7580f90eef4f935332e
Closes-Bug: 1621033
This adds a cross check whether the neutron values
are matching the manila db/api value.
Change-Id: I096579704e217a91431dc5201a60beb43e015417
Closes-bug: #1612528
In case create_port is called with host_id it's better to fail if
port_binding_extension is not available. Otherwise there won't
be any binding and no logging that the port will be inactive.
Change-Id: I65595308bc71ae78c992fd97e3f26fd718b249ec
Closes-bug: #1602525
The os-api-ref 1.0.0 is out. We can remove the support to older version
now.
Change-Id: I9974796c2e2ccab5d2f4f651d082632de040f3c4
Reference: Ia6245d502fde38cd4d63aa4a786b6296b22a37a1
nfsd refuses to start on a host with empty /etc/exports. This
change adds a workaround for affected first-party drivers.
Change-Id: If62fdc4219ceb02455bc55c717b7f2c7f34b0dca
Closes-Bug: 1616061
With 3PAR, share server(VFS) can have up to 4 IP addresses.
During bootup, driver queries 3PAR to get list of all IP addresses
and validates it against IP addresses provided in manila.conf. If
there is a mismatch, driver throws exception.
The bug was with 3PAR file client which always returns only one IP
address. To make driver backward compatible with 3PAR client,
mediator.py formats the value retured by client and passes it to
driver.py. This patch now correctly accepts all the IP addresses
as obtained from 3PAR and validates configured IPs against it.
Also removing unused function.
Updated and added new unit tests
Added release notes
Closes-Bug: #1621016
Change-Id: I1eeb18cc9905a71cd38c383bc0ab49e0a560ffc9
Previously only the DHSS=True mode was documented
in post install steps. The assumption that the generic driver
was being configured existed in other places as well.
* add DHSS=False documentation as necessary with the
LVM driver.
* correct assumptions in other places to clarify usage
of appropriate share driver modes.
Change-Id: Ic1356453e510e8f360269fb45a41379329ce68c2
Closes-Bug: #1616257
