Set following 4 attributes when creating nfs shares:
showmount: enabled
v3-ms-dos-client: support
v3-connection-drop: disable
ejukebox-errors: disable
Change-Id: I86c3de32d36940e85545fcb337723e4b3edce216
Closes-bug: 1901937
Co-authored-by: Maurice Escher <maurice.escher@sap.com>
NetApp driver is hard-coding the location of CA certificates for SSL
verification during HTTPS requests. This location may change depending
on the environment or/and backend.
This patch adds the `netapp_ssl_cert_path` configuration, enabling
each backend to choose the directory with certificates of trusted CA
or the CA bundle. If set to a directory, it must have been processed
using the c_rehash utility supplied with OpenSSL. If not informed,
it will use the Mozilla's carefully curated collection of Root
Certificates for validating the trustworthiness of SSL certificates.
Closes-Bug: #1900191
Change-Id: Idbed4745104de26af99bb16e07c6890637dfcfd1
When a share is mounted on the same host as the manila-share
process, the kernel prevents us from destroying the
mount directory until the share has been cleanly unmounted
from the host. Kernel mounts can take a few seconds to get
unmounted fully especially when there are a lot of
linux namespaces that the mountpoint has been shared to.
Add a retry on these operations to harden the deletion
process and prevent spurious failures.
Change-Id: I3c1a2ec19d6bc18638db0875519ce60f2c89f33a
Closes-Bug: #1903773
Related-Bug: #1896672
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
When a share is mounted on the same host as the manila-share
process, zfs prevents us from destroying the underlying
dataset until the share has been cleanly unmounted from
the host. Kernel mounts can take a few seconds to get
unmounted fully especially when there are a lot of
linux namespaces that the mountpoint has been shared to.
Add a retry on these operations to harden the deletion
process and prevent spurious failures.
Change-Id: I4aba76b72df274d0a8cb90fe0ab8799523c260ef
Closes-Bug: #1903773
Related-Bug: #1896672
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
Moves the share replica export location API reference out of the
experimental features documentation.
Change-Id: I16cbad169d0c4f89428f17a317840750966d240f
Python modules related to coding style checks (listed in blacklist.txt
in openstack/requirements repo) are dropped from lower-constraints.txt
as they are not actually used in tests
Change-Id: Ia64180303af54c512610add2f55987efea97017a
Moves the manila shares filtering to the database in order to have
the queries performance improved.
Change-Id: I031a3b9775c50e78b6b86752ff8d1a4871a91c0c
Co-Authored-By: MaAoyu <maaoyu@inspur.com>
The share "manage" API checks whether
an existing/known share is being imported by
matching the export path provided to existing
shares.
This lookup does not consider the
fact that shares may have multiple export
locations, because it relies on an old/deprecated
"export_location" property on shares which
was added to provide backwards compatibility
to the API that presented only one export
location per share.
Further, it's possible to get a
"ERROR: Invalid share: Share already exists"
exception even when no such share exists in the
database.
Fix the lookup by using the "export_location_path"
based lookup which is faster, since it performs
a meaningful join on the export locations table;
and remove the parameters "protocol"
and "share_type_id" - these things make no
difference when there's a duplicated export
location. We'll consider "host" as a lookup
parameter since we can't be sure that export
locations are unique in a deployment - but they
ought to be unique for a given host.
Closes-Bug: #1848608
Closes-Bug: #1893718
Change-Id: I1d1aef0c2b48764789b43b91b258def6464b389f
Co-Authored-By: Goutham Pacha Ravi <gouthampravi@gmail.com>
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
This patch fixes the 'update_share_replica' operation in the share manager
that wasn't getting the share-server model from the share replica model.
When the operation is executed, the current share replica object may
not have the 'share-server-id' information and need to be updated before
anything else.
Closes-Bug: #1898924
Change-Id: I1d9d69bbdaa27a68a425d959fa8c5da83a157548
Signed-off-by: Douglas Viroel <viroel@gmail.com>
This patch fixes the access rules for NetApp promote replica when
using CIFS protocol. When promoting a replica, the NetApp ONTAP
driver updates the access rules for the promoted CIFS share entity
before actually creating it, failing on having those rules
applied.
The bug is fixed by switching the order of updating the access
and creating the promoted CIFS share entity.
Change-Id: I60e4057dc962d96cff57dea88587a28c2043b499
Closes-Bug: #1896949
Add file to the reno documentation build to show release notes for
stable/victoria.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.
Change-Id: Id443501a3ddda27d38febebb7e4d6de96fd608c4
Sem-Ver: feature
This patch adds the admin and user documentation for share revert to
the latest available snapshot.
Change-Id: Id35b99fdb47bb9de38f42034818fb4a29370bf36
Closes-Bug: #1657322
This patch is a follow up from the main change[1] that adds support
for Adaptive QoS policies that have been pre-created in the storage.
Improvements added in this patch:
- Fail earlier when using this configuration with DHSS=True mode
and for shares that support replication.
- Fail earlier if no cluster credentials where provided to configure
volumes with QoS.
- Add support for migration and manage share operations.
Closes-Bug: #1895361
[1] https://review.opendev.org/#/c/740532/
Change-Id: I210994b84548ed6857e338c8e1f41667fa844614
Signed-off-by: Douglas Viroel <viroel@gmail.com>
Implemented several improvements to share migration in documentation
according to https://review.opendev.org/#/c/406305/
Summary of changes:
- Add driver-assisted mandatory parameters.
- Removed previous API documentation because support for them isn't
there anymore after the backwards incompatible changes were
made via https://review.opendev.org/#/c/406305/.
- Add force-host-assisted migration.
Change-Id: I6d446b4037a3a9991e375f0a8bfb1f6edce09c1f
Closes-Bug: #1658230
It's dead code and nothing refers to it
TrivialFix
Change-Id: I0c3cc4a233879bf471b6358907fda4c0af41ab9b
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
This patch is a follow up patch of the main change[1] that adds
support for share server migration in NetApp driver.
It fixes two issues:
- Data motion 'get_backend_configuration' now avoids sending vserver
configuration, available only in DHSS=False mode, when driver is
configured with DHSS=True.
- After migrating a share server, all volumes appears with different
autosize configuration and need to be manually updated to the
original values. Provisioning options are also being updated in the
same method.
[1] https://review.opendev.org/#/c/747048/
Change-Id: I28a47417ec5dda0ed1f6c64fae37f5af6ca057e6
Signed-off-by: Douglas Viroel <viroel@gmail.com>
NetApp ONTAP Manila driver fails to get information from 'python-manila'
package in the periodic tasks, and logs INFO messages saying the package
was not found. It doesn't break anything, but the message might be scary.
Change-Id: I2e773f7cca0c95d18922281832afd93a99de5123
Closes-Bug: #1886232
This change fixes the NetApp promote back issue when using CIFS
protocol. When promoting a replica, the NetApp ONTAP driver
attempts to create a new CIFS share entity (an access point as
defined in [1]) for the new active replica. This behavior
causes a failure since the storage identifies that a current
backend CIFS share with the same name exists, considering
that the reffered replica was once the active one.
This issue is addressed by removing the related CIFS share
entity when the replica gets promoted.
[1] https://library.netapp.com/ecmdocs/ECMP1401220/html/GUID-1898D717-A510-4B3D-B2E3-CCDDD5BD0089.html
Closes-Bug: #1879368
Change-Id: Id9bdd5df0ff05ea08881dd2c83397f0a367d9945
While managing share server using newest versions of the
Open vSwitch, some of the interface external-ids are being
saved without quotation marks around the container name.
This causes the regex to fail on filtering the correct
network interface and fail on manage share server operation.
An alternative would be to always set the quotation mark
around the container name, but this is not accepted and dropped
by the Open vSwitch. Instead, the search regex was updated and
now it accepts both modes:
i) manila-container=manila_85fd0ad7_f614_46e3_bad3_f19eae36f6ea
ii) manila-container="manila_85fd0ad7_f614_46e3_bad3_f19eae36f6ea"
Closes-Bug: #1896322
Change-Id: Ia24e7cd186cfa23fdfb267ce9b6155ff3d93d5d2
Signed-off-by: Douglas Viroel <viroel@gmail.com>
