807 Commits

Author SHA1 Message Date
Zuul
fca72a2d23 Merge "Remove deprecated config and auth" 2021-06-22 01:46:56 +00:00
Zuul
37c43a1201 Merge "Fix api error message for snapshot creation failure" 2021-05-13 19:55:54 +00:00
Tom Barron
be29805859 Fix api error message for snapshot creation failure
when the source share has ``snapshot_support`` False.

The message said that the back end lacks snapshot support but this
is not necessarily the case.

Closes-bug: #1925342
Change-Id: I09a83b63528c0988f3601dfd07ad6972165cb855
2021-05-12 12:24:13 +00:00
LinPeiWen
63e255248b [Glusterfs] Fix create share from snapshot failed
1、After performing a snapshot clone of the glusterfs vol,
  the status of the vol is'Created', and the parameter
  "gluster volume set nfs.rpc-auth-reject'*'" is required for
  the vol in the'Started' state.
2、The cloned volume needs to activate the snapshot,
  if the snapshot is already activated, you need to skip the activation step

Closes-Bug: #1922075
Change-Id: I304bf59b3f8c0d5b847078a5752bac8ac4f21690
2021-04-27 09:23:13 +00:00
Tom Barron
5af3b8e68b Remove deprecated config and auth
Remove manila configuration options
and auth classes that were deprecated
before the Ussuri release.

Change-Id: I148225926cd249a0dd8d1f8c02b22ed06487f405
2021-04-26 11:53:58 -04:00
Zuul
7b521675ef Merge "Direct mgr commands to the mgr daemon" 2021-04-19 19:25:03 +00:00
Maurice Escher
29a943fde7
Reuse _set_instances_share_data for replicas.
Replicas are just special instances after all, no need for
duplicate code and missing on improvements like exception handling
on NotFound error.

Change-Id: I31fabebc6a60814a4cfc04ae0deb49dcb66cab0f
Closes-Bug: #1923566
2021-04-16 10:32:58 +02:00
Victoria Martinez de la Cruz
3ea5d50a23 Direct mgr commands to the mgr daemon
Commands in the Ceph driver are directed at the mon
daemon instead of at the mgr daemon.

The driver's rados_command() calls json_command() and,
by default, json_command() calls the python
rados client's mon_command() instead of mgr_command().

By passing the target as mon-mgr, the python rados
client's mgr_command() is called as desired, and we
avoid the need of extra MON write caps.

Closes-Bug: #1923181

Co-Authored-By: Victoria Martinez de la Cruz <victoria@redhat.com>
Co-Authored-By: Ramana Raja <rraja@redhat.com>
Co-Authored-By: Tom Barron <tpb@dyncloud.net>
Change-Id: I5bca68070ca1eb539d53dd31cb92588840e925e8
2021-04-13 20:10:48 +00:00
1522add3aa Update master for stable/wallaby
Add file to the reno documentation build to show release notes for
stable/wallaby.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/wallaby.

Sem-Ver: feature
Change-Id: I49803f627c4c580b41e7408b2b7e0452f3758831
2021-03-26 18:56:26 +00:00
Zuul
0c8e92e54a Merge "Add release note for secure rbac work" 2021-03-26 16:19:40 +00:00
Goutham Pacha Ravi
7a99c6a181 Add release note for secure rbac work
Call out the feature and its impact.

Change-Id: I3062950e7b9c5b7d93a8332b65881f83226cda4e
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
2021-03-26 15:21:34 +00:00
Zuul
8a51e5e907 Merge "Filter storage protocol in the scheduler" 2021-03-26 10:52:04 +00:00
Zuul
bcab0515fa Merge "[NetApp] Follow up fixes for update security service" 2021-03-26 10:51:07 +00:00
Zuul
36672dcec6 Merge "Add exception for insufficient privileges when using security services" 2021-03-26 01:25:19 +00:00
Zuul
a411f521d4 Merge "Support host assisted share migration for Zadara manila driver" 2021-03-26 00:04:11 +00:00
Zuul
4617e20e7b Merge "Fix wrong totalcount returned by share listing query" 2021-03-25 21:36:36 +00:00
Douglas Viroel
7f0737b75e [NetApp] Follow up fixes for update security service
This patch is a follow up of [1] to address some comments
added in the review process. It also adds more unit tests to
validate the new code added.

[1] https://review.opendev.org/c/openstack/manila/+/775032

Change-Id: If7b8628fa05200363a129eb19d9dc80fb7e3bc36
Signed-off-by: Douglas Viroel <viroel@gmail.com>
2021-03-25 17:50:24 -03:00
Zuul
0c577864fb Merge "[NetApp] Implement cached status pool" 2021-03-25 20:09:54 +00:00
Zuul
33d8603b13 Merge "Add create share from snapshot in CephFS" 2021-03-25 19:52:04 +00:00
Zuul
24d41e8887 Merge "scheduler should ignore earlier time service capabilities" 2021-03-25 15:51:03 +00:00
Ratnakaram Rajesh
643083eefa Support host assisted share migration for Zadara manila driver
Closes-Bug: #1917980

Change-Id: I66371e6a8a1650ffebe5ffe482cde52660ccc000
2021-03-25 17:17:34 +02:00
Eduardo Santos
3d65f46d3e Add exception for insufficient privileges when using security services
When trying to create a share using a security
service while having insufficient privileges or
providing wrong credentials, manila raises a
generic user message that provides little
information to the end user on what exactly went
wrong.
Added a driver-agnostic exception for when this
happens, accompanied with a user message to
provide more useful information to end users.

Partial-Bug: #1900755
Change-Id: I2b0bc5c0715c225cd5b38b55fb3967ff7fc86fa8
2021-03-25 14:45:53 +00:00
maaoyu
268686c448 Fix wrong totalcount returned by share listing query
This bugfix [1] modified the totalcount returned by pagination
query when the argument 'limit' was specified. It caused
manila to do not return precise count of shares in a query that
satisfied the conditions.

This bug has been fixed and now manila is returning the precise
values of shares matched in a given query. Also, manila is now
performing filtering actions in the database to have more
performatic results.

[1] https://review.opendev.org/#/c/688542/

Closes-Bug: #1860061

Co-Authored-By: Carlos Eduardo <ces.eduardo98@gmail.com>

Change-Id: I6ddd919bbd5180593cc52bf986912f65a2dab3a7
2021-03-25 08:47:22 -03:00
Zuul
4f41f86ad1 Merge "fix unmange share with manage_error status will lead to quota error" 2021-03-25 03:04:59 +00:00
Victoria Martinez de la Cruz
5c81264346 Add create share from snapshot in CephFS
Adds create share from snapshot functionality to
CephFS drivers.

Depends-On: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/778188

Co-Authored-By: Victoria Martinez de la Cruz <victoria@redhat.com>
Co-Authored-By: Ramana Raja <rraja@redhat.com>
Co-Authored-By: Tom Barron <tpb@dyncloud.net>

DocImpact
Partially-Implements: blueprint create-share-from-snapshot-cephfs

Change-Id: I825ab15af934cb37dfda48ea26ec1af9de8dd293
2021-03-24 22:24:30 +00:00
Victoria Martinez de la Cruz
a830710939 Update cephfs drivers to use ceph-mgr client
Use python rados client to talk to the ceph-mgr service.

A python rados client is created by the driver that lasts
during the driver's lifecycle.

The drivers can now work with multiple filesystem clusters.
The filesystem to be used by manila can be specified by the
driver option 'cephfs_filesystem_name'.

The removal of a share will be quicker for the manila user.
The ceph-mgr volumes module moves the share's content to
a trash folder and purges the trash's contents
(`rm -rf` of the backend CephFS subvolume/subtree) aysnchronously,
whereas the ceph_volume_client library moves the share's content
and purges the content synchronously.

Implements: bp update-cephfs-drivers

Co-Authored-By: Victoria Martinez de la Cruz <victoria@redhat.com>
Co-Authored-By: Ramana Raja <rraja@redhat.com>
Co-Authored-By: Tom Barron <tpb@dyncloud.net>

DocImpact

Change-Id: I1f81db1ba7724c0784d87f9cb92bb696f6778806
2021-03-24 10:50:05 -04:00
Zuul
7f6aa6dbd3 Merge "Fix generic share resize with 0.0.0.0/24 access" 2021-03-23 22:37:59 +00:00
Zuul
3ce8d978ad Merge "Put ensure_share into thread pool to speed up the startup of share service" 2021-03-22 12:33:04 +00:00
haixin
a8e25b858d Put ensure_share into thread pool to speed up the startup of share service
when we need to start or restart manila share service, will call
init_host().
and call ensure_driver_resources() in init_host(),
will call self.driver.ensure_shares or self.driver.ensure_share to
update all share instances in that host. Currently, only NetApp and LVM
implement self.driver.ensure_shares, Other manufacturers are using
self.driver.ensure_share.
   in large-scale environment, there are lot of share instances in one
host. this will lead to take much time to ensure_share.
   so we can put this operation into the thread pool to speed up the
startup of the service.

Closes-Bug: #1909847
Change-Id: I295d0de0958ebfedd89441f1a2c1b447b74693a0
2021-03-20 11:49:23 +00:00
haixin
73d0a74f3b fix unmange share with manage_error status will lead to quota error
if we failed to manage a share, we don't need to commit the quota usages. so
we should skip quota usages cuts when delete or unmange the share with
status of "error_manage". and the size of error_manage share should be
zero.

Closes-Bug:#1883506

Change-Id: I5c81dd6780890c55c8c6a92491c3f4f507531fdb
2021-03-20 10:45:23 +08:00
Elias Wimmer
2586252606 Fix generic share resize with 0.0.0.0/24 access
Add missing quotes to exportfs command to protect <world> being
interpreted as file redirect

Closes-Bug: #1911695
Change-Id: Ie95a476e9a81c58df998c3f44da137b023b53cc6
2021-03-19 13:18:38 +01:00
Goutham Pacha Ravi
f24fff9522 Filter storage protocol in the scheduler
The share protocol requested was being
ignored by the scheduler and this would
cause shares to get scheduled to hosts
that don't support the specified protocol.

Change-Id: I2e87264865b645781c481383c039fecbfd7c6eb1
Closes-Bug: #1783736
2021-03-17 18:18:56 -07:00
Felipe Rodrigues
b2e1797889 [NetApp] Implement cached status pool
In order to optimize the NetApp ONTAP driver, this patch is caching
the status of driver pools and reusing for the each share server,
given that the pool is not separated by share server.

The option `netapp_cached_aggregates_status_lifetime` is added
for controlling the time that the cached values is considered
valid.

Closes-Bug: #1900469
Change-Id: I14a059615fc29c7c173c035bb51d39e0bbb8b70a
2021-03-17 19:09:00 -03:00
Zuul
9b835f03d5 Merge "[NetApp] Implement security service update" 2021-03-17 04:19:37 +00:00
Zuul
e8810b2019 Merge "Fix traceback in scheduler-stats API" 2021-03-15 19:18:07 +00:00
haixin
70bb650e7f scheduler should ignore earlier time service capabilities
if rabbitmq is too much pressure or blockage.scheduler
will not received service capabilities, but once the
message queue(rabbitmq) returns to normal, scheduler
will received many service capabilities, these service
capabilities are acquired by manila share at different
times, so the timestamp of service capabilities shoud
added at share manage layer(before rpc), but not
scheduler layer(after rpc), once scheduler get an newer
service capabilities, there is no need to update an
earlier service capabilities.

Closes-Bug: #1908963
Change-Id: I6ce99ed4451c5d02cb4446861fa59e55a94951a5
2021-03-15 16:18:39 +00:00
Zuul
475eeafd8d Merge "Add security service update support to the container driver" 2021-03-15 14:03:31 +00:00
Douglas Viroel
ff91db3ece [NetApp] Implement security service update
This patch implements support for security service updates
for in use share networks. It works with all three security
service types. For 'active_directory' and 'kerberos', the 'domain'
attribute update isn't supported, since it can might affect
user's access to all related shares.

Change-Id: I8556e4e2e05deb9b116eacbd5afe2f7c5d77b44b
Depends-On: I129a794dfd2d179fa2b9a2fed050459d6f00b0de
Depends-On: I5fef50a17bc72ba66a3a9d6f786742bcb5745d7b
Implements: bp netapp-security-service-update
Co-Authored-By: Carlos Eduardo <ces.eduardo98@gmail.com>
Signed-off-by: Douglas Viroel <viroel@gmail.com>
2021-03-15 09:12:36 -03:00
Eduardo Santos
733d6218e6 Add security service update support to the container driver
This implementation adds the functionality to add/update security services
to in use share networks using the container driver. The container driver will
also try to setup security services while creating share servers. Currently, the
only supported security service type is LDAP.

Co-Authored-By: Carlos Eduardo <ces.eduardo98@gmail.com>
Partially Implements: bp add-security-service-in-use-share-networks
Depends-On: I129a794dfd2d179fa2b9a2fed050459d6f00b0de

Change-Id: Ifb8b9ebe6eb0661844c794ca1a32e35105652f72
2021-03-12 18:43:53 -03:00
debeltrami
2bc27c5678 Add security service update for in-use share networks
This patch implements the update of security service's association
with in-use share networks. The following changes were added:

 - New share network APIs: `share_network_security_service_update`
 and `share_network_reset_state`.

 - A new `status` attribute was added to share network model to
 identify when it's in a modification state, called 'network_change'.
 Other supported status that were added: 'active' and 'error'.

 - New 'security_service_update_support' property was added to both
 share server and share network models, to identify when this resources
 are able to process security service update for in-use share networks.

 - New driver interface was added to support update of security service's
 configuration of a given share server.

DocImpact
APIImpact
Partially Implements: bp add-security-service-in-use-share-networks

Co-Authored-By: Carlos Eduardo <ces.eduardo98@gmail.com>
Co-Authored-By: Douglas Viroel <viroel@gmail.com>
Co-Authored-By: Andre Beltrami <debeltrami@gmail.com>

Change-Id: I129a794dfd2d179fa2b9a2fed050459d6f00b0de
2021-03-12 18:37:45 -03:00
Zuul
0a2ae6ff51 Merge "Add config option to set per_share_size_limit." 2021-03-12 05:07:37 +00:00
Zuul
e83517b662 Merge "Add share server limits" 2021-03-12 02:59:45 +00:00
Douglas Viroel
0b04d8d671 [NetApp] Add support for FPolicy native mode
This patch adds support for automated creation of FPolicy policies
and association to a share. The FPolicy configuration can be added using
 the extra-specs 'netapp:fpolicy_extensions_to_include',
'netapp:fpolicy_extensions_to_exclude' and 'netapp:fpolicy_file_operations'.

Change-Id: I661de95bfb6f8e68b3a8c58663bb6055e9b809f6
Implements: bp netapp-fpolicy-support
Signed-off-by: Douglas Viroel <viroel@gmail.com>
2021-03-11 10:46:51 -03:00
Zuul
1515701df0 Merge "[NetApp] Fix security service configuration for LDAP servers" 2021-03-11 12:48:58 +00:00
Douglas Viroel
8943e57ee6 [NetApp] Fix security service configuration for LDAP servers
This patch fixes some issues with LDAP client configuration on
ONTAP SVMs. With ldap security service, users should be able to
configure a LDAP client that can be used for authentication and
name mapping. The name service switch order remains: ldap,files.
Issues fixed:
- The driver now identifies when user provide a Active Directory
  domain or a Linux/Unix LDAP server IP and sets the correct schema.
- LDAP configuration parameter `servers` was replaced by `ldap-servers`
  in ONTAP 9.2, and now accepts host names too.
- Fix DNS configuration for LDAP security service
- User can now specify base search DN for LDAP queries, which can be
  mandatory for Unix/Linux servers, using the security service `ou`
  parameter.

Closes-Bug: #1916534
Change-Id: Ieaa53abbe50e7b708e508c132dfc4bb36b71a4f5
Signed-off-by: Douglas Viroel <viroel@gmail.com>
2021-03-10 16:00:46 -03:00
Zuul
8523d323e7 Merge "Adding Zadara Manila driver" 2021-03-09 17:44:03 +00:00
kpdev
0045293942 Add config option to set per_share_size_limit.
This feature allows admin to set share size limit for a project.
The defaults will either come from the default values
set in the quota configuration option or via manila.conf
if the user has configured default values for quotas there.

The quota_per_share_gigabytes defaults to -1["No Limit"] always
unless changed in manila.conf by admin.

Closes-Bug: #1811943

Change-Id: Ida126c8c419b8bf4d2a194f061a0809d52b47ab8
2021-03-09 11:58:17 +01:00
silvacarloss
2fb871cb89 Add share server limits
Add two new capabilities to manila. It is possible to set limits
to share server size and share instances in a share server by
setting `max_share_server_size` and `max_shares_per_share_server`
in a backend stanza.

Change-Id: I3170478d3aa2d09cb2adc32233dc57bc59029a56
Partially-Implements: bp new-share-server-limits
DocImpact
2021-03-08 21:35:06 -03:00
Zuul
c52c2be123 Merge "RBAC tightening for share access rule" 2021-03-08 23:10:38 +00:00
Ratnakaram Rajesh
4705a7d520 Adding Zadara Manila driver
Implements: blueprint zadara-manila-driver

Change-Id: Iae0eaf8b37d5eecc352af6546fd0cfa4cadab497
2021-03-06 10:02:09 +02:00