The api documentation is now published on docs.openstack.org instead
of developer.openstack.org. Update all links that are changed to the
new location.
Note that the location API location /shared-file-system and not
/shared-file-systems.
Note that redirects will be set up as well but let's point now to the
new location.
For details, see:
http://lists.openstack.org/pipermail/openstack-discuss/2019-July/007828.html
Change-Id: I86f50af83be699fa7e0fb064abb20324e2d87b86
Was probably introduced by accident in [1]. Don't
need it anymore.
[1] I890ba4c54b0da10060767620ff5ff7e480d79a9c
Change-Id: Ib6fdb8c1488dde2308d8cc8bb3e79e1280d3e812
Older releases of pylint use an internal API of
the astroid library that causes pylint
exceptions when parsing modules. The errors
are like:
internal error with sending report for module ['manila/network/neutron/neutron_network_plugin.py']
'Import' object has no attribute 'infer_name_module'
So let's use the latest version available
that doesn't have this issue.
[1] https://github.com/PyCQA/astroid/issues/649
Change-Id: I6031111e5c72470313642307b4596806cd5408df
We use the mock library in our
unit tests which assigns mocked objects with
members at run time. This causes pylint to flag
"no-member" errors. We also test return values
on methods which return None explicitly, or
implicitly, this upsets pylint.
pylint is quite inflexible in the way it handles
ignores in code. We can add ignore statements all
over the test code, but that is quite infeasible.
So, this change lets us run pylint separately
for code and test modules. When running tests,
it adjusts the disabled pylint checks.
Change-Id: I85d3fe896ee95c52c3da55aedba8f4d72d0c299e
We don't use the tools/lintstack.py
script anymore since its removal in [1],
so cleanup the unused tox environment and
the gitignore corresponding files.
TrivialFix
[1] https://review.openstack.org/#/c/609791/
Change-Id: Id2d40c1f9f1ce71a22ba9836b90c3e917171a556
This issue was recently seen in cinder when the gate failed
to detect trailing whitespaces in '.inc' files.
As seen, manila was also prone to such issues but thankfully
no error was found in '.inc' after running against doc8.
It still seems important to include it in the testing to avoid
future similar issues.
Change-Id: Ie1fd4ddb4448c05559a31098302f84367fe6ed52
Set dependencies correctly for pylint job in tox.ini so
it does not report spurious E041 import errors on mock
and ddt modules. Also fix a reference to Cinder instead
of Manila in the pylint script.
Closes-Bug: #1813156
Change-Id: Ib160caae57e41a4d45483ff4faa599143e694abc
This commit does several things:
- Setup and run pylint directly rather than running through a script.
This allows the user to see what is happening while the user is running
through pylint.
- Allow the user to either run pylint on a particular changeset,
or the entire manila tree.
- Allow the user to run on a particular changeset. Using like HEAD~1,
etc.
- I disabled the tests that were reported by pylint.
The thought here would be go through the failures
and correct them.
- Update pylint to 2.1.1.
Change-Id: I398d1ba01a3fd7f1c86ad4065a7984d276f33383
Signed-off-by: Chuck Short <chucks@redhat.com>
Quotes around {posargs} cause the entire string to be combined into one
arg that gets passed to stestr. This prevents passing multiple args
(e.g. '--concurrency=16 some-regex')
Change-Id: I1088cfbab31befbd24e56add806d6e86fe46e5eb
base python version is 3, not 3.5 and
python 3.5 is not installed in some current
distros so running 'tox' locally fails.
Change-Id: Ie2449a433e07f4cafb55fe1db247ba9f854cef97
Updates the pylint and lint jobs to run under python3 by
changing the target python and updating the version of
pylint used.
Change-Id: Ie0ac158674fb22054b80864d33d9d7ecc82e3b36
Closes-bug: #1673824
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I59ac21cb0d34f0b6767c736d0419eb6b874efca1
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This change just updates the tox.ini file to call stestr directly
instead of going through ostestr.
Change-Id: Ibe957cda167b59ef44f5c7e9dfc415c227213565
when running tox -e docs locally, it failed because
the title overline too short.
Change-Id: I9b1d85f12ff559e032c465d7737e9c27efb459c3
Closes-bug: #1769073
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: I5f9a218429c1efc1fddae1945aef7110c4e031ee
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Change [1] restored .testr.conf since it was needed for the manila
coverage job.
Modify script used by the coverage job to invoke stestr rather than
setup.py with testr so that this job no longer requires .testr.conf
so remove the dotfile and update .gitignore.
TrivialFix
[1] I451e383ed654d00a5a017cb28521c47566911f33
Change-Id: Ibf549220303395744380f79993fbfcf04b2ed5b7
Co-Authored-By: Tom Barron <tpb@dyncloud.net>
This is the basic patch which consits of the framework
code for default policy in code feature as well as
share instance export location resource.
Partial-Implements: blueprint policy-in-code
Change-Id: Iedde7a4a674a60e760b47d5eb2973f42d79226d8
1. manila/install-guide is completely the same doc as the one in
the directory of manila/doc/source/install, this change is to
remove manila/install-guide because I think this is unnecessary
and also let us maintenance a copy of install-guide doc.
2. remove install-guide in tox.ini file, cause build doc will generate
install-guide doc.
Change-Id: Ife2d2b366f3f8b2bff8f9dda0f972858e1505a21
Some of the available checks are disabled by default, like:
[H106] Don't put vim configuration in source files
[H203] Use assertIs(Not)None to check for None
[H904] Use ',' instead of '%', String interpolation should be
delayed to be handled by the logging code, rather than
being done at the point of the logging call.
Change-Id: Ie985fcf78997a86d41e40eacbb4a5ace8592a348
to ensure artefacts from previous runs are not
left over when running these document builds locally.
TrivialFix
Change-Id: I0062c1bf94490ed4e5d0eb3675226b144f7124c1
to python2.7 so that running locally will succeed
and the results will match those for the gate
pylint job.
Partial-Bug: #1673824
Change-Id: I6c45a32ba8e77c35403357b0100379bb536a36b3
Our form of todo extension does not work with sphinx 1.5.2.
Remove it to unblock gate: we can add todos back in later with
more current methods. Also clean up some dangling cross-references
in the doc.
Co-Authored-By: Valeriy Ponomaryov <vponomaryov@mirantis.com>
Change-Id: If74b9e32ad2b5d8d70da60895d85588ff993797e
Make use of doc8 to verify all rst files which are not
autogenerated for errors and fail if there are any issues
found. The doc8 checks are now part of the tox 'docs'
environment and ran automatically. Checks can also be called
direcly via 'tox -e docs'.
Fix all issues found by doc8.
Closes-Bug: #1664841
Change-Id: I9215524d35646de7485504e4c5ff86fd91a1d09f
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
The gating on python 3.4 is restricted to <= Mitaka. This is due to
the change from Ubuntu Trusty to Xenial, where only python3.5 is
available. There is no need to continue to keep these settings.
Change-Id: Id8a9dda9ea25b47afc35e0605f4df2f3f22c5f38
Our current tox configuration provides no support for python 3.5
even though it is the version that ships with current ubuntu
(xenial) and Fedora (25) systems, and even though in gate the
python3 jobs run on xenial with python 3.5.
Add py35 env to tox.ini alongside py34, py27, and pep8.
TrivialFix
Change-Id: Ib32069f9185c5233c8f96164781ec66c56db33bd
Drop the undesired executable bit for the following files:
1. manila_tempest_tests/services/share/v2/json/shares_client.py
2. manila_tempest_tests/tests/api/test_share_networks.py
Also add pep8 check for new executable files under manila_tempest_tests.
Change-Id: Iaa509fdf4e0ebeb60d71b053f62459992c938468
releasenotes and venv tox jobs had redefined the install_command
to reinstall any packages from requirements/test-requirements files.
Since Infra started supporting constrained requirements for these
jobs as well, we can drop the reinstall command.
Ref:
http://lists.openstack.org/pipermail/openstack-dev/2016-August/101474.html
Change-Id: Ib4b8c6cef22a9911030c2e3e3f5281e7e22575fc
The API Documentation team has requires [1] that
projects maintain their api-reference in-tree and
build it to the developer.openstack.org website.
This version of the API reference uses os-api-ref
and compiles API documentation close to that of
the OpenStack compute service (nova).
Co-Authored-By: Goutham Pacha Ravi <gouthamr@netapp.com>
[0] http://lists.openstack.org/pipermail/openstack-dev/2016-May/093765.html
Implements: bp move-manila-api-reference-in-tree
Change-Id: I67bb3354162d6e0e00fa2788edde864cc14920ee
OpenStack CI supports now constraints in the coverage job - as a first
job to check that the recent changes for zuul-cloner work correctly.
Use constraints for cover environment.
Change-Id: I81a985a2049221a8a7ac1f20642137f22847973f
The commands used by constraints need at least tox 2.0. Update to
reflect reality, which should help with local running of constraints
targets.
Change-Id: I27348462a21daab479d76b24b48e3a4e017504cc
The tox targets do not currently use upper constaints, resulting in
stable branch test runs pulling down newer library versions than what
should be supported for those releases.
This adds upper-constaints for test environment setup.
Change-Id: I1ff164242901a891fb45da03b1595b2e9246a765
Closes-bug: #1596246
Manila has more dynamically created dirs than we exclude in
pep8 job. Such as 'build' and 'cover'.
Therefore, exclude them too to speed up passing of pep8 job on dev
machine where lots of dynamically created things exist.
TrivialFix
Change-Id: I256720846acdd584cadaf59e9dedaad0ff741ae3
The bashate tool has been upgraded and now issues new warnings.
Squash these E042 and E043 warnings since our shell scripts
are doing the right thing currently and changing them to avoid
the warnings makes them less readable and more fragile.
Change-Id: I25ff337160ab176bb150a6186f6c3198cc068732
Grenade is an OpenStack test harness to exercise the upgrade
process between releases. It uses DevStack to perform an initial
OpenStack install and as a reference for the final configuration.
Add support of it to Manila project, doing following changes:
- Add all required scripts for 'grenade' job, such as following:
-- settings
-- shutdown.sh
-- upgrade.sh
- Add optional 'resources.sh' script that performs functional
tests using bash and manilaclient. List of scenarios:
-- 1. create and delete share setting metadata and access rule
-- 2. attach security service to share network
-- 3. update quotas
-- 4. create private share type and add access for project
Note following:
- Tempest is not used by design.
- Manilaclient is used of stable version - version of 'base' devstack,
which is 'stable/mitaka'. It also means that used API microversion
is latest for that branch.
Change-Id: I7d7e0c50933776ca1a710bcf069abb0282b821ac
Depends-On: I4232382d3c944666bbf0916a3f285b84f6ff9d64
Implements blueprint grenade
When running pep8 checks, fail if executable
files have accidentally been added.
Co-Authored-By: Eric Harney <eharney@redhat.com>
Closes-Bug: 1566328
Change-Id: I7280c0403cd473cd4b88cfc021d4f605a7bb35f2
