openstack/neutron
Code Issues Proposed changes

tests: guarantee unique networks in get_list_of_random_networks

Browse Source 
The function generates a list of random networks, but so far did not
guarantee their uniqueness. In rare cases, it breaks
test_subnetpool_prefixes unit test in gate that relies on those networks
to be unique.

Now, the function will regenerate the result several times if duplicates
are detected.

Change-Id: Ia300e36ad7a25dd156ac8b5f27dcdeeaa5339ab8
Closes-Bug: #1585941
This commit is contained in:
Ihar Hrachyshka 2016-05-26 10:42:01 +02:00
parent 2bfa41691d
commit 543e960eb7
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
neutron/tests/unit/objects/test_base.py
View File

@ -225,7 +225,12 @@ def get_random_dscp_mark():
def get_list_of_random_networks(num=10):
return [tools.get_random_ip_network() for i in range(num)]
for i in range(5):
res = [tools.get_random_ip_network() for i in range(num)]
# make sure there are no duplicates
if len(set(res)) == num:
return res
raise Exception('Failed to generate unique networks')
FIELD_TYPE_VALUE_GENERATOR_MAP = {