openstack/neutron
Code Issues Proposed changes

Fix required extensions mix-up

Browse Source 
These features have their required extensions mixed up. There is
no reason why subnet pools (a core extension) depends on a non
core extension like router. On the other end, DNS does indeed
depends on it.

Related-bug: #1538623

Change-Id: If7e3566159919f1178373e3425310d457983f8ac
This commit is contained in:
armando-migliaccio
2016-01-28 10:31:36 -08:00
parent cc5876693e
commit 5ccfbb5b25
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
neutron/extensions/dns.py
View File

@@ -255,6 +255,9 @@ class Dns(extensions.ExtensionDescriptor):
def get_updated(cls): def get_updated(cls):
return "2015-08-15T18:00:00-00:00" return "2015-08-15T18:00:00-00:00"
def get_required_extensions(self):
return ["router"]
def get_extended_resources(self, version): def get_extended_resources(self, version):
if version == "2.0": if version == "2.0":
return EXTENDED_ATTRIBUTES_2_0 return EXTENDED_ATTRIBUTES_2_0

3
neutron/extensions/subnetallocation.py
View File

@@ -36,9 +36,6 @@ class Subnetallocation(extensions.ExtensionDescriptor):
def get_updated(cls): def get_updated(cls):
return "2015-03-30T10:00:00-00:00" return "2015-03-30T10:00:00-00:00"
def get_required_extensions(self):
return ["router"]
@classmethod @classmethod
def get_resources(cls): def get_resources(cls):
"""Returns Ext Resources.""" """Returns Ext Resources."""

2
neutron/tests/unit/extensions/test_dns.py
View File

@@ -44,7 +44,7 @@ class DnsExtensionTestPlugin(db_base_plugin_v2.NeutronDbPluginV2):
"""Test plugin to mixin the DNS Integration extensions. """Test plugin to mixin the DNS Integration extensions.
""" """
supported_extension_aliases = ["dns-integration"] supported_extension_aliases = ["dns-integration", "router"]
class DnsExtensionTestCase(test_db_base_plugin_v2.TestNetworksV2): class DnsExtensionTestCase(test_db_base_plugin_v2.TestNetworksV2):