Merge "Fix use-list-literal warnings"

neutron/tests/fullstack/test_qos.py

@@ -162,9 +162,9 @@ class _TestBwLimitQoS(BaseQoSRuleTestCase):
         # update_rules: rules that need to be updated during the l2-agent stop.
         # delete_rules:rules that need to be deleted during the l2-agent stop.
 
-        add_rules = list() if not add_rules else add_rules
-        update_rules = list() if not update_rules else update_rules
-        delete_rules = list() if not delete_rules else delete_rules
+        add_rules = [] if not add_rules else add_rules
+        update_rules = [] if not update_rules else update_rules
+        delete_rules = [] if not delete_rules else delete_rules
         # Stop l2_agent and clear/update/reset the port qos rules
         self.l2_agent_process.stop()
         self._wait_until_agent_down(self.l2_agent['id'])

neutron/tests/functional/agent/l2/extensions/test_ovs_agent_qos_extension.py

@@ -354,7 +354,7 @@ class TestOVSAgentQosExtension(OVSAgentQoSExtensionTestFramework):
         port_dict = self._create_port_with_qos()
 
         policy_copy = copy.deepcopy(self.qos_policies[TEST_POLICY_ID1])
-        policy_copy.rules = list()
+        policy_copy.rules = []
         context = mock.Mock()
         consumer_reg.push(context, resources.QOS_POLICY, [policy_copy],
                           events.UPDATED)

neutron/tests/functional/agent/test_firewall.py

@@ -560,7 +560,7 @@ class FirewallTestCase(BaseFirewallTestCase):
         self._apply_security_group_rules(self.FAKE_SECURITY_GROUP_ID, sg_rules)
         self.tester.establish_connection(**connection)
 
-        self._apply_security_group_rules(self.FAKE_SECURITY_GROUP_ID, list())
+        self._apply_security_group_rules(self.FAKE_SECURITY_GROUP_ID, [])
         self.tester.assert_no_established_connection(**connection)
 
     def test_preventing_firewall_blink(self):

neutron/tests/unit/api/rpc/handlers/test_resources_rpc.py

@@ -50,7 +50,7 @@ def _create_test_resource(context=None, resource_cls=None):
 class BaseFakeResource(objects_base.NeutronObject):
     @classmethod
     def get_objects(cls, context, **kwargs):
-        return list()
+        return []
 
 
 class FakeResource(BaseFakeResource):

neutron/tests/unit/db/test_db_base_plugin_common.py

@@ -78,7 +78,7 @@ class FilterFieldsTestCase(base.BaseTestCase):
 
     def test_multiple_arguments_positional(self):
         expected = {'two': 2}
-        observed = self.method_multiple_arguments(list(), ['two'])
+        observed = self.method_multiple_arguments([], ['two'])
         self.assertEqual(expected, observed)
 
     def test_multiple_arguments_positional_and_keywords(self):
@@ -89,5 +89,5 @@ class FilterFieldsTestCase(base.BaseTestCase):
 
     def test_multiple_arguments_keyword(self):
         expected = {'two': 2}
-        observed = self.method_multiple_arguments(list(), fields=['two'])
+        observed = self.method_multiple_arguments([], fields=['two'])
         self.assertEqual(expected, observed)