openstack/neutron
Code Issues Proposed changes

Merge "Implement secure RBAC for the segment API"

Browse Source
This commit is contained in:
Zuul
2021-01-04 18:06:25 +00:00
committed by Gerrit Code Review
parent 4d33a64931 bbd5d785d6
commit c0c6a2b3a9
1 changed files with 47 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
neutron/conf/policies/segment.py
View File

@@ -10,10 +10,13 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from oslo_log import versionutils
from oslo_policy import policy from oslo_policy import policy
from neutron.conf.policies import base from neutron.conf.policies import base
DEPRECATED_REASON = (
"The segment API now supports system scope and default roles.")
COLLECTION_PATH = '/segments' COLLECTION_PATH = '/segments'
RESOURCE_PATH = '/segments/{id}' RESOURCE_PATH = '/segments/{id}'
@@ -21,21 +24,28 @@ RESOURCE_PATH = '/segments/{id}'
rules = [ rules = [
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
'create_segment', name='create_segment',
base.RULE_ADMIN_ONLY, check_str=base.SYSTEM_ADMIN,
'Create a segment', scope_types=['system'],
[ description='Create a segment',
operations=[
{ {
'method': 'POST', 'method': 'POST',
'path': COLLECTION_PATH, 'path': COLLECTION_PATH,
}, },
] ],
deprecated_rule=policy.DeprecatedRule(
name='create_segment',
check_str=base.RULE_ADMIN_ONLY),
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
), ),
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
'get_segment', name='get_segment',
base.RULE_ADMIN_ONLY, check_str=base.SYSTEM_READER,
'Get a segment', scope_types=['system'],
[ description='Get a segment',
operations=[
{ {
'method': 'GET', 'method': 'GET',
'path': COLLECTION_PATH, 'path': COLLECTION_PATH,
@@ -44,29 +54,46 @@ rules = [
'method': 'GET', 'method': 'GET',
'path': RESOURCE_PATH, 'path': RESOURCE_PATH,
}, },
] ],
deprecated_rule=policy.DeprecatedRule(
name='get_segment',
check_str=base.RULE_ADMIN_ONLY),
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
), ),
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
'update_segment', name='update_segment',
base.RULE_ADMIN_ONLY, check_str=base.SYSTEM_ADMIN,
'Update a segment', scope_types=['system'],
[ description='Update a segment',
operations=[
{ {
'method': 'PUT', 'method': 'PUT',
'path': RESOURCE_PATH, 'path': RESOURCE_PATH,
}, },
] ],
deprecated_rule=policy.DeprecatedRule(
name='update_segment',
check_str=base.RULE_ADMIN_ONLY),
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
), ),
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
'delete_segment', name='delete_segment',
base.RULE_ADMIN_ONLY, check_str=base.SYSTEM_ADMIN,
'Delete a segment', scope_types=['system'],
[ description='Delete a segment',
operations=[
{ {
'method': 'DELETE', 'method': 'DELETE',
'path': RESOURCE_PATH, 'path': RESOURCE_PATH,
}, },
] ],
deprecated_rule=policy.DeprecatedRule(
name='delete_segment',
check_str=base.RULE_ADMIN_ONLY),
deprecated_reason=DEPRECATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
), ),
] ]