From c3b9c44f366cf2f0533d0f0c719ae0602b481f08 Mon Sep 17 00:00:00 2001
From: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Date: Thu, 26 Sep 2024 10:18:20 -0400
Subject: [PATCH] Flip ovn_emit_need_to_frag to True by default

Setting it to False is relevant only for older kernels.

Major distros ship the necessary kernel for a while, e.g. Ubuntu LTS has
5.2 since 20.04.0. RHEL ships 5.14.0 (+backports) since 9.0.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=2314429

Change-Id: I52124fccf800ecd64dfb1a2f40897dea24cd62d7
---
 neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py          | 8 ++++----
 ...ovn_emit_need_to_frag-by-default-9ba0169e70a55173.yaml | 7 +++++++
 2 files changed, 11 insertions(+), 4 deletions(-)
 create mode 100644 releasenotes/notes/enable-ovn_emit_need_to_frag-by-default-9ba0169e70a55173.yaml

diff --git a/neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py b/neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py
index d55a494a709..52a22909d46 100644
--- a/neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py
+++ b/neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py
@@ -175,12 +175,12 @@ ovn_opts = [
                        "option to be unset globally.\n"
                        "See the ovn-nb(5) man page for available options.")),
     cfg.BoolOpt('ovn_emit_need_to_frag',
-                default=False,
+                default=True,
                 help=_('Configure OVN to emit "need to frag" packets in '
                        'case of MTU mismatches.\n'
-                       'Before enabling this option make sure that '
-                       'it is supported by the host kernel (version >= 5.2) '
-                       'or by checking the output of the following command:\n'
+                       'You may have to disable this option if you are '
+                       'running an old host kernel (version < 5.2). You may '
+                       'check the output of the following command:\n'
                        'ovs-appctl -t ovs-vswitchd dpif/show-dp-features '
                        'br-int | grep "Check pkt length action".')),
     cfg.BoolOpt('disable_ovn_dhcp_for_baremetal_ports',
diff --git a/releasenotes/notes/enable-ovn_emit_need_to_frag-by-default-9ba0169e70a55173.yaml b/releasenotes/notes/enable-ovn_emit_need_to_frag-by-default-9ba0169e70a55173.yaml
new file mode 100644
index 00000000000..96fbc7aafc1
--- /dev/null
+++ b/releasenotes/notes/enable-ovn_emit_need_to_frag-by-default-9ba0169e70a55173.yaml
@@ -0,0 +1,7 @@
+---
+upgrade:
+  - |
+    The ``ovn_emit_need_to_frag`` option for OVN is now enabled by default.
+    This may result in performance issues on older kernels (older than 5.2). If
+    you are still using an old kernel, you may consider setting it to
+    ``False``.