diff --git a/doc/source/devref/effective_neutron.rst b/doc/source/devref/effective_neutron.rst index 9a204a0ff55..69d6546743e 100644 --- a/doc/source/devref/effective_neutron.rst +++ b/doc/source/devref/effective_neutron.rst @@ -207,6 +207,13 @@ System development Document common pitfalls as well as good practices done when invoking system commands and interacting with linux utils. +* When a patch requires a new platform tool or a new feature in an existing + tool, check if common platforms ship packages with the aforementioned + feature. Also, tag such a patch with ``UpgradeImpact`` to raise its + visibility (as these patches are brought up to the attention of the core team + during team meetings). More details in `review guidelines + `_. + Eventlet concurrent model ~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/doc/source/policies/code-reviews.rst b/doc/source/policies/code-reviews.rst index bdc102c9e3a..2058bbd1cd6 100644 --- a/doc/source/policies/code-reviews.rst +++ b/doc/source/policies/code-reviews.rst @@ -12,6 +12,53 @@ Neutron follows the `code review guidelines `_ + that would help interested parties to identify their platform limitation + in timely manner. + Neutron Spec Review Practices ----------------------------- In addition to code reviews, Neutron also maintains a BP specification git repository. Detailed