From 7db68e32023162d843d287a121fec64a6786e87c Mon Sep 17 00:00:00 2001 From: IWAMOTO Toshihiro Date: Thu, 10 Nov 2016 14:27:18 +0900 Subject: [PATCH] ovsfw: small cleanups to improve readability security_group_updated is actually called but of no use for ovsfw. Fix the comment to reflect the reality. In iptables_firewall, the method is used to clear obsolete conntrack entries, but ovsfw implements that differently. Also, remove empty definition of apply_port_filter, which is never called. Change-Id: I26b402e0fa5ac19022e022bf7c51e171d0f5d333 Closes-Bug: #1606462 --- neutron/agent/linux/openvswitch_firewall/firewall.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/neutron/agent/linux/openvswitch_firewall/firewall.py b/neutron/agent/linux/openvswitch_firewall/firewall.py index 48f08541605..d5f118e0212 100644 --- a/neutron/agent/linux/openvswitch_firewall/firewall.py +++ b/neutron/agent/linux/openvswitch_firewall/firewall.py @@ -186,18 +186,12 @@ class OVSFirewallDriver(firewall.FirewallDriver): self._deferred = False self._drop_all_unmatched_flows() - def apply_port_filter(self, port): - """We never call this method - - It exists here to override abstract method of parent abstract class. - """ - def security_group_updated(self, action_type, sec_group_ids, device_ids=None): - """This method is obsolete + """The current driver doesn't make use of this method. - The current driver only supports enhanced rpc calls into security group - agent. This method is never called from that place. + It exists here to avoid NotImplementedError raised from the parent + class's method. """ def _accept_flow(self, **flow):